generated from coulomb/repo-seed
Align activity-core scope boundaries
This commit is contained in:
@@ -216,11 +216,21 @@ it. The output schema must define `List[TaskSpec]` or a compatible envelope.
|
||||
|
||||
#### `review_required: true`
|
||||
|
||||
When set, the instruction's proposed task list is written to a **pending review
|
||||
queue** in issue-core rather than directly created. A human or curator agent
|
||||
reviews and approves/rejects before tasks are materialised. This is the default
|
||||
for instructions that create high-impact tasks (cross-repo changes, security
|
||||
responses, production operations).
|
||||
When set today, the instruction's task/report output is marked with
|
||||
`review_required=true` in activity-core audit metadata. For report-producing
|
||||
instructions, this flag is also persisted in configured report sinks so an
|
||||
operator can distinguish validated-but-review-worthy output from routine
|
||||
output.
|
||||
|
||||
activity-core does **not** currently route proposed tasks to a pending review
|
||||
queue. That queue must be owned by issue-core, because issue-core owns task
|
||||
lifecycle state. Until issue-core exposes a review contract, `review_required`
|
||||
is metadata only; it must not be treated as evidence that live task creation was
|
||||
held for approval.
|
||||
|
||||
Future issue-core review integration may use the same field, but that change
|
||||
must update the issue sink contract and tests before any ActivityDefinition
|
||||
relies on queue routing.
|
||||
|
||||
#### Evaluation semantics
|
||||
|
||||
@@ -286,7 +296,8 @@ This boundary makes future extraction to `rules-core` a packaging exercise, not
|
||||
tasks" behaviour is replaced by explicit rule blocks.
|
||||
- A new `RuleEvaluator` class (AST walker) is added to `src/activity_core/rules/`.
|
||||
- A new `InstructionExecutor` class handles prompt rendering, LLM call, output
|
||||
validation, and review queue routing.
|
||||
validation, and review-required audit metadata. Pending review queue routing
|
||||
remains a future issue-core integration.
|
||||
- Integration tests for rule evaluation use fixture JSON; no running Temporal required.
|
||||
- The `task_spawn_log` table is added to the Postgres schema (new Alembic migration).
|
||||
- ActivityDefinition files that omit both `rules` and `instructions` are valid
|
||||
|
||||
Reference in New Issue
Block a user