generated from coulomb/repo-seed
tegwick
fe47058e1f
src/artifactstore/app.py (new): composition root. build_registry(settings)
wires AsyncEngine + LocalBackend + InProcessDataPlane + RegistryViewWriter
into a Registry. Used by both the HTTP app and the CLI.
src/artifactstore/registry/__init__.py: adds db_health() (SELECT 1 probe),
backend_health() (pass-through to dataplane), and dispose() (engine
shutdown) helpers so the HTTP /health endpoint and CLI commands can talk
to the registry without reaching for private state.
src/artifactstore/api/http/__init__.py:
- create_app(settings=None) factory; lifespan owns the registry instance
and disposes it on shutdown.
- GET / returns the scaffold banner.
- GET /health reports overall status + db {healthy, detail} + backend
{backend_id, healthy, detail, free_bytes, total_bytes}. Uses
FastAPI Depends() with a request->state.registry helper rather than
reaching app.state directly.
- Module-level `app = create_app()` so `uvicorn artifactstore.api.http:app`
keeps working.
src/artifactstore/cli/__init__.py:
- migrate: `alembic upgrade head` via the alembic command API.
- replay: drops + rebuilds materialised views from the event log; prints
the highest applied sequence.
- health: prints the same payload as the HTTP /health endpoint, as JSON.
- version unchanged.
Tests:
- tests/integration/test_http_health.py (TestClient-based): /
scaffold banner; /health reports ok with db.healthy + backend.healthy
+ free_bytes populated.
- tests/integration/test_cli_commands.py (typer CliRunner): version
prints; migrate creates the schema (events + retention_classes +
alembic_version); replay against an empty log exits ok with
"replayed up to sequence 0"; health prints a status=ok JSON payload.
Gates: ruff clean, mypy --strict clean on 48 files, 83 tests pass.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
64 lines
2.2 KiB
Python
64 lines
2.2 KiB
Python
"""HTTP /health endpoint tests (ARTIFACT-STORE-WP-0001-T014)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
from sqlalchemy import create_engine, insert
|
|
|
|
from artifactstore.api.http import create_app
|
|
from artifactstore.config import Settings
|
|
from artifactstore.db.schema import metadata, retention_classes
|
|
from artifactstore.db.seed import RETENTION_CLASS_SEEDS
|
|
|
|
|
|
@pytest.fixture
|
|
def settings(tmp_path: Path) -> Settings:
|
|
db_path = tmp_path / "http-test.db"
|
|
storage_root = tmp_path / "storage"
|
|
storage_root.mkdir(parents=True, exist_ok=True)
|
|
# Build a fresh schema synchronously so the app starts against a
|
|
# ready-to-use database.
|
|
sync_engine = create_engine(f"sqlite:///{db_path}", future=True)
|
|
metadata.create_all(sync_engine)
|
|
with sync_engine.begin() as conn:
|
|
conn.execute(insert(retention_classes), [dict(s) for s in RETENTION_CLASS_SEEDS])
|
|
sync_engine.dispose()
|
|
return Settings(
|
|
database_url=f"sqlite+aiosqlite:///{db_path}",
|
|
storage_local_root=str(storage_root),
|
|
log_level="INFO",
|
|
)
|
|
|
|
|
|
def test_root_route_returns_banner(settings: Settings) -> None:
|
|
app = create_app(settings)
|
|
with TestClient(app) as client:
|
|
resp = client.get("/")
|
|
assert resp.status_code == 200
|
|
body = resp.json()
|
|
assert body["service"] == "artifact-store"
|
|
assert body["status"] == "scaffold"
|
|
|
|
|
|
def test_health_endpoint_reports_db_and_backend(settings: Settings) -> None:
|
|
app = create_app(settings)
|
|
with TestClient(app) as client:
|
|
resp = client.get("/health")
|
|
assert resp.status_code == 200
|
|
body = resp.json()
|
|
assert body["status"] == "ok"
|
|
assert body["db"]["healthy"] is True
|
|
assert body["db"]["detail"] == "ok"
|
|
assert body["backend"]["healthy"] is True
|
|
assert body["backend"]["backend_id"] == "local"
|
|
assert body["backend"]["free_bytes"] is not None
|
|
|
|
|
|
# NB: a "degraded backend" path test was considered but the LocalBackend
|
|
# constructor recreates its root in mkdir(parents=True, exist_ok=True) when
|
|
# the lifespan instantiates it. The unhealthy-root branch is covered
|
|
# directly in tests/unit/test_storage_local.py without that re-creation.
|