Files
artifact-store/tests/integration/test_migrations.py
tegwick f8097cb683 WP-0001-T002: registry data model, Alembic, initial migration with retention seed
Schema (src/artifactstore/db/schema.py):
- events table (ADR-0002 source of truth): sequence BIGSERIAL PK, created_at,
  event_type, subject_kind, subject_id, actor, payload (CBOR bytes),
  payload_digest. Indexes on (subject_kind, subject_id) and
  (event_type, sequence).
- artifact_packages, artifact_files, storage_locations, retention_state
  (materialised views over events).
- retention_classes (seed table) and metadata_schemas (config table).
- ADR-0001 columns present: digest_algorithm, digest_primary, digest_sha256,
  content_address. Blueprint tiering columns present: retrieval_tier
  (default 'hot'), restore_status.
- Types portable: SQLAlchemy 2.0 Core with JSON().with_variant(JSONB, 'postgresql'),
  Uuid, LargeBinary, DateTime(timezone=True), Boolean false() default.

Seed (src/artifactstore/db/seed.py): five v1 retention classes (transient,
raw-evidence, summary-evidence, release-evidence, permanent-record) with
default durations in seconds; permanent-record has no expiry.

Alembic:
- alembic.ini with sync sqlite URL default; path_separator=os to silence the
  1.13 deprecation warning.
- migrations/env.py: translates async URLs (+aiosqlite, +asyncpg) to sync
  counterparts at migrate-time so a single ARTIFACTSTORE_DATABASE_URL works
  for both runtime (async) and Alembic (sync).
- migrations/script.py.mako template.
- migrations/versions/20260516_0001_initial.py: metadata.create_all + bulk
  insert of retention class seeds.

Make:
- make migrate: alembic upgrade head (ensures var/ exists).
- make migrate-fresh: drop local SQLite + re-run.

Deps: psycopg[binary] added as optional `postgres` extra (PostgreSQL prod
path; SQLite default for dev needs no extra).

Tests:
- tests/unit/test_db_schema.py: every expected table present; ADR-0001 and
  tiering columns present; seed has the five v1 classes; permanent-record
  has no default_duration; create_all + FK insert + Boolean default
  round-trip on in-memory SQLite.
- tests/integration/test_migrations.py: alembic upgrade head against a
  tempfile SQLite produces all tables (+ alembic_version) and the seed rows.

Gates: ruff clean, mypy --strict clean on 32 files, 38 tests pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 01:50:38 +02:00

59 lines
1.7 KiB
Python

"""End-to-end migration test against a temporary SQLite DB."""
from __future__ import annotations
import os
from pathlib import Path
import pytest
from alembic import command
from alembic.config import Config
from sqlalchemy import create_engine, inspect, select
from artifactstore.db.schema import retention_classes
from artifactstore.db.seed import RETENTION_CLASS_SEEDS
REPO_ROOT = Path(__file__).resolve().parents[2]
@pytest.fixture
def temp_db_url(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> str:
db_path = tmp_path / "artifactstore-test.db"
url = f"sqlite+aiosqlite:///{db_path}"
monkeypatch.setenv("ARTIFACTSTORE_DATABASE_URL", url)
return url
def test_alembic_upgrade_head_creates_all_tables_and_seeds(temp_db_url: str) -> None:
cfg = Config(str(REPO_ROOT / "alembic.ini"))
cfg.set_main_option("script_location", str(REPO_ROOT / "migrations"))
cwd = os.getcwd()
os.chdir(REPO_ROOT)
try:
command.upgrade(cfg, "head")
finally:
os.chdir(cwd)
sync_url = temp_db_url.replace("+aiosqlite", "")
engine = create_engine(sync_url, future=True)
try:
names = set(inspect(engine).get_table_names())
assert {
"events",
"retention_classes",
"metadata_schemas",
"artifact_packages",
"artifact_files",
"storage_locations",
"retention_state",
"alembic_version",
}.issubset(names)
with engine.connect() as conn:
rows = conn.execute(select(retention_classes)).all()
seed_ids = {s["class_id"] for s in RETENTION_CLASS_SEEDS}
assert {r.class_id for r in rows} == seed_ids
finally:
engine.dispose()