generated from coulomb/repo-seed
Implement CE-WP-0002 T03-T09: ingest, anchor resolution, engine, UI, persistence, e2e
Completes the PDF review slice end-to-end. After this commit a user can
open a fixture, select text, save an evidence item with commentary, see
it in the sidebar, reload the page, click the item, and the viewer
scrolls to the passage.
- T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests
- SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe)
- PDF.js text extract; per-page normalize then join with "\n\n"
- PageMap + OffsetMap (gap-free coverage); pageLength = end - start
- Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly
- T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests
- createSelectors emits the maximal redundant set (TextQuote +
TextPosition + PdfRect + PdfPageText when available)
- resolveSelectors implements the SharedContracts §7 ladder; confidence
1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved)
- Cross-module integration test moved to tests/integration/ to honor
the anchor↛source boundary lint rule
- T05 engine: sync event bus over the closed §4 vocabulary, Map-backed
repos, services, createEngine() composition root, 12 tests
- T06 work + app: three-pane shell (CollectionList | ViewerShell |
EvidenceSidebar) wired through EngineProvider; EngineContext lives in
src/work/ to respect the work↛app boundary; SpikeApp deleted
- T07 AnnotationToolbar: pendingSelection in context; Save runs
createSelectors → engine.annotations.create → engine.evidence.create
- T08 click-to-reopen + localStorage persistence
- scrollToAnnotation state in context with a version counter so a
second click on the same item re-fires the viewer scroll
- captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage;
restore bypasses services to avoid event-loops
- active-document id persisted alongside the snapshot so reload lands
on the same fixture; ADR-0005 written
- 9 persistence tests
- T09 tests/integration/app-prd-scenario.dom.test.tsx
- end-to-end happy-dom test of PRD scenario steps 1-8 through the real
React tree; viewer + ingest mocked per ADR-0004's headless-Chromium
limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where
useEngineEventTick values were not included in the useMemo deps,
leaving stale memoization across event-driven re-renders
- vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files
- noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs
Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -8,7 +8,7 @@ repo_id: a677c189-b4e2-4f2a-9e48-faa482c277e6
|
||||
topic_slug: citation_evidence_mvp
|
||||
topic_id: 96fa8e80-9f74-40f2-84cd-644e9747b9ec
|
||||
state_hub_workstream_id: 19cb420b-c262-4c0e-afab-e85946b2cfce
|
||||
status: todo
|
||||
status: done
|
||||
owner: Bernd
|
||||
created: 2026-05-24
|
||||
updated: 2026-05-24
|
||||
@@ -129,7 +129,7 @@ and proposed alternative. Do not proceed with T03+.
|
||||
id: CE-WP-0002-T03
|
||||
state_hub_task_id: 01dad096-3521-42b9-aed9-ce0b2f5d3450
|
||||
priority: high
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T02]
|
||||
```
|
||||
|
||||
@@ -152,7 +152,7 @@ extracted canonical text must contain the manifest's known-good quote.
|
||||
id: CE-WP-0002-T04
|
||||
state_hub_task_id: 62e4839a-8026-4e15-b4cc-6685e56b3584
|
||||
priority: high
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T01, T03]
|
||||
```
|
||||
|
||||
@@ -183,7 +183,7 @@ confidence ≥ 0.9.
|
||||
id: CE-WP-0002-T05
|
||||
state_hub_task_id: b339a73a-6b58-471c-a01d-e769ea414ee7
|
||||
priority: high
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T01]
|
||||
```
|
||||
|
||||
@@ -206,7 +206,7 @@ No persistence to disk yet. ADR-0005 (persistence) is still pending.
|
||||
id: CE-WP-0002-T06
|
||||
state_hub_task_id: f400e133-6ec6-4d5a-98a0-a6408ca4125e
|
||||
priority: high
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T02, T05]
|
||||
```
|
||||
|
||||
@@ -232,7 +232,7 @@ note in ADR-0001 if it wasn't already.
|
||||
id: CE-WP-0002-T07
|
||||
state_hub_task_id: 26346a07-bf98-4d43-8b30-de2038ab72f8
|
||||
priority: high
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T04, T05, T06]
|
||||
```
|
||||
|
||||
@@ -254,7 +254,7 @@ Active state lives in a single React context for now; no Redux/Zustand.
|
||||
id: CE-WP-0002-T08
|
||||
state_hub_task_id: 469e3fb4-1b42-49a7-88dc-29a6d5055ef5
|
||||
priority: critical
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T04, T06, T07]
|
||||
```
|
||||
|
||||
@@ -276,7 +276,7 @@ Critically, this must also work **after a page reload**. Persistence to
|
||||
id: CE-WP-0002-T09
|
||||
state_hub_task_id: 77423e57-f2c5-42e1-9e6c-c9b6fa35dfcf
|
||||
priority: high
|
||||
status: todo
|
||||
status: done
|
||||
depends_on: [T07, T08]
|
||||
```
|
||||
|
||||
|
||||
Reference in New Issue
Block a user