Files
citation-evidence/src/binder/repos/in-memory-links.ts
tegwick 8607c252c4 Implement CE-WP-0003 T01-T08: form binding + visual guide overlay
T01 EvidenceLink/EvidenceSet types
  - src/shared/evidence-link.ts: status (§2.4), relation (§2.5), target
  - src/shared/evidence-set.ts: ordered group + activeEvidenceItemId
  - enum-conformance test parses SharedContracts.md and asserts the
    runtime lists match exactly

T02 Binding service + in-memory link repo + active-state machine
  - src/binder/repos/in-memory-links.ts: Map-backed EvidenceLinkRepository
  - src/binder/services/bindings.ts: link/unlink/list/update/setActive
    emitting §4 EvidenceLinkCreated / EvidenceLinkUpdated /
    EvidenceItemActivated
  - src/binder/state/active.ts: (target, evidence, annotation) reducer
    + ActiveStateProvider + useActiveState hook
  - extended engine/events/types.ts with EvidenceLinkCreated,
    EvidenceLinkUpdated, FormFieldActivated payloads

T03 Rect registry (SharedContracts §7 — contract FROZEN)
  - src/binder/visual-guide/rect-registry.ts: register/getRect/subscribe
    + invalidate + getVersion for useSyncExternalStore
  - events.ts: scroll/resize/focus pumps via window + ResizeObserver +
    IntersectionObserver, rAF-throttled
  - react-hooks.ts: RectRegistryProvider, useRegisterRect(kind,id,ref),
    useRectRegistryVersion

T04 Form schema + renderer
  - src/app/forms/demo-schema.ts: text/textarea/date minimal schema
  - src/binder/FormRenderer.tsx: renders schema, each field registers
    as rect kind="field"; active field gets aria-current="true"
  - placed in binder/ (not work/) because work cannot import binder per
    DependencyMap.md §2 and the renderer needs the rect-registry hook;
    workplan T04 was amended in-place to document this

T05 Side-by-side Forms layout + click-to-link
  - src/app/forms/FormsApp.tsx + src/app/App.tsx top-bar router with
    hash route #/forms/demo
  - BinderProvider mounted at app root so links survive tab switching
  - stage-evidence-then-click-field linking interaction with banner
    + per-field link-count chip

T06 Active-evidence cycling
  - src/app/forms/ActiveEvidenceChips.tsx: chips per active target,
    Tab cycles natively, first chip auto-activates on field focus,
    each chip registers as rect kind="evidence-card"
  - ScrollBridge in FormsApp wires activeAnnotationId to viewer scroll
  - EvidenceSidebar + EvidenceStrip highlight the active item via the
    new useLastActivatedEvidence hook in work/EngineContext

T07 SVG visual-guide overlay
  - src/binder/visual-guide/Overlay.tsx: single fixed-positioned SVG,
    draws field→card and card→highlight bezier curves for the active
    triple, rAF-throttled via the registry
  - src/anchor exposes getHighlightClientRects(annotationId); the
    spike viewer wraps highlights in [data-highlight-id] so the helper
    can locate them
  - src/app/forms/HighlightRectBridge.tsx: registers the active
    annotation's rect via that helper

T08 End-to-end test (PRD scenario steps 5-9)
  - tests/integration/forms-overlay-e2e.dom.test.tsx: full path from
    Review-mode capture through Forms-mode link to active triple +
    aria-current assertions + 2 SVG paths in the overlay
  - additional integration coverage: forms-link-flow + forms-active-cycling

Gates: typecheck ✓ · lint ✓ · build ✓ · 152/152 tests across 21 files.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-25 15:53:17 +02:00

77 lines
2.3 KiB
TypeScript
Raw Blame History

This file contains invisible Unicode characters
This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* In-memory EvidenceLink repository.
*
* Implements the storage layer for `src/binder/services/bindings.ts`. The
* repo is deliberately the same shape as the engine's MVP repos so the
* future durable-store ADR (see ADR-0005) replaces it with the same
* interface.
*
* Indexed by `(targetType, targetId)` and by `evidenceItemId` for the
* two query directions the binder needs: "all evidence for this field"
* and "all targets this evidence is linked to".
*/
import type { EvidenceLink, EvidenceTarget } from "@shared/evidence-link";
import type { EvidenceItemId, EvidenceLinkId } from "@shared/ids";
export interface EvidenceLinkRepository {
create(link: EvidenceLink): EvidenceLink;
get(id: EvidenceLinkId): EvidenceLink | null;
update(link: EvidenceLink): EvidenceLink;
delete(id: EvidenceLinkId): boolean;
listForTarget(target: EvidenceTarget): readonly EvidenceLink[];
listForEvidenceItem(id: EvidenceItemId): readonly EvidenceLink[];
list(): readonly EvidenceLink[];
}
function targetKey(target: EvidenceTarget): string {
return `${target.targetType}${target.targetId}`;
}
export function createInMemoryLinkRepo(): EvidenceLinkRepository {
const byId = new Map<EvidenceLinkId, EvidenceLink>();
return {
create(link) {
if (byId.has(link.id)) {
throw new Error(`EvidenceLinkRepository.create: duplicate id ${link.id}`);
}
byId.set(link.id, link);
return link;
},
get(id) {
return byId.get(id) ?? null;
},
update(link) {
if (!byId.has(link.id)) {
throw new Error(`EvidenceLinkRepository.update: unknown id ${link.id}`);
}
byId.set(link.id, link);
return link;
},
delete(id) {
return byId.delete(id);
},
listForTarget(target) {
const key = targetKey(target);
const out: EvidenceLink[] = [];
for (const link of byId.values()) {
if (targetKey({ targetType: link.targetType, targetId: link.targetId }) === key) {
out.push(link);
}
}
return out;
},
listForEvidenceItem(id) {
const out: EvidenceLink[] = [];
for (const link of byId.values()) {
if (link.evidenceItemId === id) out.push(link);
}
return out;
},
list() {
return [...byId.values()];
},
};
}