generated from coulomb/repo-seed
tegwick
d54daf2e61
Completes the PDF review slice end-to-end. After this commit a user can
open a fixture, select text, save an evidence item with commentary, see
it in the sidebar, reload the page, click the item, and the viewer
scrolls to the passage.
- T03 src/source/pdf/{fingerprint,extract,ingest}.ts + 39 fixture tests
- SHA-256 fingerprint over a fresh ArrayBuffer (TS BufferSource-safe)
- PDF.js text extract; per-page normalize then join with "\n\n"
- PageMap + OffsetMap (gap-free coverage); pageLength = end - start
- Updated manifest's Betriebskosten quote to one PDF.js extracts cleanly
- T04 src/anchor/selectors/{create,resolve}.ts + 25 unit + 7 fixture tests
- createSelectors emits the maximal redundant set (TextQuote +
TextPosition + PdfRect + PdfPageText when available)
- resolveSelectors implements the SharedContracts §7 ladder; confidence
1.0 (pos+quote) → 0.7 (rect-only) → 0 (unresolved)
- Cross-module integration test moved to tests/integration/ to honor
the anchor↛source boundary lint rule
- T05 engine: sync event bus over the closed §4 vocabulary, Map-backed
repos, services, createEngine() composition root, 12 tests
- T06 work + app: three-pane shell (CollectionList | ViewerShell |
EvidenceSidebar) wired through EngineProvider; EngineContext lives in
src/work/ to respect the work↛app boundary; SpikeApp deleted
- T07 AnnotationToolbar: pendingSelection in context; Save runs
createSelectors → engine.annotations.create → engine.evidence.create
- T08 click-to-reopen + localStorage persistence
- scrollToAnnotation state in context with a version counter so a
second click on the same item re-fires the viewer scroll
- captureSnapshot/restoreSnapshot/attachPersister/restoreFromStorage;
restore bypasses services to avoid event-loops
- active-document id persisted alongside the snapshot so reload lands
on the same fixture; ADR-0005 written
- 9 persistence tests
- T09 tests/integration/app-prd-scenario.dom.test.tsx
- end-to-end happy-dom test of PRD scenario steps 1-8 through the real
React tree; viewer + ingest mocked per ADR-0004's headless-Chromium
limitation. Fixed memo-deps bug in EvidenceSidebar/ViewerShell where
useEngineEventTick values were not included in the useMemo deps,
leaving stale memoization across event-driven re-renders
- vitest.config.ts: happy-dom for *.dom.test.{ts,tsx} files
- noEmit added to tsconfig so tsc -b doesn't litter src/ with .js outputs
Gates: typecheck ✓ lint ✓ test 109/109 across 11 files ✓ build ✓
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
MVP Workplans
These four workplans implement the first reference scenario from
wiki/ProductRequirementsDocument.md §20 — end-to-end PDF evidence
capture → form binding → citation card export — entirely inside the
citation-evidence repository.
| Workplan | Title | Status |
|---|---|---|
CE-WP-0001 |
Foundations — scaffold, folders, lint rules, normalize, fixtures | todo |
CE-WP-0002 |
PDF review slice — engine types, anchor, source, viewer, sidebar | todo |
CE-WP-0003 |
Form binding + visual guide — EvidenceLink, rect registry, overlay | todo |
CE-WP-0004 |
Citation card export — Markdown + HTML renderers, sidebar export | todo |
Order
Strictly sequential. CE-WP-0002 depends on the folder/lint scaffolding from
CE-WP-0001. CE-WP-0003 and CE-WP-0004 depend on the engine types,
viewer adapter, and sidebar from CE-WP-0002.
How to run a workplan
/ralph-workplan workplans/CE-WP-0001-foundations.md
Ralph drives the loop and retires automatically when all tasks in the
workplan are marked done. See ~/.claude/plugins/ralph-workplan/ralph-workplan.md.
Acceptance for MVP
The first reference scenario from PRD §20 runs end-to-end:
- Create a collection
- Upload a PDF
- Select a passage, add commentary, create an evidence item
- Open a side-by-side form
- Link the evidence item to a form field
- Focus the field → field, evidence card, and PDF passage all highlighted
- SVG guide visible between field → card → highlight
- Export evidence as a Markdown citation card