fix(WP-0017/E4): Layer 3 error fixes — round 2 (18 files)

Fixes 46 compile errors across 18 controllers and views:
- BridgeResponse missing from explicit import lists (Widgets, RequirementCandidates,
  DecisionRecords, AgentDelegations) — dot-notation HasField resolution fails without
  the type in scope under DuplicateRecordFields
- unId not in IHP v1.5 — replaced all fmap (Id . unId) with fmap coerce
- respondWith not in IHP — replaced with plain redirectTo in 5 controllers
- [hubId] list param to sqlQuery — replaced with (Only hubId) tuple
- deleteWhere not in IHP — replaced with query/filterWhere/fetch/deleteRecords
- fill @'["label"] mismatch — field is label_ in generated types, not label
- PersistUUID/toUUID (persistent-style) — replaced with (Only id)
- intercalate + jsonArrayTexts ambiguity in GovernanceTemplates — hid Index import,
  removed local duplicates, added Data.Text (intercalate)
- Int16 not in scope in AntifragilityDashboard — changed to Int (score :: Int)
- typeArraySection type mismatch in HubCapabilityManifests/Edit — unified to [Text]
- renderForm arity mismatch — added action param to DecisionRecords/New.renderForm
- Missing qualified Data.Aeson import in AdaptiveThresholds
- Missing ?request::Request constraint in Api/V2/WidgetPatterns.renderJsonWithStatus

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-04-12 12:17:45 +00:00
parent c40f11d657
commit 3737845e02
18 changed files with 120 additions and 159 deletions

View File

@@ -8,6 +8,8 @@ import Generated.Types
import IHP.Prelude
import IHP.ControllerPrelude
import Application.Helper.TypeRegistry (validateAnnotationCategory, activeAnnotationCategories)
import Data.Coerce (coerce)
import qualified Data.Text as T
validSeverities :: [Text]
validSeverities = ["low", "medium", "high", "critical"]
@@ -51,13 +53,13 @@ instance Controller AnnotationsController where
annotation
|> fill @'["body", "category", "severity", "parentId", "widgetStateRef"]
|> set #widgetId widgetId
|> set #actorId (fmap (Id . unId) actorId)
|> set #actorId (fmap coerce actorId)
|> set #actorType actorType
|> validateField #body nonEmpty
|> validateField #severity (`elem` validSeverities)
|> (case categoryResult of
Left msg -> attachFailure #category msg
Right () -> id)
Right () -> \x -> x)
|> ifValid \case
Left annotation -> render NewView { widget, annotation, categories }
Right annotation -> do
@@ -85,10 +87,10 @@ instance Controller AnnotationsController where
|> set #sourceAnnotationId (Just annotationId)
|> set #category annotation.category
|> set #status "open"
|> set #createdBy (fmap (Id . unId) createdBy)
|> set #createdBy (fmap coerce createdBy)
|> createRecord
setSuccessMessage "Escalated to requirement candidate"
redirectTo ShowRequirementCandidateAction { requirementCandidateId = candidate.id }
truncate80 :: Text -> Text
truncate80 t = if length t > 80 then take 80 t <> "" else t
truncate80 t = if T.length t > 80 then T.take 80 t <> "" else t