generated from coulomb/repo-seed
fix(WP-0017/E4): Layer 3 error fixes — round 2 (18 files)
Fixes 46 compile errors across 18 controllers and views: - BridgeResponse missing from explicit import lists (Widgets, RequirementCandidates, DecisionRecords, AgentDelegations) — dot-notation HasField resolution fails without the type in scope under DuplicateRecordFields - unId not in IHP v1.5 — replaced all fmap (Id . unId) with fmap coerce - respondWith not in IHP — replaced with plain redirectTo in 5 controllers - [hubId] list param to sqlQuery — replaced with (Only hubId) tuple - deleteWhere not in IHP — replaced with query/filterWhere/fetch/deleteRecords - fill @'["label"] mismatch — field is label_ in generated types, not label - PersistUUID/toUUID (persistent-style) — replaced with (Only id) - intercalate + jsonArrayTexts ambiguity in GovernanceTemplates — hid Index import, removed local duplicates, added Data.Text (intercalate) - Int16 not in scope in AntifragilityDashboard — changed to Int (score :: Int) - typeArraySection type mismatch in HubCapabilityManifests/Edit — unified to [Text] - renderForm arity mismatch — added action param to DecisionRecords/New.renderForm - Missing qualified Data.Aeson import in AdaptiveThresholds - Missing ?request::Request constraint in Api/V2/WidgetPatterns.renderJsonWithStatus Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -8,11 +8,12 @@ import Web.View.DecisionRecords.Edit
|
||||
import Generated.Types
|
||||
import IHP.Prelude
|
||||
import IHP.ControllerPrelude
|
||||
import Application.Helper.AgentBridge (callAgent, checkGovernancePolicy, bridgeErrorMessage)
|
||||
import Application.Helper.AgentBridge (callAgent, checkGovernancePolicy, bridgeErrorMessage, BridgeResponse)
|
||||
import Application.Helper.ModelRouter (resolveAgent)
|
||||
import Data.List (intercalate)
|
||||
import IHP.ModelSupport (sqlQuery)
|
||||
import qualified Data.Aeson as A
|
||||
import Data.Coerce (coerce)
|
||||
|
||||
validOutcomes :: [Text]
|
||||
validOutcomes = ["accepted", "rejected", "deferred", "split", "merged", "reframed"]
|
||||
@@ -91,7 +92,7 @@ instance Controller DecisionRecordsController where
|
||||
let record = newRecord @DecisionRecord
|
||||
record
|
||||
|> fill @'["title", "rationale", "outcome", "requirementId", "candidateId", "notes"]
|
||||
|> set #decidedBy (fmap (Id . unId) decidedBy)
|
||||
|> set #decidedBy (fmap coerce decidedBy)
|
||||
|> validateField #title nonEmpty
|
||||
|> validateField #rationale nonEmpty
|
||||
|> validateField #outcome (`elem` validOutcomes)
|
||||
@@ -134,13 +135,12 @@ instance Controller DecisionRecordsController where
|
||||
constraintNote = paramOrNothing @Text "constraintNote"
|
||||
unless (policyScope `elem` validPolicyScopes) do
|
||||
setErrorMessage ("Invalid policy scope: " <> policyScope)
|
||||
respondWith 422 do
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
newRecord @PolicyReference
|
||||
|> set #decisionId decisionRecordId
|
||||
|> set #policyScope policyScope
|
||||
|> set #constraintNote constraintNote
|
||||
|> set #createdBy (fmap (Id . unId) createdBy)
|
||||
|> set #createdBy (fmap coerce createdBy)
|
||||
|> createRecord
|
||||
setSuccessMessage "Policy reference added"
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
@@ -159,17 +159,15 @@ instance Controller DecisionRecordsController where
|
||||
system = param @Text "system"
|
||||
unless (system `elem` validSystems) do
|
||||
setErrorMessage ("Invalid system: " <> system)
|
||||
respondWith 422 do
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
when (workItemRef == "") do
|
||||
setErrorMessage "Work item reference cannot be empty"
|
||||
respondWith 422 do
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
newRecord @ImplementationChangeReference
|
||||
|> set #decisionId decisionRecordId
|
||||
|> set #workItemRef workItemRef
|
||||
|> set #system system
|
||||
|> set #linkedBy (fmap (Id . unId) linkedBy)
|
||||
|> set #linkedBy (fmap coerce linkedBy)
|
||||
|> createRecord
|
||||
setSuccessMessage "Implementation reference added"
|
||||
redirectTo ShowDecisionRecordAction { decisionRecordId }
|
||||
|
||||
Reference in New Issue
Block a user