coulomb/inter-hub
2
0
Fork 0
generated from coulomb/repo-seed
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(WP-0017/E4): Layer 3 error fixes — round 2 (18 files)

Browse Source 
Fixes 46 compile errors across 18 controllers and views:
- BridgeResponse missing from explicit import lists (Widgets, RequirementCandidates,
  DecisionRecords, AgentDelegations) — dot-notation HasField resolution fails without
  the type in scope under DuplicateRecordFields
- unId not in IHP v1.5 — replaced all fmap (Id . unId) with fmap coerce
- respondWith not in IHP — replaced with plain redirectTo in 5 controllers
- [hubId] list param to sqlQuery — replaced with (Only hubId) tuple
- deleteWhere not in IHP — replaced with query/filterWhere/fetch/deleteRecords
- fill @'["label"] mismatch — field is label_ in generated types, not label
- PersistUUID/toUUID (persistent-style) — replaced with (Only id)
- intercalate + jsonArrayTexts ambiguity in GovernanceTemplates — hid Index import,
  removed local duplicates, added Data.Text (intercalate)
- Int16 not in scope in AntifragilityDashboard — changed to Int (score :: Int)
- typeArraySection type mismatch in HubCapabilityManifests/Edit — unified to [Text]
- renderForm arity mismatch — added action param to DecisionRecords/New.renderForm
- Missing qualified Data.Aeson import in AdaptiveThresholds
- Missing ?request::Request constraint in Api/V2/WidgetPatterns.renderJsonWithStatus

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Bernd Worsch
2026-04-12 12:17:45 +00:00
parent c40f11d657
commit 3737845e02
18 changed files with 120 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
Web/View/HubCapabilityManifests/Edit.hs
View File

@@ -6,7 +6,6 @@ import IHP.Prelude
import IHP.ViewPrelude
import Web.Routes ()
import Data.Aeson (Value(..), encode, decode)
import qualified Data.Vector as V
import qualified Data.ByteString.Lazy.Char8 as BL
data EditView = EditView
@@ -51,10 +50,10 @@ instance View EditView where
</div>
</div>
{typeArraySection "Declared Widget Types" "declaredWidgetTypes" manifest.declaredWidgetTypes widgetTypeEntries}
{typeArraySection "Declared Event Types" "declaredEventTypes" manifest.declaredEventTypes eventTypeEntries}
{typeArraySection2 "Declared Annotation Categories" "declaredAnnotationCategories" manifest.declaredAnnotationCategories categoryEntries}
{typeArraySection3 "Declared Policy Scopes" "declaredPolicyScopes" manifest.declaredPolicyScopes policyScopeEntries}
{typeArraySection "Declared Widget Types" "declaredWidgetTypes" manifest.declaredWidgetTypes (map (.name) widgetTypeEntries)}
{typeArraySection "Declared Event Types" "declaredEventTypes" manifest.declaredEventTypes (map (.name) eventTypeEntries)}
{typeArraySection "Declared Annotation Categories" "declaredAnnotationCategories" manifest.declaredAnnotationCategories (map (.name) categoryEntries)}
{typeArraySection "Declared Policy Scopes" "declaredPolicyScopes" manifest.declaredPolicyScopes (map (.name) policyScopeEntries)}
<div class="flex gap-3">
<button type="submit"
@@ -77,8 +76,8 @@ renderActivateLink mid = [hsx|
|]
-- | Render a JSON array text area with available registry options shown below.
typeArraySection :: Text -> Text -> Value -> [WidgetTypeRegistry] -> Html
typeArraySection title fieldName val entries = [hsx|
typeArraySection :: Text -> Text -> Value -> [Text] -> Html
typeArraySection title fieldName val names = [hsx|
<div class="bg-white rounded-lg border border-gray-200 p-5">
<h2 class="text-sm font-semibold text-gray-700 mb-1">{title}</h2>
<p class="text-xs text-gray-500 mb-2">
@@ -89,35 +88,7 @@ typeArraySection title fieldName val entries = [hsx|
class="w-full border border-gray-300 rounded px-3 py-2 text-sm font-mono"
rows="3">{valueText val}</textarea>
<p class="text-xs text-gray-400 mt-1">
Registered: {intercalate ", " (map (.name) entries)}
</p>
</div>
|]
typeArraySection2 :: Text -> Text -> Value -> [AnnotationCategoryRegistry] -> Html
typeArraySection2 title fieldName val entries = [hsx|
<div class="bg-white rounded-lg border border-gray-200 p-5">
<h2 class="text-sm font-semibold text-gray-700 mb-1">{title}</h2>
<p class="text-xs text-gray-500 mb-2">JSON array of annotation category names.</p>
<textarea name={fieldName}
class="w-full border border-gray-300 rounded px-3 py-2 text-sm font-mono"
rows="3">{valueText val}</textarea>
<p class="text-xs text-gray-400 mt-1">
Registered: {intercalate ", " (map (.name) entries)}
</p>
</div>
|]
typeArraySection3 :: Text -> Text -> Value -> [PolicyScopeRegistry] -> Html
typeArraySection3 title fieldName val entries = [hsx|
<div class="bg-white rounded-lg border border-gray-200 p-5">
<h2 class="text-sm font-semibold text-gray-700 mb-1">{title}</h2>
<p class="text-xs text-gray-500 mb-2">JSON array of policy scope names.</p>
<textarea name={fieldName}
class="w-full border border-gray-300 rounded px-3 py-2 text-sm font-mono"
rows="3">{valueText val}</textarea>
<p class="text-xs text-gray-400 mt-1">
Registered: {intercalate ", " (map (.name) entries)}
Registered: {joinNames names}
</p>
</div>
|]
@@ -135,7 +106,7 @@ renderReadOnlyWarning manifest
valueText :: Value -> Text
valueText v = cs (BL.unpack (encode v))
intercalate :: Text -> [Text] -> Text
intercalate _ [] = ""
intercalate _ [x] = x
intercalate sep (x:xs) = x <> sep <> intercalate sep xs
joinNames :: [Text] -> Text
joinNames [] = ""
joinNames [x] = x
joinNames (x:xs) = x <> ", " <> joinNames xs