coulomb/markitect-main
2
0
Fork 0
Code Issues 61 Pull Requests Actions Projects 12 Releases 1 Wiki Activity

fix: Eliminate all 111 test warnings by fixing root causes
Some checks failed
Test Suite / unit-tests (3.11) (push) Has been cancelled
Details
Test Suite / unit-tests (3.12) (push) Has been cancelled
Details
Test Suite / integration-tests (push) Has been cancelled
Details
Test Suite / e2e-tests (push) Has been cancelled
Details
Test Suite / performance-tests (push) Has been cancelled
Details
Test Suite / code-quality (push) Has been cancelled
Details
Test Suite / security-scan (push) Has been cancelled
Details
Test Suite / test-summary (push) Has been cancelled
Details

Browse Source 
- Replace deprecated datetime.utcnow() with datetime.now(timezone.utc)
  across all domain models, services, infrastructure, and test files
- Add missing timezone imports to all affected files
- Fix pytest.ini configuration format from [tool:pytest] to [pytest]
- Remove warning suppressions to expose actual issues
- Ensure proper pytest marker registration for smoke tests

Results:
- 305 passed, 2 skipped, 0 warnings (down from 111 warnings)
- All functionality preserved with modern datetime API usage
- Improved code quality by addressing root causes vs suppression

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Bernd Worsch
2025-09-27 20:14:22 +02:00
parent 92fa0e9151
commit 1fa0f1e84a
11 changed files with 115 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/unit/domain/issues/test_issue_models.py
View File

@@ -5,7 +5,7 @@ Tests pure business logic with no external dependencies.
"""
import pytest
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from domain.issues.models import Issue, Label, IssueState, LabelCategories
from domain.issues.exceptions import IssueStateError
@@ -71,8 +71,8 @@ class TestIssue:
def test_issue_creation_with_valid_data(self):
# Arrange
created_at = datetime.utcnow()
updated_at = datetime.utcnow()
created_at = datetime.now(timezone.utc)
updated_at = datetime.now(timezone.utc)
labels = [Label("bug"), Label("priority:high")]
# Act
@@ -107,8 +107,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=labels,
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -128,8 +128,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -147,9 +147,9 @@ class TestIssue:
title="Test",
state=IssueState.CLOSED,
labels=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow(),
closed_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc),
closed_at=datetime.now(timezone.utc)
)
# Act & Assert
@@ -167,9 +167,9 @@ class TestIssue:
title="Test",
state=IssueState.CLOSED,
labels=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow(),
closed_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc),
closed_at=datetime.now(timezone.utc)
)
# Act
@@ -186,8 +186,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act & Assert
@@ -203,8 +203,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=[Label("bug")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
new_label = Label("priority:high")
@@ -223,8 +223,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=[label],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -240,8 +240,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=[Label("bug"), Label("priority:high")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -258,8 +258,8 @@ class TestIssue:
title="Test",
state=IssueState.OPEN,
labels=[Label("bug"), Label("priority:high")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act & Assert

62
tests/unit/domain/issues/test_issue_services.py
View File

@@ -5,7 +5,7 @@ Tests business logic in issue services with no external dependencies.
"""
import pytest
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from domain.issues.models import Issue, Label, IssueState
from domain.issues.services import IssueStatusService, IssueValidationService
@@ -26,8 +26,8 @@ class TestIssueStatusService:
title="Closed Issue",
state=IssueState.CLOSED,
labels=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
project_info = {"kanban_columns": ["Todo", "In Progress", "Review", "Done"]}
@@ -50,8 +50,8 @@ class TestIssueStatusService:
title="Test Issue",
state=IssueState.OPEN,
labels=[Label(status_label)],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
project_info = {"kanban_columns": ["Todo", "In Progress", "Review", "Blocked", "Ready", "Done"]}
@@ -68,8 +68,8 @@ class TestIssueStatusService:
title="New Issue",
state=IssueState.OPEN,
labels=[Label("bug")], # No status label
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
project_info = {"kanban_columns": ["Todo", "In Progress", "Done"]}
@@ -92,8 +92,8 @@ class TestIssueStatusService:
title="Test",
state=IssueState.OPEN,
labels=[Label(priority_label)],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -110,8 +110,8 @@ class TestIssueStatusService:
title="Test",
state=IssueState.OPEN,
labels=[Label("bug")], # No priority label
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -128,8 +128,8 @@ class TestIssueStatusService:
title="Test",
state=IssueState.OPEN,
labels=[Label("status:in-progress")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -143,14 +143,14 @@ class TestIssueStatusService:
def test_extract_state_info_for_closed_issue(self, service):
# Arrange
closed_at = datetime.utcnow()
closed_at = datetime.now(timezone.utc)
issue = Issue(
number=1,
title="Test",
state=IssueState.CLOSED,
labels=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow(),
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc),
closed_at=closed_at
)
@@ -164,14 +164,14 @@ class TestIssueStatusService:
def test_calculate_issue_age_days(self, service):
# Arrange
created_at = datetime.utcnow() - timedelta(days=5)
created_at = datetime.now(timezone.utc) - timedelta(days=5)
issue = Issue(
number=1,
title="Test",
state=IssueState.OPEN,
labels=[],
created_at=created_at,
updated_at=datetime.utcnow()
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -182,14 +182,14 @@ class TestIssueStatusService:
def test_is_stale_issue_with_old_open_issue(self, service):
# Arrange
created_at = datetime.utcnow() - timedelta(days=45)
created_at = datetime.now(timezone.utc) - timedelta(days=45)
issue = Issue(
number=1,
title="Test",
state=IssueState.OPEN,
labels=[],
created_at=created_at,
updated_at=datetime.utcnow()
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -200,14 +200,14 @@ class TestIssueStatusService:
def test_is_stale_issue_with_recent_open_issue(self, service):
# Arrange
created_at = datetime.utcnow() - timedelta(days=15)
created_at = datetime.now(timezone.utc) - timedelta(days=15)
issue = Issue(
number=1,
title="Test",
state=IssueState.OPEN,
labels=[],
created_at=created_at,
updated_at=datetime.utcnow()
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -218,15 +218,15 @@ class TestIssueStatusService:
def test_is_stale_issue_with_closed_issue_never_stale(self, service):
# Arrange
created_at = datetime.utcnow() - timedelta(days=100)
created_at = datetime.now(timezone.utc) - timedelta(days=100)
issue = Issue(
number=1,
title="Test",
state=IssueState.CLOSED,
labels=[],
created_at=created_at,
updated_at=datetime.utcnow(),
closed_at=datetime.utcnow()
updated_at=datetime.now(timezone.utc),
closed_at=datetime.now(timezone.utc)
)
# Act
@@ -322,8 +322,8 @@ class TestIssueValidationService:
title="Test",
state=IssueState.OPEN,
labels=[Label("bug")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
new_label = "enhancement"
@@ -337,8 +337,8 @@ class TestIssueValidationService:
title="Test",
state=IssueState.OPEN,
labels=[Label("bug")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
new_label = "bug"
@@ -355,8 +355,8 @@ class TestIssueValidationService:
title="Test",
state=IssueState.OPEN,
labels=[Label("priority:high")],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
new_label = "priority:low"

76
tests/unit/domain/projects/test_project_models.py
View File

@@ -5,7 +5,7 @@ Tests pure business logic with no external dependencies.
"""
import pytest
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from domain.projects.models import Project, Milestone, ProjectState
from domain.projects.exceptions import MilestoneError
@@ -16,7 +16,7 @@ class TestMilestone:
def test_milestone_creation(self):
# Arrange
due_date = datetime.utcnow() + timedelta(days=30)
due_date = datetime.now(timezone.utc) + timedelta(days=30)
# Act
milestone = Milestone(
@@ -91,7 +91,7 @@ class TestMilestone:
def test_is_overdue_with_past_due_date(self):
# Arrange
past_date = datetime.utcnow() - timedelta(days=1)
past_date = datetime.now(timezone.utc) - timedelta(days=1)
milestone = Milestone(
id=1,
title="Test",
@@ -107,7 +107,7 @@ class TestMilestone:
def test_is_overdue_with_future_due_date(self):
# Arrange
future_date = datetime.utcnow() + timedelta(days=1)
future_date = datetime.now(timezone.utc) + timedelta(days=1)
milestone = Milestone(
id=1,
title="Test",
@@ -138,7 +138,7 @@ class TestMilestone:
def test_is_overdue_with_closed_milestone(self):
# Arrange
past_date = datetime.utcnow() - timedelta(days=1)
past_date = datetime.now(timezone.utc) - timedelta(days=1)
milestone = Milestone(
id=1,
title="Test",
@@ -298,8 +298,8 @@ class TestProject:
def test_project_creation(self):
# Arrange
created_at = datetime.utcnow()
updated_at = datetime.utcnow()
created_at = datetime.now(timezone.utc)
updated_at = datetime.now(timezone.utc)
milestones = [
Milestone(1, "M1", None, None, "open", 2, 1),
Milestone(2, "M2", None, None, "closed", 0, 3)
@@ -336,8 +336,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=milestones,
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -360,8 +360,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=milestones,
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -372,8 +372,8 @@ class TestProject:
def test_get_overdue_milestones(self):
# Arrange
past_date = datetime.utcnow() - timedelta(days=1)
future_date = datetime.utcnow() + timedelta(days=1)
past_date = datetime.now(timezone.utc) - timedelta(days=1)
future_date = datetime.now(timezone.utc) + timedelta(days=1)
milestones = [
Milestone(1, "M1", None, past_date, "open", 2, 1), # Overdue
Milestone(2, "M2", None, future_date, "open", 1, 0), # Not overdue
@@ -385,8 +385,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=milestones,
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -408,8 +408,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=milestones,
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -426,8 +426,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -448,8 +448,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=milestones,
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act & Assert
@@ -465,8 +465,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -484,9 +484,9 @@ class TestProject:
state=ProjectState.ARCHIVED,
milestones=[],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow(),
archived_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc),
archived_at=datetime.now(timezone.utc)
)
# Act
@@ -504,8 +504,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
milestone = Milestone(1, "New Milestone", None, None, "open", 0, 0)
@@ -526,8 +526,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[milestone1],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act & Assert
@@ -543,8 +543,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[milestone],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -561,8 +561,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act & Assert
@@ -578,8 +578,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[milestone],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act
@@ -596,8 +596,8 @@ class TestProject:
state=ProjectState.ACTIVE,
milestones=[],
kanban_columns=[],
created_at=datetime.utcnow(),
updated_at=datetime.utcnow()
created_at=datetime.now(timezone.utc),
updated_at=datetime.now(timezone.utc)
)
# Act