coulomb/markitect-main
2
0
Fork 0
Code Issues 60 Pull Requests Actions Projects 12 Releases 1 Wiki Activity

fix: resolve ConfigurationManager API method calls in Issue #37 tests

Browse Source 
Fix TestEmojiConfiguration test errors by updating method calls to match
actual ConfigurationManager API signatures:
- get_config() → get_current_config()
- get_environment_variables() → _get_relevant_env_vars()

All 28 Issue #37 tests now pass successfully, completing emoji flag
integration with configuration system implementation.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Bernd Worsch
2025-10-06 18:04:05 +02:00
parent e46e97801d
commit 313a1752aa
2 changed files with 85 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/test_issue_37_configuration_integration.py
View File

@@ -23,16 +23,16 @@ class TestEmojiConfigurationIntegration:
"""Test that ConfigurationManager recognizes MARKITECT_EMOJI environment variable - Issue #37."""
with patch.dict(os.environ, {'MARKITECT_EMOJI': 'false'}, clear=False):
config_manager = ConfigurationManager()
env_vars = config_manager.get_environment_variables()
env_vars = config_manager._get_relevant_env_vars()
# Should include MARKITECT_EMOJI in recognized environment variables
assert any('MARKITECT_EMOJI' in str(var) for var in env_vars)
assert 'MARKITECT_EMOJI' in env_vars or any('MARKITECT_EMOJI' in str(var) for var in env_vars.values())
def test_config_manager_includes_emoji_in_config_summary(self):
"""Test that emoji settings are included in configuration summary - Issue #37."""
with patch.dict(os.environ, {'MARKITECT_EMOJI': 'true'}, clear=False):
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Configuration should include emoji-related settings
# This tests the integration point even if the exact structure varies
@@ -54,7 +54,7 @@ class TestEmojiConfigurationIntegration:
# Load config and verify emoji setting
with patch.dict(os.environ, {'MARKITECT_CONFIG': str(config_file)}, clear=False):
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Should have loaded the emoji preference
assert config is not None
@@ -78,7 +78,7 @@ class TestEmojiConfigurationIntegration:
'MARKITECT_EMOJI': 'true'
}, clear=False):
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Environment variable should take precedence
assert config is not None
@@ -99,7 +99,7 @@ class TestEmojiConfigurationIntegration:
try:
with patch.dict(os.environ, {'MARKITECT_CONFIG': str(config_file)}, clear=False):
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Should not raise validation errors
assert config is not None
@@ -117,7 +117,7 @@ class TestEmojiConfigurationIntegration:
with patch.dict(os.environ, clean_env, clear=True):
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Should have sensible defaults
assert config is not None
@@ -130,7 +130,7 @@ class TestEmojiConfigurationIntegration:
# Test configuration export/dump functionality
try:
config_summary = config_manager.get_environment_variables()
config_summary = config_manager._get_relevant_env_vars()
assert config_summary is not None
# Should include emoji-related information
@@ -163,7 +163,7 @@ class TestEmojiConfigurationIntegration:
'MARKITECT_EMOJI': 'false' # Should override config file
}, clear=False):
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Verify configuration loaded successfully
assert config is not None
@@ -188,7 +188,7 @@ class TestEmojiConfigurationIntegration:
with patch.dict(os.environ, {'MARKITECT_CONFIG': str(config_file)}, clear=False):
try:
config_manager = ConfigurationManager()
config = config_manager.get_config()
config = config_manager.get_current_config()
# Should either succeed with defaults or fail gracefully
assert config is None or isinstance(config, dict)
@@ -212,13 +212,13 @@ class TestEmojiConfigurationIntegration:
# Load config in first "session"
with patch.dict(os.environ, {'MARKITECT_CONFIG': str(config_file)}, clear=False):
config_manager1 = ConfigurationManager()
config1 = config_manager1.get_config()
config1 = config_manager1.get_current_config()
assert config1 is not None
# Load config in second "session" (different instance)
config_manager2 = ConfigurationManager()
config2 = config_manager2.get_config()
config2 = config_manager2.get_current_config()
assert config2 is not None
# Should be consistent across instances