feat(prompts): implement Phase 6 - Incremental Execution (FR-7, FR-8)
Add change detection, structural diff-based impact analysis, configurable-depth incremental recomputation with circular suppression, and impact debt tracking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
213
tests/integration/prompts/test_circular_suppression.py
Normal file
213
tests/integration/prompts/test_circular_suppression.py
Normal file
@@ -0,0 +1,213 @@
|
||||
"""
|
||||
Integration tests for circular dependency suppression.
|
||||
|
||||
Tests circular dependency handling with real DB, debt recording,
|
||||
and various cycle topologies.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
|
||||
from markitect.prompts.models import Artifact, ArtifactType
|
||||
from markitect.prompts.repositories.sqlite import SQLiteArtifactRepository
|
||||
from markitect.prompts.dependencies.models import DependencyEdge, EdgeType
|
||||
from markitect.prompts.dependencies.repository import SQLiteDependencyRepository
|
||||
from markitect.prompts.dependencies.queries import DependencyQueryService
|
||||
from markitect.prompts.incremental.detector import ChangeDetector
|
||||
from markitect.prompts.incremental.engine import IncrementalExecutionEngine
|
||||
from markitect.prompts.incremental.models import RecomputeConfig, ChangeType
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def temp_db():
|
||||
"""Create temporary database for testing."""
|
||||
with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as f:
|
||||
db_path = f.name
|
||||
yield db_path
|
||||
Path(db_path).unlink(missing_ok=True)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def artifact_repo(temp_db):
|
||||
"""Create artifact repository."""
|
||||
return SQLiteArtifactRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def dep_repo(temp_db):
|
||||
"""Create dependency repository."""
|
||||
return SQLiteDependencyRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def query_service(dep_repo):
|
||||
"""Create DependencyQueryService."""
|
||||
return DependencyQueryService(dep_repo)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def detector(temp_db):
|
||||
"""Create ChangeDetector."""
|
||||
return ChangeDetector(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def engine(temp_db, query_service):
|
||||
"""Create IncrementalExecutionEngine."""
|
||||
return IncrementalExecutionEngine(temp_db, query_service)
|
||||
|
||||
|
||||
def _create_artifact(repo, space_id, name, content="content"):
|
||||
"""Helper to create and persist an artifact."""
|
||||
artifact = Artifact.create(
|
||||
space_id=space_id,
|
||||
name=name,
|
||||
content=content,
|
||||
artifact_type=ArtifactType.CONTENT,
|
||||
)
|
||||
return repo.create(artifact)
|
||||
|
||||
|
||||
def _create_edge(repo, src, tgt, run_id="run-1"):
|
||||
"""Helper to create and persist a dependency edge."""
|
||||
edge = DependencyEdge.create(
|
||||
source_artifact_id=src,
|
||||
target_artifact_id=tgt,
|
||||
run_id=run_id,
|
||||
edge_type=EdgeType.REQUIRES,
|
||||
)
|
||||
return repo.create(edge)
|
||||
|
||||
|
||||
class TestDirectCircularSuppression:
|
||||
"""Tests for direct circular dependency (A <-> B) suppression."""
|
||||
|
||||
def test_mutual_dependency_suppressed(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test mutual dependency suppresses recompute and records debt."""
|
||||
art_a = _create_artifact(artifact_repo, "space-1", "a", "content-a")
|
||||
art_b = _create_artifact(artifact_repo, "space-1", "b", "content-b")
|
||||
|
||||
# A -> B and B -> A (circular)
|
||||
_create_edge(dep_repo, art_a.id, art_b.id)
|
||||
_create_edge(dep_repo, art_b.id, art_a.id)
|
||||
|
||||
# Detect change in B
|
||||
change = detector.detect_change(art_b, "content-b-modified")
|
||||
assert change is not None
|
||||
detector.record_change(change)
|
||||
|
||||
# Recompute: A depends on B, but A -> B creates cycle
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="content-b",
|
||||
new_content="content-b-modified",
|
||||
)
|
||||
|
||||
assert result.total_dependents == 1
|
||||
assert result.suppressed_count == 1
|
||||
assert result.recomputed_count == 0
|
||||
assert result.suppressed[0].suppression_reason == "circular_dependency"
|
||||
|
||||
def test_debt_persisted_for_circular(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test that circular suppression debt is persisted in DB."""
|
||||
art_a = _create_artifact(artifact_repo, "space-1", "a", "a-v1")
|
||||
art_b = _create_artifact(artifact_repo, "space-1", "b", "b-v1")
|
||||
|
||||
_create_edge(dep_repo, art_a.id, art_b.id)
|
||||
_create_edge(dep_repo, art_b.id, art_a.id)
|
||||
|
||||
change = detector.detect_change(art_b, "b-v2")
|
||||
detector.record_change(change)
|
||||
|
||||
engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="b-v1",
|
||||
new_content="b-v2",
|
||||
)
|
||||
|
||||
# Verify debt persisted
|
||||
debt = engine.get_debt_for_artifact(art_b.id)
|
||||
assert len(debt) == 1
|
||||
assert debt[0].suppression_reason == "circular_dependency"
|
||||
assert debt[0].dependent_run_id == art_a.id
|
||||
|
||||
|
||||
class TestThreeNodeCycleSuppression:
|
||||
"""Tests for three-node circular dependency suppression."""
|
||||
|
||||
def test_three_node_cycle(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test 3-node cycle: A -> B -> C -> A."""
|
||||
art_a = _create_artifact(artifact_repo, "space-1", "a", "a")
|
||||
art_b = _create_artifact(artifact_repo, "space-1", "b", "b")
|
||||
art_c = _create_artifact(artifact_repo, "space-1", "c", "c")
|
||||
|
||||
# A -> B -> C -> A
|
||||
_create_edge(dep_repo, art_a.id, art_b.id)
|
||||
_create_edge(dep_repo, art_b.id, art_c.id)
|
||||
_create_edge(dep_repo, art_c.id, art_a.id)
|
||||
|
||||
# Change C, dependent at depth 1 is B
|
||||
change = detector.detect_change(art_c, "c-modified")
|
||||
detector.record_change(change)
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="c",
|
||||
new_content="c-modified",
|
||||
)
|
||||
|
||||
# B depends on C. would_create_cycle(B, C) checks if C can reach B.
|
||||
# C -> A -> B: yes, C can reach B. So B is suppressed.
|
||||
assert result.total_dependents == 1
|
||||
assert result.suppressed_count == 1
|
||||
assert result.suppressed[0].suppression_reason == "circular_dependency"
|
||||
|
||||
|
||||
class TestMixedCircularAndNormal:
|
||||
"""Tests with a mix of circular and normal dependencies."""
|
||||
|
||||
def test_some_suppressed_some_recomputed(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test graph with both circular and normal dependents."""
|
||||
art_a = _create_artifact(artifact_repo, "space-1", "a", "a")
|
||||
art_b = _create_artifact(artifact_repo, "space-1", "b", "b")
|
||||
art_c = _create_artifact(artifact_repo, "space-1", "c", "c")
|
||||
|
||||
# B -> A (normal), A -> B (creates cycle with B -> A)
|
||||
# C -> A (normal, no cycle)
|
||||
_create_edge(dep_repo, art_b.id, art_a.id)
|
||||
_create_edge(dep_repo, art_a.id, art_b.id)
|
||||
_create_edge(dep_repo, art_c.id, art_a.id)
|
||||
|
||||
# Change A: dependents are B and C
|
||||
change = detector.detect_change(art_a, "a-modified")
|
||||
detector.record_change(change)
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="a",
|
||||
new_content="a-modified",
|
||||
)
|
||||
|
||||
assert result.total_dependents == 2
|
||||
|
||||
# B has circular dep with A → suppressed
|
||||
# C has no circular dep with A → recomputed
|
||||
circular_debts = [d for d in result.suppressed if d.suppression_reason == "circular_dependency"]
|
||||
assert len(circular_debts) == 1
|
||||
assert circular_debts[0].dependent_run_id == art_b.id
|
||||
|
||||
assert result.recomputed_count == 1
|
||||
assert art_c.id in result.executed_run_ids
|
||||
289
tests/integration/prompts/test_impact_debt.py
Normal file
289
tests/integration/prompts/test_impact_debt.py
Normal file
@@ -0,0 +1,289 @@
|
||||
"""
|
||||
Integration tests for impact debt tracking.
|
||||
|
||||
Tests below-threshold suppression, budget exhaustion, and debt querying
|
||||
with a real SQLite database.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
|
||||
from markitect.prompts.models import Artifact, ArtifactType
|
||||
from markitect.prompts.repositories.sqlite import SQLiteArtifactRepository
|
||||
from markitect.prompts.dependencies.models import DependencyEdge, EdgeType
|
||||
from markitect.prompts.dependencies.repository import SQLiteDependencyRepository
|
||||
from markitect.prompts.dependencies.queries import DependencyQueryService
|
||||
from markitect.prompts.incremental.detector import ChangeDetector
|
||||
from markitect.prompts.incremental.engine import IncrementalExecutionEngine
|
||||
from markitect.prompts.incremental.models import RecomputeConfig
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def temp_db():
|
||||
"""Create temporary database for testing."""
|
||||
with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as f:
|
||||
db_path = f.name
|
||||
yield db_path
|
||||
Path(db_path).unlink(missing_ok=True)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def artifact_repo(temp_db):
|
||||
"""Create artifact repository."""
|
||||
return SQLiteArtifactRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def dep_repo(temp_db):
|
||||
"""Create dependency repository."""
|
||||
return SQLiteDependencyRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def query_service(dep_repo):
|
||||
"""Create DependencyQueryService."""
|
||||
return DependencyQueryService(dep_repo)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def detector(temp_db):
|
||||
"""Create ChangeDetector."""
|
||||
return ChangeDetector(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def engine(temp_db, query_service):
|
||||
"""Create IncrementalExecutionEngine."""
|
||||
return IncrementalExecutionEngine(temp_db, query_service)
|
||||
|
||||
|
||||
def _create_artifact(repo, space_id, name, content="content"):
|
||||
"""Helper to create and persist an artifact."""
|
||||
artifact = Artifact.create(
|
||||
space_id=space_id,
|
||||
name=name,
|
||||
content=content,
|
||||
artifact_type=ArtifactType.CONTENT,
|
||||
)
|
||||
return repo.create(artifact)
|
||||
|
||||
|
||||
def _create_edge(repo, src, tgt, run_id="run-1"):
|
||||
"""Helper to create and persist a dependency edge."""
|
||||
edge = DependencyEdge.create(
|
||||
source_artifact_id=src,
|
||||
target_artifact_id=tgt,
|
||||
run_id=run_id,
|
||||
edge_type=EdgeType.REQUIRES,
|
||||
)
|
||||
return repo.create(edge)
|
||||
|
||||
|
||||
class TestBelowThresholdSuppression:
|
||||
"""Tests for impact debt from below-threshold suppression."""
|
||||
|
||||
def test_small_change_creates_debt(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test small change below threshold creates impact debt."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "hello world")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "uses lib")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib.id)
|
||||
|
||||
change = detector.detect_change(lib, "hello World") # tiny change
|
||||
assert change is not None
|
||||
detector.record_change(change)
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.5),
|
||||
old_content="hello world",
|
||||
new_content="hello World",
|
||||
)
|
||||
|
||||
assert result.suppressed_count == 1
|
||||
assert result.recomputed_count == 0
|
||||
assert result.suppressed[0].suppression_reason == "below_threshold"
|
||||
|
||||
def test_debt_records_magnitude(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test debt records include change magnitude."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "content A")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "uses lib")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib.id)
|
||||
|
||||
change = detector.detect_change(lib, "content B")
|
||||
detector.record_change(change)
|
||||
|
||||
engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.9),
|
||||
old_content="content A",
|
||||
new_content="content B",
|
||||
)
|
||||
|
||||
debt = engine.get_debt_for_artifact(lib.id)
|
||||
assert len(debt) == 1
|
||||
assert debt[0].change_magnitude > 0.0
|
||||
assert debt[0].change_magnitude < 1.0
|
||||
|
||||
def test_large_change_no_debt(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test large change above threshold creates no debt."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "old content here")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "uses lib")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib.id)
|
||||
|
||||
change = detector.detect_change(lib, "completely new different content xyz")
|
||||
detector.record_change(change)
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.1),
|
||||
old_content="old content here",
|
||||
new_content="completely new different content xyz",
|
||||
)
|
||||
|
||||
assert result.recomputed_count == 1
|
||||
assert result.suppressed_count == 0
|
||||
|
||||
debt = engine.get_debt_for_artifact(lib.id)
|
||||
assert len(debt) == 0
|
||||
|
||||
|
||||
class TestBudgetExhaustion:
|
||||
"""Tests for impact debt from budget exhaustion."""
|
||||
|
||||
def test_budget_creates_debt_for_excess(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test budget exhaustion creates debt for overflow dependents."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "lib v1")
|
||||
|
||||
# Create 5 apps depending on lib
|
||||
apps = []
|
||||
for i in range(5):
|
||||
app = _create_artifact(artifact_repo, "space-1", f"app-{i}", f"app-{i}")
|
||||
_create_edge(dep_repo, app.id, lib.id, run_id=f"run-{i}")
|
||||
apps.append(app)
|
||||
|
||||
change = detector.detect_change(lib, "lib v2")
|
||||
detector.record_change(change)
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, max_recomputes=2),
|
||||
old_content="lib v1",
|
||||
new_content="lib v2",
|
||||
)
|
||||
|
||||
assert result.total_dependents == 5
|
||||
assert result.recomputed_count == 2
|
||||
assert result.suppressed_count == 3
|
||||
|
||||
budget_debt = [d for d in result.suppressed if d.suppression_reason == "budget_exhausted"]
|
||||
assert len(budget_debt) == 3
|
||||
|
||||
def test_budget_debt_queryable(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test budget-exhaustion debt is queryable from DB."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "lib v1")
|
||||
|
||||
for i in range(3):
|
||||
app = _create_artifact(artifact_repo, "space-1", f"app-{i}", f"app-{i}")
|
||||
_create_edge(dep_repo, app.id, lib.id, run_id=f"run-{i}")
|
||||
|
||||
change = detector.detect_change(lib, "lib v2")
|
||||
detector.record_change(change)
|
||||
|
||||
engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, max_recomputes=1),
|
||||
old_content="lib v1",
|
||||
new_content="lib v2",
|
||||
)
|
||||
|
||||
all_debt = engine.get_all_debt()
|
||||
budget_debt = [d for d in all_debt if d.suppression_reason == "budget_exhausted"]
|
||||
assert len(budget_debt) == 2
|
||||
|
||||
|
||||
class TestDebtQuerying:
|
||||
"""Tests for querying impact debt records."""
|
||||
|
||||
def test_query_by_artifact(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test querying debt by artifact ID."""
|
||||
lib_a = _create_artifact(artifact_repo, "space-1", "lib-a", "a-v1")
|
||||
lib_b = _create_artifact(artifact_repo, "space-1", "lib-b", "b-v1")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "app")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib_a.id)
|
||||
_create_edge(dep_repo, app.id, lib_b.id)
|
||||
|
||||
# Suppress change to lib_a
|
||||
change_a = detector.detect_change(lib_a, "a-v2")
|
||||
detector.record_change(change_a)
|
||||
engine.recompute(
|
||||
change_a,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.99),
|
||||
old_content="a-v1",
|
||||
new_content="a-v2",
|
||||
)
|
||||
|
||||
# Suppress change to lib_b
|
||||
change_b = detector.detect_change(lib_b, "b-v2")
|
||||
detector.record_change(change_b)
|
||||
engine.recompute(
|
||||
change_b,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.99),
|
||||
old_content="b-v1",
|
||||
new_content="b-v2",
|
||||
)
|
||||
|
||||
# Query by artifact
|
||||
debt_a = engine.get_debt_for_artifact(lib_a.id)
|
||||
assert len(debt_a) == 1
|
||||
|
||||
debt_b = engine.get_debt_for_artifact(lib_b.id)
|
||||
assert len(debt_b) == 1
|
||||
|
||||
# Total debt
|
||||
all_debt = engine.get_all_debt()
|
||||
assert len(all_debt) == 2
|
||||
|
||||
def test_query_by_run(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test querying debt by dependent run ID."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "lib-v1")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "app")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib.id)
|
||||
|
||||
change = detector.detect_change(lib, "lib-v2")
|
||||
detector.record_change(change)
|
||||
engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.99),
|
||||
old_content="lib-v1",
|
||||
new_content="lib-v2",
|
||||
)
|
||||
|
||||
debt = engine.get_debt_for_run(app.id)
|
||||
assert len(debt) == 1
|
||||
assert debt[0].dependent_run_id == app.id
|
||||
|
||||
def test_no_debt_returns_empty(self, engine):
|
||||
"""Test querying debt when none exists returns empty list."""
|
||||
assert engine.get_debt_for_artifact("nonexistent") == []
|
||||
assert engine.get_debt_for_run("nonexistent") == []
|
||||
assert engine.get_all_debt() == []
|
||||
229
tests/integration/prompts/test_incremental_recompute.py
Normal file
229
tests/integration/prompts/test_incremental_recompute.py
Normal file
@@ -0,0 +1,229 @@
|
||||
"""
|
||||
Integration test for full incremental recompute workflow.
|
||||
|
||||
Tests: change artifact → detect → find dependents → recompute
|
||||
with a real SQLite database.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
|
||||
from markitect.prompts.models import Artifact, ArtifactType, calculate_content_digest
|
||||
from markitect.prompts.repositories.sqlite import SQLiteArtifactRepository
|
||||
from markitect.prompts.dependencies.models import DependencyEdge, EdgeType
|
||||
from markitect.prompts.dependencies.repository import SQLiteDependencyRepository
|
||||
from markitect.prompts.dependencies.queries import DependencyQueryService
|
||||
from markitect.prompts.incremental.detector import ChangeDetector
|
||||
from markitect.prompts.incremental.engine import IncrementalExecutionEngine
|
||||
from markitect.prompts.incremental.models import RecomputeConfig
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def temp_db():
|
||||
"""Create temporary database for testing."""
|
||||
with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as f:
|
||||
db_path = f.name
|
||||
yield db_path
|
||||
Path(db_path).unlink(missing_ok=True)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def artifact_repo(temp_db):
|
||||
"""Create artifact repository."""
|
||||
return SQLiteArtifactRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def dep_repo(temp_db):
|
||||
"""Create dependency repository (shares same DB)."""
|
||||
return SQLiteDependencyRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def query_service(dep_repo):
|
||||
"""Create DependencyQueryService."""
|
||||
return DependencyQueryService(dep_repo)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def detector(temp_db):
|
||||
"""Create ChangeDetector."""
|
||||
return ChangeDetector(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def engine(temp_db, query_service):
|
||||
"""Create IncrementalExecutionEngine."""
|
||||
return IncrementalExecutionEngine(temp_db, query_service)
|
||||
|
||||
|
||||
def _create_artifact(repo, space_id, name, content):
|
||||
"""Helper to create and persist an artifact."""
|
||||
artifact = Artifact.create(
|
||||
space_id=space_id,
|
||||
name=name,
|
||||
content=content,
|
||||
artifact_type=ArtifactType.CONTENT,
|
||||
)
|
||||
return repo.create(artifact)
|
||||
|
||||
|
||||
def _create_edge(repo, src, tgt, run_id="run-1"):
|
||||
"""Helper to create and persist a dependency edge."""
|
||||
edge = DependencyEdge.create(
|
||||
source_artifact_id=src,
|
||||
target_artifact_id=tgt,
|
||||
run_id=run_id,
|
||||
edge_type=EdgeType.REQUIRES,
|
||||
)
|
||||
return repo.create(edge)
|
||||
|
||||
|
||||
class TestFullRecomputeWorkflow:
|
||||
"""Full end-to-end incremental recompute workflow."""
|
||||
|
||||
def test_change_detect_and_recompute(
|
||||
self, artifact_repo, dep_repo, query_service, detector, engine
|
||||
):
|
||||
"""Test complete flow: create artifacts, detect change, recompute dependents."""
|
||||
# Step 1: Create artifacts
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "library v1")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "app using lib")
|
||||
|
||||
# Step 2: Establish dependency (app depends on lib)
|
||||
_create_edge(dep_repo, app.id, lib.id)
|
||||
|
||||
# Step 3: Detect a change in lib
|
||||
change = detector.detect_change(lib, "library v2")
|
||||
assert change is not None
|
||||
detector.record_change(change)
|
||||
|
||||
# Step 4: Recompute dependents
|
||||
executed_ids = []
|
||||
|
||||
def callback(dep_id):
|
||||
from markitect.prompts.execution.models import PromptRun
|
||||
run = PromptRun.create(
|
||||
template_id=dep_id,
|
||||
input_bundle_hash="recompute-hash",
|
||||
)
|
||||
run.mark_complete()
|
||||
executed_ids.append(dep_id)
|
||||
return run
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1),
|
||||
execution_callback=callback,
|
||||
old_content="library v1",
|
||||
new_content="library v2",
|
||||
)
|
||||
|
||||
# Verify
|
||||
assert result.total_dependents == 1
|
||||
assert result.recomputed_count == 1
|
||||
assert result.suppressed_count == 0
|
||||
assert app.id in executed_ids
|
||||
|
||||
def test_multi_level_recompute(
|
||||
self, artifact_repo, dep_repo, query_service, detector, engine
|
||||
):
|
||||
"""Test recompute propagates through multiple dependency levels."""
|
||||
# core -> utils -> app
|
||||
core = _create_artifact(artifact_repo, "space-1", "core", "core v1")
|
||||
utils = _create_artifact(artifact_repo, "space-1", "utils", "utils v1")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "app v1")
|
||||
|
||||
_create_edge(dep_repo, utils.id, core.id)
|
||||
_create_edge(dep_repo, app.id, utils.id)
|
||||
|
||||
# Change core
|
||||
change = detector.detect_change(core, "core v2")
|
||||
assert change is not None
|
||||
detector.record_change(change)
|
||||
|
||||
# Recompute with depth 2
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=2),
|
||||
old_content="core v1",
|
||||
new_content="core v2",
|
||||
)
|
||||
|
||||
assert result.total_dependents == 2
|
||||
assert result.recomputed_count == 2
|
||||
assert set(result.executed_run_ids) == {utils.id, app.id}
|
||||
|
||||
def test_no_change_no_recompute(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test that no change means no recompute."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "unchanged")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "app")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib.id)
|
||||
|
||||
# Same content → no change
|
||||
change = detector.detect_change(lib, "unchanged")
|
||||
assert change is None
|
||||
|
||||
def test_change_record_persisted(
|
||||
self, artifact_repo, detector
|
||||
):
|
||||
"""Test change records are persisted across detector instances."""
|
||||
lib = _create_artifact(artifact_repo, "space-1", "lib", "v1")
|
||||
|
||||
change = detector.detect_change(lib, "v2")
|
||||
assert change is not None
|
||||
detector.record_change(change)
|
||||
|
||||
# Verify persisted
|
||||
changes = detector.get_changes_for_artifact(lib.id)
|
||||
assert len(changes) == 1
|
||||
assert changes[0].id == change.id
|
||||
|
||||
|
||||
class TestMultipleArtifactChanges:
|
||||
"""Tests for handling changes to multiple artifacts."""
|
||||
|
||||
def test_independent_changes(
|
||||
self, artifact_repo, dep_repo, detector, engine
|
||||
):
|
||||
"""Test independent artifact changes trigger separate recomputes."""
|
||||
lib_a = _create_artifact(artifact_repo, "space-1", "lib-a", "lib-a v1")
|
||||
lib_b = _create_artifact(artifact_repo, "space-1", "lib-b", "lib-b v1")
|
||||
app = _create_artifact(artifact_repo, "space-1", "app", "app v1")
|
||||
|
||||
_create_edge(dep_repo, app.id, lib_a.id)
|
||||
_create_edge(dep_repo, app.id, lib_b.id)
|
||||
|
||||
# Change lib_a
|
||||
change_a = detector.detect_change(lib_a, "lib-a v2")
|
||||
assert change_a is not None
|
||||
detector.record_change(change_a)
|
||||
|
||||
result_a = engine.recompute(
|
||||
change_a,
|
||||
config=RecomputeConfig(max_depth=1),
|
||||
old_content="lib-a v1",
|
||||
new_content="lib-a v2",
|
||||
)
|
||||
|
||||
assert result_a.total_dependents == 1
|
||||
assert result_a.recomputed_count == 1
|
||||
|
||||
# Change lib_b
|
||||
change_b = detector.detect_change(lib_b, "lib-b v2")
|
||||
assert change_b is not None
|
||||
detector.record_change(change_b)
|
||||
|
||||
result_b = engine.recompute(
|
||||
change_b,
|
||||
config=RecomputeConfig(max_depth=1),
|
||||
old_content="lib-b v1",
|
||||
new_content="lib-b v2",
|
||||
)
|
||||
|
||||
assert result_b.total_dependents == 1
|
||||
assert result_b.recomputed_count == 1
|
||||
166
tests/unit/prompts/test_change_detector.py
Normal file
166
tests/unit/prompts/test_change_detector.py
Normal file
@@ -0,0 +1,166 @@
|
||||
"""
|
||||
Unit tests for ChangeDetector.
|
||||
|
||||
Tests change detection, recording, change types, and no-change cases.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
|
||||
from markitect.prompts.models import Artifact, ArtifactType, calculate_content_digest
|
||||
from markitect.prompts.incremental.detector import ChangeDetector
|
||||
from markitect.prompts.incremental.models import ChangeType
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def temp_db():
|
||||
"""Create temporary database for testing."""
|
||||
with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as f:
|
||||
db_path = f.name
|
||||
yield db_path
|
||||
Path(db_path).unlink(missing_ok=True)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def detector(temp_db):
|
||||
"""Create ChangeDetector instance."""
|
||||
return ChangeDetector(temp_db)
|
||||
|
||||
|
||||
def _make_artifact(content="original content"):
|
||||
"""Helper to create an in-memory artifact."""
|
||||
return Artifact.create(
|
||||
space_id="space-1",
|
||||
name="test-artifact",
|
||||
content=content,
|
||||
artifact_type=ArtifactType.CONTENT,
|
||||
)
|
||||
|
||||
|
||||
class TestDetectChange:
|
||||
"""Tests for detecting content changes."""
|
||||
|
||||
def test_detect_modification(self, detector):
|
||||
"""Test detecting a content modification."""
|
||||
artifact = _make_artifact("original content")
|
||||
change = detector.detect_change(artifact, "modified content")
|
||||
|
||||
assert change is not None
|
||||
assert change.artifact_id == artifact.id
|
||||
assert change.old_digest == artifact.content_digest
|
||||
assert change.new_digest == calculate_content_digest("modified content")
|
||||
assert change.change_type == ChangeType.MODIFIED
|
||||
|
||||
def test_no_change_returns_none(self, detector):
|
||||
"""Test that identical content returns None."""
|
||||
artifact = _make_artifact("same content")
|
||||
change = detector.detect_change(artifact, "same content")
|
||||
|
||||
assert change is None
|
||||
|
||||
def test_detect_whitespace_change(self, detector):
|
||||
"""Test detecting whitespace-only changes."""
|
||||
artifact = _make_artifact("content")
|
||||
change = detector.detect_change(artifact, "content ")
|
||||
|
||||
assert change is not None
|
||||
assert change.change_type == ChangeType.MODIFIED
|
||||
|
||||
def test_detect_empty_to_content(self, detector):
|
||||
"""Test detecting change from empty to content."""
|
||||
artifact = _make_artifact("")
|
||||
change = detector.detect_change(artifact, "new content")
|
||||
|
||||
assert change is not None
|
||||
assert change.change_type == ChangeType.MODIFIED
|
||||
|
||||
|
||||
class TestDetectCreation:
|
||||
"""Tests for recording artifact creation."""
|
||||
|
||||
def test_detect_creation(self, detector):
|
||||
"""Test creation change record."""
|
||||
change = detector.detect_creation("artifact-123", "new content")
|
||||
|
||||
assert change.artifact_id == "artifact-123"
|
||||
assert change.old_digest is None
|
||||
assert change.new_digest == calculate_content_digest("new content")
|
||||
assert change.change_type == ChangeType.CREATED
|
||||
|
||||
def test_creation_has_unique_id(self, detector):
|
||||
"""Test that each creation gets a unique ID."""
|
||||
change1 = detector.detect_creation("art-1", "content")
|
||||
change2 = detector.detect_creation("art-2", "content")
|
||||
|
||||
assert change1.id != change2.id
|
||||
|
||||
|
||||
class TestDetectDeletion:
|
||||
"""Tests for recording artifact deletion."""
|
||||
|
||||
def test_detect_deletion(self, detector):
|
||||
"""Test deletion change record."""
|
||||
artifact = _make_artifact("content to delete")
|
||||
change = detector.detect_deletion(artifact)
|
||||
|
||||
assert change.artifact_id == artifact.id
|
||||
assert change.old_digest == artifact.content_digest
|
||||
assert change.change_type == ChangeType.DELETED
|
||||
|
||||
|
||||
class TestRecordChange:
|
||||
"""Tests for persisting change records."""
|
||||
|
||||
def test_record_and_retrieve(self, detector):
|
||||
"""Test recording a change and retrieving it."""
|
||||
artifact = _make_artifact("original")
|
||||
change = detector.detect_change(artifact, "modified")
|
||||
assert change is not None
|
||||
|
||||
detector.record_change(change)
|
||||
changes = detector.get_changes_for_artifact(artifact.id)
|
||||
|
||||
assert len(changes) == 1
|
||||
assert changes[0].id == change.id
|
||||
assert changes[0].artifact_id == artifact.id
|
||||
assert changes[0].change_type == ChangeType.MODIFIED
|
||||
|
||||
def test_record_multiple_changes(self, detector):
|
||||
"""Test recording multiple changes for same artifact."""
|
||||
artifact = _make_artifact("v1")
|
||||
|
||||
change1 = detector.detect_change(artifact, "v2")
|
||||
detector.record_change(change1)
|
||||
|
||||
# Simulate artifact update
|
||||
artifact.update_content("v2")
|
||||
change2 = detector.detect_change(artifact, "v3")
|
||||
detector.record_change(change2)
|
||||
|
||||
changes = detector.get_changes_for_artifact(artifact.id)
|
||||
assert len(changes) == 2
|
||||
|
||||
def test_get_changes_by_type(self, detector):
|
||||
"""Test filtering changes by type."""
|
||||
# Record a creation
|
||||
creation = detector.detect_creation("art-new", "content")
|
||||
detector.record_change(creation)
|
||||
|
||||
# Record a modification
|
||||
artifact = _make_artifact("old")
|
||||
modification = detector.detect_change(artifact, "new")
|
||||
detector.record_change(modification)
|
||||
|
||||
created_changes = detector.get_changes_by_type(ChangeType.CREATED)
|
||||
assert len(created_changes) == 1
|
||||
assert created_changes[0].change_type == ChangeType.CREATED
|
||||
|
||||
modified_changes = detector.get_changes_by_type(ChangeType.MODIFIED)
|
||||
assert len(modified_changes) == 1
|
||||
assert modified_changes[0].change_type == ChangeType.MODIFIED
|
||||
|
||||
def test_no_changes_returns_empty(self, detector):
|
||||
"""Test querying changes for artifact with none recorded."""
|
||||
changes = detector.get_changes_for_artifact("nonexistent")
|
||||
assert changes == []
|
||||
162
tests/unit/prompts/test_impact_analyzer.py
Normal file
162
tests/unit/prompts/test_impact_analyzer.py
Normal file
@@ -0,0 +1,162 @@
|
||||
"""
|
||||
Unit tests for ImpactAnalyzer and metrics functions.
|
||||
|
||||
Tests diff ratios, magnitude scoring, and threshold decisions.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
|
||||
from markitect.prompts.incremental.metrics import (
|
||||
structural_diff_ratio,
|
||||
line_diff_ratio,
|
||||
calculate_change_magnitude,
|
||||
)
|
||||
from markitect.prompts.incremental.impact import ImpactAnalyzer
|
||||
from markitect.prompts.incremental.models import RecomputeConfig
|
||||
|
||||
|
||||
class TestStructuralDiffRatio:
|
||||
"""Tests for structural_diff_ratio."""
|
||||
|
||||
def test_identical_content(self):
|
||||
"""Test identical content returns 0.0."""
|
||||
assert structural_diff_ratio("hello", "hello") == 0.0
|
||||
|
||||
def test_completely_different(self):
|
||||
"""Test completely different content returns high ratio."""
|
||||
ratio = structural_diff_ratio("aaa", "zzz")
|
||||
assert ratio > 0.5
|
||||
|
||||
def test_empty_strings(self):
|
||||
"""Test both empty returns 0.0."""
|
||||
assert structural_diff_ratio("", "") == 0.0
|
||||
|
||||
def test_one_empty(self):
|
||||
"""Test one empty returns 1.0."""
|
||||
assert structural_diff_ratio("", "content") == 1.0
|
||||
assert structural_diff_ratio("content", "") == 1.0
|
||||
|
||||
def test_small_change(self):
|
||||
"""Test small change returns low ratio."""
|
||||
old = "The quick brown fox jumps over the lazy dog"
|
||||
new = "The quick brown fox leaps over the lazy dog"
|
||||
ratio = structural_diff_ratio(old, new)
|
||||
assert 0.0 < ratio < 0.5
|
||||
|
||||
def test_returns_float(self):
|
||||
"""Test return value is float between 0 and 1."""
|
||||
ratio = structural_diff_ratio("abc", "abd")
|
||||
assert isinstance(ratio, float)
|
||||
assert 0.0 <= ratio <= 1.0
|
||||
|
||||
|
||||
class TestLineDiffRatio:
|
||||
"""Tests for line_diff_ratio."""
|
||||
|
||||
def test_identical_lines(self):
|
||||
"""Test identical multi-line content returns 0.0."""
|
||||
content = "line1\nline2\nline3"
|
||||
assert line_diff_ratio(content, content) == 0.0
|
||||
|
||||
def test_one_line_changed(self):
|
||||
"""Test changing one line of several."""
|
||||
old = "line1\nline2\nline3"
|
||||
new = "line1\nmodified\nline3"
|
||||
ratio = line_diff_ratio(old, new)
|
||||
assert 0.0 < ratio < 1.0
|
||||
|
||||
def test_all_lines_changed(self):
|
||||
"""Test all lines changed returns high ratio."""
|
||||
old = "aaa\nbbb\nccc"
|
||||
new = "xxx\nyyy\nzzz"
|
||||
ratio = line_diff_ratio(old, new)
|
||||
assert ratio > 0.5
|
||||
|
||||
def test_empty_strings(self):
|
||||
"""Test both empty returns 0.0."""
|
||||
assert line_diff_ratio("", "") == 0.0
|
||||
|
||||
def test_one_empty(self):
|
||||
"""Test one empty returns 1.0."""
|
||||
assert line_diff_ratio("", "content") == 1.0
|
||||
assert line_diff_ratio("content", "") == 1.0
|
||||
|
||||
|
||||
class TestCalculateChangeMagnitude:
|
||||
"""Tests for calculate_change_magnitude."""
|
||||
|
||||
def test_none_old_content(self):
|
||||
"""Test None old_content (creation) returns 1.0."""
|
||||
assert calculate_change_magnitude(None, "new content") == 1.0
|
||||
|
||||
def test_none_new_content(self):
|
||||
"""Test None new_content (deletion) returns 1.0."""
|
||||
assert calculate_change_magnitude("old content", None) == 1.0
|
||||
|
||||
def test_both_none(self):
|
||||
"""Test both None returns 0.0."""
|
||||
assert calculate_change_magnitude(None, None) == 0.0
|
||||
|
||||
def test_structural_method(self):
|
||||
"""Test structural method (default)."""
|
||||
result = calculate_change_magnitude("abc", "abd", method="structural")
|
||||
assert 0.0 < result < 1.0
|
||||
|
||||
def test_line_method(self):
|
||||
"""Test line method."""
|
||||
result = calculate_change_magnitude("abc\ndef", "abc\nxyz", method="line")
|
||||
assert 0.0 < result < 1.0
|
||||
|
||||
def test_identical_content(self):
|
||||
"""Test identical content returns 0.0."""
|
||||
assert calculate_change_magnitude("same", "same") == 0.0
|
||||
|
||||
|
||||
class TestImpactAnalyzer:
|
||||
"""Tests for ImpactAnalyzer class."""
|
||||
|
||||
@pytest.fixture
|
||||
def analyzer(self):
|
||||
"""Create ImpactAnalyzer instance."""
|
||||
return ImpactAnalyzer()
|
||||
|
||||
def test_calculate_magnitude(self, analyzer):
|
||||
"""Test magnitude calculation delegates to metrics."""
|
||||
result = analyzer.calculate_magnitude("old", "new")
|
||||
assert isinstance(result, float)
|
||||
assert 0.0 <= result <= 1.0
|
||||
|
||||
def test_calculate_magnitude_creation(self, analyzer):
|
||||
"""Test magnitude for creation."""
|
||||
assert analyzer.calculate_magnitude(None, "new") == 1.0
|
||||
|
||||
def test_calculate_magnitude_identical(self, analyzer):
|
||||
"""Test magnitude for identical content."""
|
||||
assert analyzer.calculate_magnitude("same", "same") == 0.0
|
||||
|
||||
def test_should_recompute_above_threshold(self, analyzer):
|
||||
"""Test recompute when magnitude exceeds threshold."""
|
||||
config = RecomputeConfig(impact_threshold=0.3)
|
||||
assert analyzer.should_recompute(0.5, config) is True
|
||||
|
||||
def test_should_recompute_at_threshold(self, analyzer):
|
||||
"""Test recompute when magnitude equals threshold."""
|
||||
config = RecomputeConfig(impact_threshold=0.5)
|
||||
assert analyzer.should_recompute(0.5, config) is True
|
||||
|
||||
def test_should_not_recompute_below_threshold(self, analyzer):
|
||||
"""Test no recompute when magnitude below threshold."""
|
||||
config = RecomputeConfig(impact_threshold=0.5)
|
||||
assert analyzer.should_recompute(0.3, config) is False
|
||||
|
||||
def test_zero_threshold_always_recomputes(self, analyzer):
|
||||
"""Test zero threshold means any change triggers recompute."""
|
||||
config = RecomputeConfig(impact_threshold=0.0)
|
||||
assert analyzer.should_recompute(0.0, config) is True
|
||||
assert analyzer.should_recompute(0.01, config) is True
|
||||
|
||||
def test_high_threshold_only_major_changes(self, analyzer):
|
||||
"""Test high threshold only triggers on major changes."""
|
||||
config = RecomputeConfig(impact_threshold=0.9)
|
||||
assert analyzer.should_recompute(0.5, config) is False
|
||||
assert analyzer.should_recompute(0.95, config) is True
|
||||
364
tests/unit/prompts/test_incremental_engine.py
Normal file
364
tests/unit/prompts/test_incremental_engine.py
Normal file
@@ -0,0 +1,364 @@
|
||||
"""
|
||||
Unit tests for IncrementalExecutionEngine.
|
||||
|
||||
Tests recompute flow, depth control, circular suppression, and budget limits.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
from markitect.prompts.dependencies.models import DependencyEdge, EdgeType
|
||||
from markitect.prompts.dependencies.repository import SQLiteDependencyRepository
|
||||
from markitect.prompts.dependencies.queries import DependencyQueryService
|
||||
from markitect.prompts.execution.models import PromptRun, RunConfig, RunStatus
|
||||
from markitect.prompts.incremental.engine import IncrementalExecutionEngine
|
||||
from markitect.prompts.incremental.models import (
|
||||
ArtifactChange,
|
||||
ChangeType,
|
||||
ImpactDebt,
|
||||
RecomputeConfig,
|
||||
)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def temp_db():
|
||||
"""Create temporary database for testing."""
|
||||
with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as f:
|
||||
db_path = f.name
|
||||
yield db_path
|
||||
Path(db_path).unlink(missing_ok=True)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def dep_repo(temp_db):
|
||||
"""Create dependency repository."""
|
||||
return SQLiteDependencyRepository(temp_db)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def query_service(dep_repo):
|
||||
"""Create DependencyQueryService."""
|
||||
return DependencyQueryService(dep_repo)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def engine(temp_db, query_service):
|
||||
"""Create IncrementalExecutionEngine."""
|
||||
return IncrementalExecutionEngine(temp_db, query_service)
|
||||
|
||||
|
||||
def _create_edge(repo, src, tgt, run_id="run-1", edge_type=EdgeType.REQUIRES):
|
||||
"""Helper to create and persist a dependency edge."""
|
||||
edge = DependencyEdge.create(
|
||||
source_artifact_id=src,
|
||||
target_artifact_id=tgt,
|
||||
run_id=run_id,
|
||||
edge_type=edge_type,
|
||||
)
|
||||
return repo.create(edge)
|
||||
|
||||
|
||||
def _make_change(artifact_id="art-1"):
|
||||
"""Helper to create a test ArtifactChange."""
|
||||
return ArtifactChange.create(
|
||||
artifact_id=artifact_id,
|
||||
old_digest="old-digest",
|
||||
new_digest="new-digest",
|
||||
change_type=ChangeType.MODIFIED,
|
||||
)
|
||||
|
||||
|
||||
class TestFindDependentsAtDepth:
|
||||
"""Tests for BFS depth-controlled dependent finding."""
|
||||
|
||||
def test_depth_1_direct_only(self, dep_repo, engine):
|
||||
"""Test depth=1 finds only direct dependents."""
|
||||
# A -> B -> C (A depends on B, B depends on C)
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "C")
|
||||
|
||||
# Dependents of C at depth 1: only B
|
||||
dependents = engine.find_dependents_at_depth("C", max_depth=1)
|
||||
assert dependents == {"B"}
|
||||
|
||||
def test_depth_2_transitive(self, dep_repo, engine):
|
||||
"""Test depth=2 finds two levels of dependents."""
|
||||
# A -> B -> C
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "C")
|
||||
|
||||
# Dependents of C at depth 2: B and A
|
||||
dependents = engine.find_dependents_at_depth("C", max_depth=2)
|
||||
assert dependents == {"A", "B"}
|
||||
|
||||
def test_depth_0_returns_empty(self, dep_repo, engine):
|
||||
"""Test depth=0 returns no dependents."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
|
||||
dependents = engine.find_dependents_at_depth("B", max_depth=0)
|
||||
assert dependents == set()
|
||||
|
||||
def test_no_dependents(self, engine):
|
||||
"""Test artifact with no dependents."""
|
||||
dependents = engine.find_dependents_at_depth("isolated", max_depth=5)
|
||||
assert dependents == set()
|
||||
|
||||
def test_diamond_dependents(self, dep_repo, engine):
|
||||
"""Test diamond-shaped dependency graph."""
|
||||
# A -> C, B -> C, D -> A, D -> B
|
||||
_create_edge(dep_repo, "A", "C")
|
||||
_create_edge(dep_repo, "B", "C")
|
||||
_create_edge(dep_repo, "D", "A")
|
||||
_create_edge(dep_repo, "D", "B")
|
||||
|
||||
dependents = engine.find_dependents_at_depth("C", max_depth=2)
|
||||
assert dependents == {"A", "B", "D"}
|
||||
|
||||
|
||||
class TestRecompute:
|
||||
"""Tests for the recompute orchestration flow."""
|
||||
|
||||
def test_basic_recompute(self, dep_repo, engine):
|
||||
"""Test basic recompute with execution callback."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
|
||||
change = _make_change("B")
|
||||
mock_run = PromptRun.create(
|
||||
template_id="template-1",
|
||||
input_bundle_hash="hash-1",
|
||||
)
|
||||
|
||||
def callback(run_id):
|
||||
return mock_run
|
||||
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1),
|
||||
execution_callback=callback,
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
assert result.changed_artifact_id == "B"
|
||||
assert result.total_dependents == 1
|
||||
assert result.recomputed_count == 1
|
||||
assert result.suppressed_count == 0
|
||||
assert len(result.executed_run_ids) == 1
|
||||
|
||||
def test_dry_run_no_callback(self, dep_repo, engine):
|
||||
"""Test recompute without callback records what would be recomputed."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
|
||||
change = _make_change("B")
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
assert result.recomputed_count == 1
|
||||
assert result.executed_run_ids == ["A"]
|
||||
|
||||
def test_no_dependents(self, engine):
|
||||
"""Test recompute with no dependents."""
|
||||
change = _make_change("isolated")
|
||||
result = engine.recompute(change)
|
||||
|
||||
assert result.total_dependents == 0
|
||||
assert result.recomputed_count == 0
|
||||
assert result.suppressed_count == 0
|
||||
|
||||
def test_depth_control(self, dep_repo, engine):
|
||||
"""Test depth limiting controls recompute scope."""
|
||||
# A -> B -> C
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "C")
|
||||
|
||||
change = _make_change("C")
|
||||
|
||||
# Depth 1: only B
|
||||
result1 = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
assert result1.total_dependents == 1
|
||||
assert result1.recomputed_count == 1
|
||||
|
||||
# Depth 2: B and A
|
||||
result2 = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=2),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
assert result2.total_dependents == 2
|
||||
assert result2.recomputed_count == 2
|
||||
|
||||
|
||||
class TestBudgetLimits:
|
||||
"""Tests for recompute budget exhaustion."""
|
||||
|
||||
def test_budget_exhaustion(self, dep_repo, engine):
|
||||
"""Test budget limit suppresses excess recomputes."""
|
||||
# Create 5 dependents of C
|
||||
for i in range(5):
|
||||
_create_edge(dep_repo, f"dep-{i}", "C")
|
||||
|
||||
change = _make_change("C")
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, max_recomputes=3),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
assert result.total_dependents == 5
|
||||
assert result.recomputed_count == 3
|
||||
assert result.suppressed_count == 2
|
||||
assert all(
|
||||
d.suppression_reason == "budget_exhausted"
|
||||
for d in result.suppressed
|
||||
)
|
||||
|
||||
def test_budget_zero_suppresses_all(self, dep_repo, engine):
|
||||
"""Test zero budget suppresses all recomputes."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
|
||||
change = _make_change("B")
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, max_recomputes=0),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
assert result.recomputed_count == 0
|
||||
assert result.suppressed_count == 1
|
||||
|
||||
|
||||
class TestCircularSuppression:
|
||||
"""Tests for circular dependency suppression."""
|
||||
|
||||
def test_circular_dependency_suppressed(self, dep_repo, engine):
|
||||
"""Test circular dependency is suppressed."""
|
||||
# A -> B and B -> A (circular)
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "A")
|
||||
|
||||
change = _make_change("B")
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
assert result.total_dependents == 1 # A is a dependent of B
|
||||
# A depends on B, and B depends on A — would_create_cycle(A, B) is True
|
||||
assert result.suppressed_count == 1
|
||||
assert result.suppressed[0].suppression_reason == "circular_dependency"
|
||||
|
||||
def test_circular_suppression_disabled(self, dep_repo, engine):
|
||||
"""Test circular suppression can be disabled."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "A")
|
||||
|
||||
change = _make_change("B")
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=False),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
# With suppression disabled, circular deps are still recomputed
|
||||
assert result.recomputed_count == 1
|
||||
assert result.suppressed_count == 0
|
||||
|
||||
|
||||
class TestThresholdSuppression:
|
||||
"""Tests for impact threshold suppression."""
|
||||
|
||||
def test_below_threshold_suppressed(self, dep_repo, engine):
|
||||
"""Test below-threshold changes are suppressed."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
|
||||
change = _make_change("B")
|
||||
# High threshold, small change
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.9),
|
||||
old_content="hello world",
|
||||
new_content="hello World", # small change
|
||||
)
|
||||
|
||||
assert result.suppressed_count == 1
|
||||
assert result.suppressed[0].suppression_reason == "below_threshold"
|
||||
|
||||
def test_above_threshold_recomputed(self, dep_repo, engine):
|
||||
"""Test above-threshold changes trigger recompute."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
|
||||
change = _make_change("B")
|
||||
result = engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, impact_threshold=0.1),
|
||||
old_content="completely old content here",
|
||||
new_content="entirely new different stuff",
|
||||
)
|
||||
|
||||
assert result.recomputed_count == 1
|
||||
assert result.suppressed_count == 0
|
||||
|
||||
|
||||
class TestDebtPersistence:
|
||||
"""Tests for impact debt persistence."""
|
||||
|
||||
def test_debt_recorded_in_db(self, dep_repo, engine):
|
||||
"""Test suppressed recomputes are persisted as debt."""
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "A")
|
||||
|
||||
change = _make_change("B")
|
||||
engine.recompute(
|
||||
change,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
debt = engine.get_debt_for_artifact("B")
|
||||
assert len(debt) == 1
|
||||
assert debt[0].suppression_reason == "circular_dependency"
|
||||
|
||||
def test_get_all_debt(self, dep_repo, engine):
|
||||
"""Test retrieving all debt records."""
|
||||
# Create two separate suppressed recomputes
|
||||
_create_edge(dep_repo, "A", "B")
|
||||
_create_edge(dep_repo, "B", "A")
|
||||
_create_edge(dep_repo, "C", "D")
|
||||
_create_edge(dep_repo, "D", "C")
|
||||
|
||||
change1 = _make_change("B")
|
||||
engine.recompute(
|
||||
change1,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
change2 = _make_change("D")
|
||||
engine.recompute(
|
||||
change2,
|
||||
config=RecomputeConfig(max_depth=1, suppress_circular=True),
|
||||
old_content="old",
|
||||
new_content="new",
|
||||
)
|
||||
|
||||
all_debt = engine.get_all_debt()
|
||||
assert len(all_debt) == 2
|
||||
Reference in New Issue
Block a user