coulomb/markitect-main
2
0
Fork 0
Code Issues 60 Pull Requests Actions Projects 12 Releases 1 Wiki Activity

fix: resolve MarkiTect issue handling system integration problems (issue #120)

Browse Source 
- Fix issue manager to properly read API token and repo info from main MarkiTect config
- Update Gitea plugin to use correct repository-specific API endpoints
- Correct domain model mapping to only include valid Issue model fields
- Fix presentation layer to safely access optional body attribute
- Enable full functionality for 'markitect issues show' and 'markitect issues list' commands

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Bernd Worsch
2025-10-04 02:14:59 +02:00
parent b83dc14f7b
commit fb968dff34
4 changed files with 84 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
infrastructure/repositories/gitea_repository.py
View File

@@ -36,6 +36,13 @@ class GiteaIssueRepository(IssueRepository):
def __init__(self, connection_manager: ConnectionManager, retry_config: Optional[RetryConfig] = None):
self.connection_manager = connection_manager
self.retry_config = retry_config or RetryConfig()
self.repo_owner = None
self.repo_name = None
def set_repo_info(self, repo_owner: str, repo_name: str):
"""Set repository owner and name for API endpoints."""
self.repo_owner = repo_owner
self.repo_name = repo_name
@retry_with_backoff(RetryConfig())
async def get_issue(self, issue_number: int, context: Optional[ErrorContext] = None) -> Issue:
@@ -51,7 +58,11 @@ class GiteaIssueRepository(IssueRepository):
try:
session = await self.connection_manager.get_http_session()
async with session.get(f"/api/v1/repos/issues/{issue_number}") as response:
if not self.repo_owner or not self.repo_name:
raise ValidationError("repo_info", None, "Repository owner and name must be set", context)
endpoint = f"/api/v1/repos/{self.repo_owner}/{self.repo_name}/issues/{issue_number}"
async with session.get(endpoint) as response:
await self._handle_response_errors(response, context)
data = await response.json()
@@ -101,7 +112,11 @@ class GiteaIssueRepository(IssueRepository):
if labels:
params["labels"] = ",".join(labels)
async with session.get("/api/v1/repos/issues", params=params) as response:
if not self.repo_owner or not self.repo_name:
raise ValidationError("repo_info", None, "Repository owner and name must be set", context)
endpoint = f"/api/v1/repos/{self.repo_owner}/{self.repo_name}/issues"
async with session.get(endpoint, params=params) as response:
await self._handle_response_errors(response, context)
data = await response.json()
@@ -156,7 +171,11 @@ class GiteaIssueRepository(IssueRepository):
if assignees:
payload["assignees"] = assignees
async with session.post("/api/v1/repos/issues", json=payload) as response:
if not self.repo_owner or not self.repo_name:
raise ValidationError("repo_info", None, "Repository owner and name must be set", context)
endpoint = f"/api/v1/repos/{self.repo_owner}/{self.repo_name}/issues"
async with session.post(endpoint, json=payload) as response:
await self._handle_response_errors(response, context)
data = await response.json()
@@ -229,7 +248,11 @@ class GiteaIssueRepository(IssueRepository):
if not payload:
return current_issue
async with session.patch(f"/api/v1/repos/issues/{issue_number}", json=payload) as response:
if not self.repo_owner or not self.repo_name:
raise ValidationError("repo_info", None, "Repository owner and name must be set", context)
endpoint = f"/api/v1/repos/{self.repo_owner}/{self.repo_name}/issues/{issue_number}"
async with session.patch(endpoint, json=payload) as response:
# Handle potential concurrent modification
if response.status == 409:
raise ConcurrencyError("Issue", str(issue_number), context)
@@ -267,7 +290,11 @@ class GiteaIssueRepository(IssueRepository):
issue = await self.get_issue(issue_number, context)
# Get repository information
async with session.get("/api/v1/repos") as response:
if not self.repo_owner or not self.repo_name:
raise ValidationError("repo_info", None, "Repository owner and name must be set", context)
repo_endpoint = f"/api/v1/repos/{self.repo_owner}/{self.repo_name}"
async with session.get(repo_endpoint) as response:
await self._handle_response_errors(response, context)
repo_data = await response.json()
@@ -285,7 +312,8 @@ class GiteaIssueRepository(IssueRepository):
# Try to get actual project boards
try:
async with session.get("/api/v1/repos/projects") as projects_response:
projects_endpoint = f"/api/v1/repos/{self.repo_owner}/{self.repo_name}/projects"
async with session.get(projects_endpoint) as projects_response:
if projects_response.status == 200:
projects_data = await projects_response.json()
if projects_data:
@@ -329,15 +357,13 @@ class GiteaIssueRepository(IssueRepository):
return Issue(
number=api_data["number"],
title=api_data["title"],
body=api_data.get("body", ""),
state=issue_state,
labels=labels,
assignees=api_data.get("assignees", []),
author=api_data.get("user", {}).get("login", "unknown"),
created_at=created_at,
updated_at=updated_at,
closed_at=closed_at,
url=api_data.get("html_url", "")
milestone=api_data.get("milestone", {}).get("title") if api_data.get("milestone") else None,
assignee=api_data.get("assignees", [{}])[0].get("login") if api_data.get("assignees") else None,
closed_at=closed_at
)
async def _handle_response_errors(self, response: aiohttp.ClientResponse, context: ErrorContext):
@@ -499,7 +525,8 @@ class GiteaProjectRepository(ProjectRepository):
if state:
params["state"] = state
async with session.get(f"/api/v1/repos/milestones", params=params) as response:
# Note: This would need repo info from GiteaIssueRepository, but for now use general endpoint
async with session.get("/api/v1/repos/milestones", params=params) as response:
await self._handle_response_errors(response, context)
data = await response.json()
@@ -547,6 +574,7 @@ class GiteaProjectRepository(ProjectRepository):
if due_date:
payload["due_on"] = due_date
# Note: This would need repo info from GiteaIssueRepository, but for now use general endpoint
async with session.post("/api/v1/repos/milestones", json=payload) as response:
await self._handle_response_errors(response, context)