coulomb/markitect-main
2
0
Fork 0
Code Issues 60 Pull Requests Actions 1 Projects 12 Releases 1 Wiki Activity

Complete analytics module object interface migration #162

New Issue
Open
opened 2025-10-14 22:07:21 +00:00 by tegwick · 0 comments
tegwick commented 2025-10-14 22:07:21 +00:00
Owner
Copy Link

Problem

Some parts of the analytics module still expect dict-based asset access patterns, creating inconsistencies with the new object-based Asset model.

Evidence

During the dict-to-object migration, several fixes were needed:

  • analytics.py had to be updated to use list_assets_as_objects() instead of list_assets()
  • get_asset() calls needed to be changed to get_asset_as_object()
  • Mixed dict/object access patterns in usage report generation

Remaining Issues

Some analytics code may still have remnants of dict-based assumptions that could cause issues in edge cases.

Impact

  • Type safety not fully enforced in analytics
  • Potential runtime errors if dict access patterns remain
  • Inconsistent developer experience across the system
  • Reduced IDE support and code completion

Proposed Solution

  1. Audit all analytics code for dict vs object access patterns
  2. Add type hints throughout analytics module for Asset objects
  3. Create analytics-specific Asset utilities if needed
  4. Update tests to verify object-based interfaces work correctly

Benefits

  • Full type safety across the system
  • Better IDE support and developer experience
  • Consistent object-based interfaces everywhere
  • Easier maintenance and debugging

Files Affected

  • markitect/assets/analytics.py - Core analytics logic
  • Tests for analytics functionality
  • Any CLI commands that use analytics

Priority

Medium - Improves code quality and prevents future bugs

## Problem Some parts of the analytics module still expect dict-based asset access patterns, creating inconsistencies with the new object-based Asset model. ## Evidence During the dict-to-object migration, several fixes were needed: - analytics.py had to be updated to use list_assets_as_objects() instead of list_assets() - get_asset() calls needed to be changed to get_asset_as_object() - Mixed dict/object access patterns in usage report generation ## Remaining Issues Some analytics code may still have remnants of dict-based assumptions that could cause issues in edge cases. ## Impact - Type safety not fully enforced in analytics - Potential runtime errors if dict access patterns remain - Inconsistent developer experience across the system - Reduced IDE support and code completion ## Proposed Solution 1. **Audit all analytics code** for dict vs object access patterns 2. **Add type hints** throughout analytics module for Asset objects 3. **Create analytics-specific Asset utilities** if needed 4. **Update tests** to verify object-based interfaces work correctly ## Benefits - Full type safety across the system - Better IDE support and developer experience - Consistent object-based interfaces everywhere - Easier maintenance and debugging ## Files Affected - markitect/assets/analytics.py - Core analytics logic - Tests for analytics functionality - Any CLI commands that use analytics ## Priority Medium - Improves code quality and prevents future bugs
tegwick added this to the Images And File Attachments project 2025-10-14 22:21:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
priority:critical
Critical priority issue
 priority:high
High priority issue
 priority:low
Low priority issue
 priority:medium
Medium priority issue
 status:active
Issues currently being worked on
 status:blocked
Issues blocked by dependencies
 status:done
Completed issues
 status:review
Issues under review
 status:todo
Issues ready to be worked on
 type:bug
Bug report
 type:documentation
Documentation update
 type:enhancement
Enhancement to existing feature
 type:feature
New feature request
 wish
Feature wishlist item - idea to be discussed and refined
 wish/archived
Archived or rejected wishlist item
 wish/discussion
Wishlist item currently being discussed and refined
 wish/draft
Wishlist item with initial draft specification
 wish/ready
Wishlist item ready to become a regular issue
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Images And File Attachments
Assignees
Clear assignees
bubble-reader tegwick
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coulomb/markitect-main#162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?