tegwick
17c62aadaa
Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
47 lines
1.7 KiB
JavaScript
47 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
var $SyntaxError = require('es-errors/syntax');
|
|
var $TypeError = require('es-errors/type');
|
|
|
|
var IsDetachedBuffer = require('./IsDetachedBuffer');
|
|
|
|
var isArrayBuffer = require('is-array-buffer');
|
|
var isSharedArrayBuffer = require('is-shared-array-buffer');
|
|
|
|
var MessageChannel;
|
|
try {
|
|
// eslint-disable-next-line global-require
|
|
MessageChannel = require('worker_threads').MessageChannel;
|
|
} catch (e) { /**/ }
|
|
|
|
// https://262.ecma-international.org/9.0/#sec-detacharraybuffer
|
|
|
|
/* globals postMessage */
|
|
|
|
module.exports = function DetachArrayBuffer(arrayBuffer) {
|
|
if (!isArrayBuffer(arrayBuffer) || isSharedArrayBuffer(arrayBuffer)) {
|
|
throw new $TypeError('Assertion failed: `arrayBuffer` must be an Object with an [[ArrayBufferData]] internal slot, and not a Shared Array Buffer');
|
|
}
|
|
|
|
// commented out since there's no way to set or access this key
|
|
// var key = arguments.length > 1 ? arguments[1] : void undefined;
|
|
|
|
// if (!SameValue(arrayBuffer[[ArrayBufferDetachKey]], key)) {
|
|
// throw new $TypeError('Assertion failed: `key` must be the value of the [[ArrayBufferDetachKey]] internal slot of `arrayBuffer`');
|
|
// }
|
|
|
|
if (!IsDetachedBuffer(arrayBuffer)) { // node v21.0.0+ throws when you structuredClone a detached buffer
|
|
if (typeof structuredClone === 'function') {
|
|
structuredClone(arrayBuffer, { transfer: [arrayBuffer] });
|
|
} else if (typeof postMessage === 'function') {
|
|
postMessage('', '/', [arrayBuffer]); // TODO: see if this might trigger listeners
|
|
} else if (MessageChannel) {
|
|
(new MessageChannel()).port1.postMessage(null, [arrayBuffer]);
|
|
} else {
|
|
throw new $SyntaxError('DetachArrayBuffer is not supported in this environment');
|
|
}
|
|
}
|
|
|
|
return null;
|
|
};
|