tegwick
17c62aadaa
Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
44 lines
1.8 KiB
JavaScript
44 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
var GetIntrinsic = require('get-intrinsic');
|
|
var $concat = GetIntrinsic('%Array.prototype.concat%');
|
|
|
|
var callBind = require('call-bind');
|
|
|
|
var callBound = require('call-bound');
|
|
var $slice = callBound('Array.prototype.slice');
|
|
|
|
var hasSymbols = require('has-symbols/shams')();
|
|
var isConcatSpreadable = hasSymbols && Symbol.isConcatSpreadable;
|
|
|
|
/** @type {never[]} */ var empty = [];
|
|
var $concatApply = isConcatSpreadable ? callBind.apply($concat, empty) : null;
|
|
|
|
// eslint-disable-next-line no-extra-parens
|
|
var isArray = isConcatSpreadable ? /** @type {(value: unknown) => value is unknown[]} */ (require('isarray')) : null;
|
|
|
|
/** @type {import('.')} */
|
|
module.exports = isConcatSpreadable
|
|
// eslint-disable-next-line no-unused-vars
|
|
? function safeArrayConcat(item) {
|
|
for (var i = 0; i < arguments.length; i += 1) {
|
|
/** @type {typeof item} */ var arg = arguments[i];
|
|
// @ts-expect-error ts(2538) see https://github.com/microsoft/TypeScript/issues/9998#issuecomment-1890787975; works if `const`
|
|
if (arg && typeof arg === 'object' && typeof arg[isConcatSpreadable] === 'boolean') {
|
|
// @ts-expect-error ts(7015) TS doesn't yet support Symbol indexing
|
|
if (!empty[isConcatSpreadable]) {
|
|
// @ts-expect-error ts(7015) TS doesn't yet support Symbol indexing
|
|
empty[isConcatSpreadable] = true;
|
|
}
|
|
// @ts-expect-error ts(2721) ts(18047) not sure why TS can't figure out this can't be null
|
|
var arr = isArray(arg) ? $slice(arg) : [arg];
|
|
// @ts-expect-error ts(7015) TS can't handle expandos on an array
|
|
arr[isConcatSpreadable] = true; // shadow the property. TODO: use [[Define]]
|
|
arguments[i] = arr;
|
|
}
|
|
}
|
|
// @ts-expect-error ts(2345) https://github.com/microsoft/TypeScript/issues/57164 TS doesn't understand that apply can take an arguments object
|
|
return $concatApply(arguments);
|
|
}
|
|
: callBind($concat, empty);
|