Files
markitect-main/capabilities/testdrive-jsui/node_modules/es-abstract/2022/ValidateAndApplyPropertyDescriptor.js
tegwick 17c62aadaa feat: complete testdrive-jsui capability extraction with full JavaScript test integration
Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability
while maintaining 100% functionality preservation and integrating JavaScript tests
into the main Python test suite.

Phase 1 (Foundation Setup) - COMPLETED:
- Created capability directory structure with proper Python package layout
- Configured pyproject.toml with Node.js subprocess dependencies
- Set up package.json with Jest + JSDOM testing framework
- Implemented Python-JavaScript bridge for seamless test integration
- Created comprehensive capability Makefile with all testing targets
- Added detailed README documentation for capability usage

Phase 2 (Integration Layer) - COMPLETED:
- Built Python test wrappers for JavaScript test execution via subprocess
- Integrated with pytest discovery system for unified test experience
- Added capability targets to main Makefile delegation system
- Verified test integration works with main test suite

Phase 3 (Safe Migration) - COMPLETED:
- Copied (not moved) all JavaScript files to capability using safe copy-first approach
- Migrated 4 core JavaScript components and 11 test files (2,840+ lines)
- Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing)
- Maintained dual-track testing capability for safety during transition

Phase 4 (Framework Enhancement) - COMPLETED:
- Enhanced testing framework with Python integration and coverage reporting
- Achieved 59% Python test coverage and 100% JavaScript test coverage
- Added performance benchmarking and component documentation

Phase 5 (Production Integration) - COMPLETED:
- Added standard 'test' target to capability Makefile for discovery system compatibility
- Integrated JavaScript tests into main Makefile with new targets:
  * test-js: Run JavaScript UI tests
  * test-all: Run all tests (Python + JavaScript + Capabilities)
- Updated help documentation to include new testing workflows
- Verified capability auto-discovery works via 'make test-capabilities'

Key Achievements:
- Zero-risk migration completed with copy-first safety approach
- Full Python-JavaScript test integration with 18 total passing tests
- JavaScript UI framework successfully extracted to dedicated capability
- Enhanced CI/CD integration with unified test command interface
- Clean architecture enabling future JavaScript framework evolution

Testing Status:
-  All Python integration tests passing (11/11)
-  All JavaScript component tests passing (7/7)
-  Capability discovery integration working
-  Main test suite integration complete
-  Test coverage reporting functional (59% Python, 100% JavaScript)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-09 22:29:30 +01:00

172 lines
5.6 KiB
JavaScript

'use strict';
var $TypeError = require('es-errors/type');
var isObject = require('es-object-atoms/isObject');
var DefineOwnProperty = require('../helpers/DefineOwnProperty');
var isFullyPopulatedPropertyDescriptor = require('../helpers/isFullyPopulatedPropertyDescriptor');
var isPropertyDescriptor = require('../helpers/records/property-descriptor');
var FromPropertyDescriptor = require('./FromPropertyDescriptor');
var IsAccessorDescriptor = require('./IsAccessorDescriptor');
var IsDataDescriptor = require('./IsDataDescriptor');
var IsGenericDescriptor = require('./IsGenericDescriptor');
var isPropertyKey = require('../helpers/isPropertyKey');
var SameValue = require('./SameValue');
// https://262.ecma-international.org/13.0/#sec-validateandapplypropertydescriptor
// see https://github.com/tc39/ecma262/pull/2468 for ES2022 changes
// eslint-disable-next-line max-lines-per-function, max-statements
module.exports = function ValidateAndApplyPropertyDescriptor(O, P, extensible, Desc, current) {
if (typeof O !== 'undefined' && !isObject(O)) {
throw new $TypeError('Assertion failed: O must be undefined or an Object');
}
if (!isPropertyKey(P)) {
throw new $TypeError('Assertion failed: P must be a Property Key');
}
if (typeof extensible !== 'boolean') {
throw new $TypeError('Assertion failed: extensible must be a Boolean');
}
if (!isPropertyDescriptor(Desc)) {
throw new $TypeError('Assertion failed: Desc must be a Property Descriptor');
}
if (typeof current !== 'undefined' && !isPropertyDescriptor(current)) {
throw new $TypeError('Assertion failed: current must be a Property Descriptor, or undefined');
}
if (typeof current === 'undefined') { // step 2
if (!extensible) {
return false; // step 2.a
}
if (typeof O === 'undefined') {
return true; // step 2.b
}
if (IsAccessorDescriptor(Desc)) { // step 2.c
return DefineOwnProperty(
IsDataDescriptor,
SameValue,
FromPropertyDescriptor,
O,
P,
Desc
);
}
// step 2.d
return DefineOwnProperty(
IsDataDescriptor,
SameValue,
FromPropertyDescriptor,
O,
P,
{
'[[Configurable]]': !!Desc['[[Configurable]]'],
'[[Enumerable]]': !!Desc['[[Enumerable]]'],
'[[Value]]': Desc['[[Value]]'],
'[[Writable]]': !!Desc['[[Writable]]']
}
);
}
// 3. Assert: current is a fully populated Property Descriptor.
if (
!isFullyPopulatedPropertyDescriptor(
{
IsAccessorDescriptor: IsAccessorDescriptor,
IsDataDescriptor: IsDataDescriptor
},
current
)
) {
throw new $TypeError('`current`, when present, must be a fully populated and valid Property Descriptor');
}
// 4. If every field in Desc is absent, return true.
// this can't really match the assertion that it's a Property Descriptor in our JS implementation
// 5. If current.[[Configurable]] is false, then
if (!current['[[Configurable]]']) {
if ('[[Configurable]]' in Desc && Desc['[[Configurable]]']) {
// step 5.a
return false;
}
if ('[[Enumerable]]' in Desc && !SameValue(Desc['[[Enumerable]]'], current['[[Enumerable]]'])) {
// step 5.b
return false;
}
if (!IsGenericDescriptor(Desc) && !SameValue(IsAccessorDescriptor(Desc), IsAccessorDescriptor(current))) {
// step 5.c
return false;
}
if (IsAccessorDescriptor(current)) { // step 5.d
if ('[[Get]]' in Desc && !SameValue(Desc['[[Get]]'], current['[[Get]]'])) {
return false;
}
if ('[[Set]]' in Desc && !SameValue(Desc['[[Set]]'], current['[[Set]]'])) {
return false;
}
} else if (!current['[[Writable]]']) { // step 5.e
if ('[[Writable]]' in Desc && Desc['[[Writable]]']) {
return false;
}
if ('[[Value]]' in Desc && !SameValue(Desc['[[Value]]'], current['[[Value]]'])) {
return false;
}
}
}
// 6. If O is not undefined, then
if (typeof O !== 'undefined') {
var configurable;
var enumerable;
if (IsDataDescriptor(current) && IsAccessorDescriptor(Desc)) { // step 6.a
configurable = ('[[Configurable]]' in Desc ? Desc : current)['[[Configurable]]'];
enumerable = ('[[Enumerable]]' in Desc ? Desc : current)['[[Enumerable]]'];
// Replace the property named P of object O with an accessor property having [[Configurable]] and [[Enumerable]] attributes as described by current and each other attribute set to its default value.
return DefineOwnProperty(
IsDataDescriptor,
SameValue,
FromPropertyDescriptor,
O,
P,
{
'[[Configurable]]': !!configurable,
'[[Enumerable]]': !!enumerable,
'[[Get]]': ('[[Get]]' in Desc ? Desc : current)['[[Get]]'],
'[[Set]]': ('[[Set]]' in Desc ? Desc : current)['[[Set]]']
}
);
} else if (IsAccessorDescriptor(current) && IsDataDescriptor(Desc)) {
configurable = ('[[Configurable]]' in Desc ? Desc : current)['[[Configurable]]'];
enumerable = ('[[Enumerable]]' in Desc ? Desc : current)['[[Enumerable]]'];
// i. Replace the property named P of object O with a data property having [[Configurable]] and [[Enumerable]] attributes as described by current and each other attribute set to its default value.
return DefineOwnProperty(
IsDataDescriptor,
SameValue,
FromPropertyDescriptor,
O,
P,
{
'[[Configurable]]': !!configurable,
'[[Enumerable]]': !!enumerable,
'[[Value]]': ('[[Value]]' in Desc ? Desc : current)['[[Value]]'],
'[[Writable]]': !!('[[Writable]]' in Desc ? Desc : current)['[[Writable]]']
}
);
}
// For each field of Desc that is present, set the corresponding attribute of the property named P of object O to the value of the field.
return DefineOwnProperty(
IsDataDescriptor,
SameValue,
FromPropertyDescriptor,
O,
P,
Desc
);
}
return true; // step 7
};