Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
63 lines
2.2 KiB
JavaScript
63 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
var $TypeError = require('es-errors/type');
|
|
var isObject = require('es-object-atoms/isObject');
|
|
|
|
var Call = require('./Call');
|
|
var CompletionRecord = require('./CompletionRecord');
|
|
var GetMethod = require('./GetMethod');
|
|
var IsCallable = require('./IsCallable');
|
|
|
|
var isIteratorRecord = require('../helpers/records/iterator-record-2023');
|
|
|
|
// https://262.ecma-international.org/14.0/#sec-iteratorclose
|
|
|
|
module.exports = function IteratorClose(iteratorRecord, completion) {
|
|
if (!isIteratorRecord(iteratorRecord)) {
|
|
throw new $TypeError('Assertion failed: `iteratorRecord` must be an Iterator Record'); // step 1
|
|
}
|
|
if (!isObject(iteratorRecord['[[Iterator]]'])) {
|
|
throw new $TypeError('Assertion failed: iteratorRecord.[[Iterator]] must be an Object'); // step 1
|
|
}
|
|
|
|
if (!IsCallable(completion) && !(completion instanceof CompletionRecord)) { // step 2
|
|
throw new $TypeError('Assertion failed: completion is not a thunk representing a Completion Record, nor a Completion Record instance');
|
|
}
|
|
var completionThunk = completion instanceof CompletionRecord ? function () { return completion['?'](); } : completion;
|
|
|
|
var iterator = iteratorRecord['[[Iterator]]']; // step 3
|
|
|
|
var iteratorReturn;
|
|
try {
|
|
iteratorReturn = GetMethod(iterator, 'return'); // step 4
|
|
} catch (e) {
|
|
completionThunk(); // throws if `completion` is a throw completion // step 6
|
|
completionThunk = null; // ensure it's not called twice.
|
|
throw e; // step 7
|
|
}
|
|
if (typeof iteratorReturn === 'undefined') {
|
|
return completionThunk(); // step 5.a - 5.b
|
|
}
|
|
|
|
var innerResult;
|
|
try {
|
|
innerResult = Call(iteratorReturn, iterator, []);
|
|
} catch (e) {
|
|
// if we hit here, then "e" is the innerResult completion that needs re-throwing
|
|
|
|
completionThunk(); // throws if `completion` is a throw completion // step 6
|
|
completionThunk = null; // ensure it's not called twice.
|
|
|
|
// if not, then return the innerResult completion
|
|
throw e; // step 7
|
|
}
|
|
var completionRecord = completionThunk(); // if innerResult worked, then throw if the completion does
|
|
completionThunk = null; // ensure it's not called twice.
|
|
|
|
if (!isObject(innerResult)) {
|
|
throw new $TypeError('iterator .return must return an object');
|
|
}
|
|
|
|
return completionRecord;
|
|
};
|