Files
markitect-main/tests/test_issue_11_workspace_creation_validation.py
tegwick 3e7d2b55d5 fix: Resolve TDD infrastructure test failures and API mismatches
Comprehensive fix for 9 failing TDD tests caused by API mismatches between
test expectations and actual WorkspaceManager implementation.

**Root Cause Analysis:**
- Tests incorrectly passed strings instead of TddaiConfig objects
- API return type mismatches (expected Path, got Workspace objects)
- Missing methods: add_test_to_workspace() and get_workspace_status()
- Incorrect assumptions about WorkspaceStatus enum attributes
- Metadata field name differences (issue_number vs number)

**WorkspaceManager API Fixes:**
- Added add_test_to_workspace(filename, content) method
- Added get_workspace_status() alias for get_status()
- Enhanced error handling for workspace operations

**Test Corrections:**
- Fixed WorkspaceManager initialization to use TddaiConfig objects
- Updated API usage to match Workspace object return types
- Corrected WorkspaceStatus enum handling
- Fixed metadata field expectations
- Updated error message patterns to match actual implementation

**Results:**
- Before: 9 failing tests, 23 passing (28% failure rate)
- After: 0 failing tests, 32 passing (100% success rate)

This restores the TDD infrastructure to full functionality, validating
that our Issue #1 implementation approach was sound and the tooling
is ready for productive development.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-23 04:46:22 +02:00

160 lines
5.4 KiB
Python

"""
Test workspace creation validation for Issue #11: Setup TDD workspace infrastructure
This test validates that the TDD workspace infrastructure can successfully create
and manage workspaces for issue-driven development.
Issue Reference: #11 - Setup TDD workspace infrastructure
"""
import pytest
import os
import json
import tempfile
import shutil
from pathlib import Path
from unittest.mock import patch, MagicMock
from tddai import WorkspaceManager, WorkspaceStatus, WorkspaceError
from tddai.config import TddaiConfig
class TestWorkspaceCreationValidation:
"""Test workspace creation and basic infrastructure validation."""
def setup_method(self):
"""Set up test environment with temporary workspace."""
self.test_dir = tempfile.mkdtemp()
self.workspace_dir = Path(self.test_dir) / '.markitect_workspace'
self.config = TddaiConfig(workspace_dir=self.workspace_dir)
self.workspace_manager = WorkspaceManager(self.config)
def teardown_method(self):
"""Clean up test environment."""
if os.path.exists(self.test_dir):
shutil.rmtree(self.test_dir)
def test_workspace_creation_from_issue_data(self):
"""Test that workspace can be created from issue data."""
# Arrange
issue_data = {
'number': 11,
'title': 'Setup TDD workspace infrastructure',
'body': 'Test workspace creation and management',
'state': 'open'
}
# Act
workspace = self.workspace_manager.create_workspace(issue_data)
# Assert
assert workspace.issue_dir.exists()
assert workspace.requirements_file.exists()
assert workspace.test_plan_file.exists()
assert workspace.tests_dir.exists()
assert workspace.tests_dir.is_dir()
def test_workspace_metadata_persistence(self):
"""Test that workspace metadata is properly persisted."""
# Arrange
issue_data = {
'number': 11,
'title': 'Setup TDD workspace infrastructure',
'body': 'Test workspace metadata',
'state': 'open'
}
# Act
self.workspace_manager.create_workspace(issue_data)
# Assert
current_issue_file = self.workspace_dir / 'current_issue.json'
assert current_issue_file.exists()
with open(current_issue_file, 'r') as f:
metadata = json.load(f)
assert metadata['number'] == 11
assert metadata['title'] == 'Setup TDD workspace infrastructure'
assert metadata['body'] == 'Test workspace metadata'
assert 'created_at' in metadata
def test_workspace_status_reporting(self):
"""Test that workspace status can be accurately reported."""
# Arrange
issue_data = {
'number': 11,
'title': 'Setup TDD workspace infrastructure',
'body': 'Test status reporting',
'state': 'open'
}
# Act
self.workspace_manager.create_workspace(issue_data)
status = self.workspace_manager.get_workspace_status()
# Assert
assert isinstance(status, WorkspaceStatus)
assert status == WorkspaceStatus.ACTIVE
# Verify we can get the workspace details
workspace = self.workspace_manager.get_current_workspace()
assert workspace.issue_number == 11
assert workspace.issue_title == 'Setup TDD workspace infrastructure'
assert workspace.issue_state == 'open'
def test_multiple_workspace_prevention(self):
"""Test that only one workspace can be active at a time."""
# Arrange
issue_data_1 = {'number': 11, 'title': 'First Issue', 'body': 'Test', 'state': 'open'}
issue_data_2 = {'number': 12, 'title': 'Second Issue', 'body': 'Test', 'state': 'open'}
# Act
self.workspace_manager.create_workspace(issue_data_1)
# Assert
with pytest.raises(WorkspaceError, match="Workspace already active"):
self.workspace_manager.create_workspace(issue_data_2)
def test_workspace_test_directory_structure(self):
"""Test that workspace creates proper test directory structure."""
# Arrange
issue_data = {
'number': 11,
'title': 'Setup TDD workspace infrastructure',
'body': 'Test directory structure',
'state': 'open'
}
# Act
workspace = self.workspace_manager.create_workspace(issue_data)
# Assert
assert workspace.tests_dir.exists()
assert workspace.tests_dir.is_dir()
# Test directory should be empty initially
assert len(list(workspace.tests_dir.iterdir())) == 0
def test_workspace_cleanup_capability(self):
"""Test that workspace can be properly cleaned up."""
# Arrange
issue_data = {
'number': 11,
'title': 'Setup TDD workspace infrastructure',
'body': 'Test cleanup',
'state': 'open'
}
# Act
workspace = self.workspace_manager.create_workspace(issue_data)
assert workspace.issue_dir.exists()
self.workspace_manager.cleanup_workspace()
# Assert
assert not workspace.issue_dir.exists()
current_issue_file = self.workspace_dir / 'current_issue.json'
assert not current_issue_file.exists()
if __name__ == '__main__':
pytest.main([__file__, '-v'])