Files
markitect-main/tests/utils/assertions.py
tegwick 21a5d1d734
Some checks failed
Test Suite / unit-tests (3.11) (push) Has been cancelled
Test Suite / unit-tests (3.12) (push) Has been cancelled
Test Suite / integration-tests (push) Has been cancelled
Test Suite / e2e-tests (push) Has been cancelled
Test Suite / performance-tests (push) Has been cancelled
Test Suite / code-quality (push) Has been cancelled
Test Suite / security-scan (push) Has been cancelled
Test Suite / test-summary (push) Has been cancelled
feat: Implement comprehensive Testing Architecture Enhancement
Establishes robust testing framework with clean architecture patterns:

## Phase 1: Test Infrastructure Foundation
- Global test configuration with pytest.ini and conftest.py
- Isolated test workspaces and environment management
- Comprehensive fixture library for all test types
- Test requirements and dependency management

## Phase 2: Advanced Testing Patterns
- Test builders using builder pattern for domain objects
- Mock factories for repositories, services, and configs
- API response builders for external system simulation
- Enhanced unit tests with proper mocking and isolation

## Phase 3: Test Performance and Quality
- Performance testing framework with benchmarks
- Memory usage monitoring and leak detection
- Custom assertions for domain-specific validation
- Parametrized testing for comprehensive coverage

## Phase 4: CI/CD Integration
- GitHub Actions workflow for automated testing
- Multi-stage testing: unit → integration → e2e → performance
- Code quality checks with flake8, mypy, black, isort
- Security scanning with safety and bandit

## Testing Architecture Benefits
 100+ new test infrastructure components
 Standardized test organization (unit/integration/e2e)
 Mock-based testing with no external dependencies
 Performance regression detection
 Comprehensive fixture library
 CI/CD pipeline with quality gates

The testing framework supports the domain logic separation and provides
a solid foundation for maintaining high code quality as the system evolves.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-26 22:36:35 +02:00

274 lines
12 KiB
Python

"""
Custom assertions and test utilities for MarkiTect tests.
"""
import json
from typing import Any, Dict, List, Optional, Union, Callable
from datetime import datetime, timezone
from pathlib import Path
import pytest
def assert_issue_equal(actual, expected, ignore_timestamps: bool = False):
"""Assert that two Issue objects are equal."""
assert actual.number == expected.number, f"Issue numbers don't match: {actual.number} != {expected.number}"
assert actual.title == expected.title, f"Issue titles don't match: {actual.title} != {expected.title}"
assert actual.state == expected.state, f"Issue states don't match: {actual.state} != {expected.state}"
assert len(actual.labels) == len(expected.labels), f"Label counts don't match: {len(actual.labels)} != {len(expected.labels)}"
# Compare labels
actual_label_names = {label.name for label in actual.labels}
expected_label_names = {label.name for label in expected.labels}
assert actual_label_names == expected_label_names, f"Labels don't match: {actual_label_names} != {expected_label_names}"
if not ignore_timestamps:
assert actual.created_at == expected.created_at, f"Created timestamps don't match"
assert actual.updated_at == expected.updated_at, f"Updated timestamps don't match"
assert actual.closed_at == expected.closed_at, f"Closed timestamps don't match"
def assert_project_equal(actual, expected, ignore_timestamps: bool = False):
"""Assert that two Project objects are equal."""
assert actual.name == expected.name, f"Project names don't match: {actual.name} != {expected.name}"
assert actual.description == expected.description, f"Project descriptions don't match"
assert actual.state == expected.state, f"Project states don't match: {actual.state} != {expected.state}"
assert actual.kanban_columns == expected.kanban_columns, f"Kanban columns don't match"
assert len(actual.milestones) == len(expected.milestones), f"Milestone counts don't match"
if not ignore_timestamps:
assert actual.created_at == expected.created_at, f"Created timestamps don't match"
assert actual.updated_at == expected.updated_at, f"Updated timestamps don't match"
assert actual.archived_at == expected.archived_at, f"Archived timestamps don't match"
def assert_milestone_equal(actual, expected):
"""Assert that two Milestone objects are equal."""
assert actual.id == expected.id, f"Milestone IDs don't match: {actual.id} != {expected.id}"
assert actual.title == expected.title, f"Milestone titles don't match: {actual.title} != {expected.title}"
assert actual.description == expected.description, f"Milestone descriptions don't match"
assert actual.state == expected.state, f"Milestone states don't match: {actual.state} != {expected.state}"
assert actual.open_issues == expected.open_issues, f"Open issue counts don't match"
assert actual.closed_issues == expected.closed_issues, f"Closed issue counts don't match"
assert actual.due_date == expected.due_date, f"Due dates don't match"
def assert_json_equal(actual: Union[str, Dict], expected: Union[str, Dict]):
"""Assert that two JSON objects are equal."""
if isinstance(actual, str):
actual = json.loads(actual)
if isinstance(expected, str):
expected = json.loads(expected)
assert actual == expected, f"JSON objects don't match:\nActual: {json.dumps(actual, indent=2)}\nExpected: {json.dumps(expected, indent=2)}"
def assert_markdown_structure_equal(actual: str, expected: str):
"""Assert that two markdown documents have the same structure (ignoring whitespace differences)."""
actual_lines = [line.strip() for line in actual.split('\n') if line.strip()]
expected_lines = [line.strip() for line in expected.split('\n') if line.strip()]
assert len(actual_lines) == len(expected_lines), f"Line count mismatch: {len(actual_lines)} != {len(expected_lines)}"
for i, (actual_line, expected_line) in enumerate(zip(actual_lines, expected_lines)):
assert actual_line == expected_line, f"Line {i+1} mismatch:\nActual: {actual_line}\nExpected: {expected_line}"
def assert_file_exists(file_path: Union[str, Path], message: str = None):
"""Assert that a file exists."""
path = Path(file_path)
assert path.exists(), message or f"File does not exist: {path}"
assert path.is_file(), message or f"Path is not a file: {path}"
def assert_directory_exists(dir_path: Union[str, Path], message: str = None):
"""Assert that a directory exists."""
path = Path(dir_path)
assert path.exists(), message or f"Directory does not exist: {path}"
assert path.is_dir(), message or f"Path is not a directory: {path}"
def assert_file_contains(file_path: Union[str, Path], content: str, message: str = None):
"""Assert that a file contains specific content."""
path = Path(file_path)
assert_file_exists(path)
file_content = path.read_text()
assert content in file_content, message or f"File {path} does not contain: {content}"
def assert_file_not_contains(file_path: Union[str, Path], content: str, message: str = None):
"""Assert that a file does not contain specific content."""
path = Path(file_path)
assert_file_exists(path)
file_content = path.read_text()
assert content not in file_content, message or f"File {path} unexpectedly contains: {content}"
def assert_time_approximately_equal(actual: datetime, expected: datetime, tolerance_seconds: int = 1):
"""Assert that two datetime objects are approximately equal within tolerance."""
diff = abs((actual - expected).total_seconds())
assert diff <= tolerance_seconds, f"Times differ by {diff} seconds, tolerance is {tolerance_seconds}"
def assert_performance_within_bounds(execution_time: float, max_time: float, operation: str = "operation"):
"""Assert that an operation completed within performance bounds."""
assert execution_time <= max_time, f"{operation} took {execution_time:.3f}s, expected <= {max_time:.3f}s"
def assert_memory_usage_within_bounds(memory_usage_mb: float, max_memory_mb: float, operation: str = "operation"):
"""Assert that memory usage is within bounds."""
assert memory_usage_mb <= max_memory_mb, f"{operation} used {memory_usage_mb:.2f}MB, expected <= {max_memory_mb:.2f}MB"
def assert_mock_called_with_pattern(mock, pattern: Callable[[Any], bool], message: str = None):
"""Assert that a mock was called with arguments matching a pattern."""
found_match = False
for call in mock.call_args_list:
if pattern(call):
found_match = True
break
assert found_match, message or f"Mock was not called with expected pattern. Calls: {mock.call_args_list}"
def assert_sequence_equal(actual: List[Any], expected: List[Any], compare_fn: Optional[Callable[[Any, Any], bool]] = None):
"""Assert that two sequences are equal using optional custom comparison."""
assert len(actual) == len(expected), f"Sequence lengths don't match: {len(actual)} != {len(expected)}"
for i, (actual_item, expected_item) in enumerate(zip(actual, expected)):
if compare_fn:
assert compare_fn(actual_item, expected_item), f"Items at index {i} don't match"
else:
assert actual_item == expected_item, f"Items at index {i} don't match: {actual_item} != {expected_item}"
def assert_contains_all(container: Union[List, Dict, str], items: List[Any], message: str = None):
"""Assert that a container contains all specified items."""
missing_items = []
for item in items:
if item not in container:
missing_items.append(item)
assert not missing_items, message or f"Container missing items: {missing_items}"
def assert_contains_none(container: Union[List, Dict, str], items: List[Any], message: str = None):
"""Assert that a container contains none of the specified items."""
found_items = []
for item in items:
if item in container:
found_items.append(item)
assert not found_items, message or f"Container unexpectedly contains items: {found_items}"
def assert_label_categories_valid(categories):
"""Assert that label categories are valid and properly separated."""
from domain.issues.models import LabelCategories
assert isinstance(categories, LabelCategories), "Categories must be LabelCategories instance"
# Check for overlaps between categories
all_labels = (
categories.state_labels +
categories.priority_labels +
categories.type_labels +
categories.other_labels
)
# No label should appear in multiple categories
seen_labels = set()
for label in all_labels:
assert label not in seen_labels, f"Label '{label}' appears in multiple categories"
seen_labels.add(label)
def assert_kanban_column_valid(column: str, valid_columns: List[str]):
"""Assert that a kanban column is valid."""
assert column in valid_columns, f"Invalid kanban column '{column}'. Valid columns: {valid_columns}"
def assert_business_rule_violated(exception_type: type, exception_message_pattern: str = None):
"""Context manager to assert that a business rule violation occurs."""
return pytest.raises(exception_type, match=exception_message_pattern)
def assert_async_operation_succeeds(async_func: Callable, timeout: float = 30.0):
"""Assert that an async operation succeeds within timeout."""
import asyncio
async def run_with_timeout():
return await asyncio.wait_for(async_func(), timeout=timeout)
try:
result = asyncio.run(run_with_timeout())
return result
except asyncio.TimeoutError:
pytest.fail(f"Async operation timed out after {timeout} seconds")
except Exception as e:
pytest.fail(f"Async operation failed: {e}")
# Custom pytest markers for different types of assertions
def mark_performance_test(max_time: float = None, max_memory_mb: float = None):
"""Mark a test as a performance test with optional bounds."""
markers = [pytest.mark.performance]
if max_time:
markers.append(pytest.mark.parametrize("max_execution_time", [max_time]))
if max_memory_mb:
markers.append(pytest.mark.parametrize("max_memory_usage", [max_memory_mb]))
return markers
def mark_integration_test(external_service: str = None):
"""Mark a test as an integration test."""
markers = [pytest.mark.integration]
if external_service:
markers.append(pytest.mark.parametrize("external_service", [external_service]))
return markers
# Test data validation helpers
def validate_issue_data(data: Dict[str, Any]) -> bool:
"""Validate that data represents a valid issue."""
required_fields = ["number", "title", "state", "labels", "created_at", "updated_at"]
for field in required_fields:
if field not in data:
return False
if not isinstance(data["number"], int) or data["number"] <= 0:
return False
if not isinstance(data["title"], str) or not data["title"].strip():
return False
if data["state"] not in ["open", "closed"]:
return False
if not isinstance(data["labels"], list):
return False
return True
def validate_project_data(data: Dict[str, Any]) -> bool:
"""Validate that data represents a valid project."""
required_fields = ["name", "state", "milestones", "kanban_columns", "created_at", "updated_at"]
for field in required_fields:
if field not in data:
return False
if not isinstance(data["name"], str) or not data["name"].strip():
return False
if data["state"] not in ["active", "archived"]:
return False
if not isinstance(data["milestones"], list):
return False
if not isinstance(data["kanban_columns"], list):
return False
return True