Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
78 lines
2.0 KiB
JavaScript
78 lines
2.0 KiB
JavaScript
// Borrowed from here:
|
|
// https://github.com/colonyamerican/eslint-plugin-cah/issues/3
|
|
|
|
'use strict'
|
|
|
|
const { getScope } = require('./lib/eslint-compat')
|
|
const getDocsUrl = require('./lib/get-docs-url')
|
|
|
|
function isDeclared(scope, ref) {
|
|
return scope.variables.some((variable) => {
|
|
if (variable.name !== ref.identifier.name) {
|
|
return false
|
|
}
|
|
|
|
// Presumably can't pass this since the implicit `Promise` global
|
|
// being checked here would always lack `defs`
|
|
// istanbul ignore else
|
|
if (!variable.defs || !variable.defs.length) {
|
|
return false
|
|
}
|
|
|
|
// istanbul ignore next
|
|
return true
|
|
})
|
|
}
|
|
|
|
module.exports = {
|
|
meta: {
|
|
type: 'suggestion',
|
|
docs: {
|
|
description:
|
|
'Require creating a `Promise` constructor before using it in an ES5 environment.',
|
|
url: getDocsUrl('no-native'),
|
|
},
|
|
messages: {
|
|
name: '"{{name}}" is not defined.',
|
|
},
|
|
schema: [],
|
|
},
|
|
create(context) {
|
|
/**
|
|
* Checks for and reports reassigned constants
|
|
*
|
|
* @param {Scope} scope - an eslint-scope Scope object
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
return {
|
|
'Program:exit'(node) {
|
|
const scope = getScope(context, node)
|
|
const leftToBeResolved =
|
|
scope.implicit.left ||
|
|
/**
|
|
* Fixes https://github.com/eslint-community/eslint-plugin-promise/issues/205.
|
|
* The problem was that @typescript-eslint has a scope manager
|
|
* which has `leftToBeResolved` instead of the default `left`.
|
|
*/
|
|
scope.implicit.leftToBeResolved
|
|
|
|
leftToBeResolved.forEach((ref) => {
|
|
if (ref.identifier.name !== 'Promise') {
|
|
return
|
|
}
|
|
|
|
// istanbul ignore else
|
|
if (!isDeclared(scope, ref)) {
|
|
context.report({
|
|
node: ref.identifier,
|
|
messageId: 'name',
|
|
data: { name: ref.identifier.name },
|
|
})
|
|
}
|
|
})
|
|
},
|
|
}
|
|
},
|
|
}
|