Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
160 lines
4.9 KiB
JavaScript
160 lines
4.9 KiB
JavaScript
'use strict';
|
|
|
|
var $TypeError = require('es-errors/type');
|
|
var isObject = require('es-object-atoms/isObject');
|
|
|
|
var DefineOwnProperty = require('../helpers/DefineOwnProperty');
|
|
var isPropertyDescriptor = require('../helpers/records/property-descriptor');
|
|
var isSamePropertyDescriptor = require('../helpers/isSamePropertyDescriptor');
|
|
|
|
var FromPropertyDescriptor = require('./FromPropertyDescriptor');
|
|
var IsAccessorDescriptor = require('./IsAccessorDescriptor');
|
|
var IsDataDescriptor = require('./IsDataDescriptor');
|
|
var IsGenericDescriptor = require('./IsGenericDescriptor');
|
|
var isPropertyKey = require('../helpers/isPropertyKey');
|
|
var SameValue = require('./SameValue');
|
|
|
|
// https://262.ecma-international.org/6.0/#sec-validateandapplypropertydescriptor
|
|
// https://262.ecma-international.org/8.0/#sec-validateandapplypropertydescriptor
|
|
|
|
// eslint-disable-next-line max-lines-per-function, max-statements
|
|
module.exports = function ValidateAndApplyPropertyDescriptor(O, P, extensible, Desc, current) {
|
|
// this uses the ES2017+ logic, since it fixes a number of bugs in the ES2015 logic.
|
|
if (typeof O !== 'undefined' && !isObject(O)) {
|
|
throw new $TypeError('Assertion failed: O must be undefined or an Object');
|
|
}
|
|
if (typeof extensible !== 'boolean') {
|
|
throw new $TypeError('Assertion failed: extensible must be a Boolean');
|
|
}
|
|
if (!isPropertyDescriptor(Desc)) {
|
|
throw new $TypeError('Assertion failed: Desc must be a Property Descriptor');
|
|
}
|
|
if (typeof current !== 'undefined' && !isPropertyDescriptor(current)) {
|
|
throw new $TypeError('Assertion failed: current must be a Property Descriptor, or undefined');
|
|
}
|
|
if (typeof O !== 'undefined' && !isPropertyKey(P)) {
|
|
throw new $TypeError('Assertion failed: if O is not undefined, P must be a Property Key');
|
|
}
|
|
if (typeof current === 'undefined') {
|
|
if (!extensible) {
|
|
return false;
|
|
}
|
|
if (IsGenericDescriptor(Desc) || IsDataDescriptor(Desc)) {
|
|
if (typeof O !== 'undefined') {
|
|
DefineOwnProperty(
|
|
IsDataDescriptor,
|
|
SameValue,
|
|
FromPropertyDescriptor,
|
|
O,
|
|
P,
|
|
{
|
|
'[[Configurable]]': Desc['[[Configurable]]'],
|
|
'[[Enumerable]]': Desc['[[Enumerable]]'],
|
|
'[[Value]]': Desc['[[Value]]'],
|
|
'[[Writable]]': Desc['[[Writable]]']
|
|
}
|
|
);
|
|
}
|
|
} else {
|
|
if (!IsAccessorDescriptor(Desc)) {
|
|
throw new $TypeError('Assertion failed: Desc is not an accessor descriptor');
|
|
}
|
|
if (typeof O !== 'undefined') {
|
|
return DefineOwnProperty(
|
|
IsDataDescriptor,
|
|
SameValue,
|
|
FromPropertyDescriptor,
|
|
O,
|
|
P,
|
|
Desc
|
|
);
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
if (IsGenericDescriptor(Desc) && !('[[Configurable]]' in Desc) && !('[[Enumerable]]' in Desc)) {
|
|
return true;
|
|
}
|
|
if (isSamePropertyDescriptor({ SameValue: SameValue }, Desc, current)) {
|
|
return true; // removed by ES2017, but should still be correct
|
|
}
|
|
// "if every field in Desc is absent, return true" can't really match the assertion that it's a Property Descriptor
|
|
if (!current['[[Configurable]]']) {
|
|
if (Desc['[[Configurable]]']) {
|
|
return false;
|
|
}
|
|
if ('[[Enumerable]]' in Desc && !Desc['[[Enumerable]]'] === !!current['[[Enumerable]]']) {
|
|
return false;
|
|
}
|
|
}
|
|
if (IsGenericDescriptor(Desc)) {
|
|
// no further validation is required.
|
|
} else if (IsDataDescriptor(current) !== IsDataDescriptor(Desc)) {
|
|
if (!current['[[Configurable]]']) {
|
|
return false;
|
|
}
|
|
if (IsDataDescriptor(current)) {
|
|
if (typeof O !== 'undefined') {
|
|
DefineOwnProperty(
|
|
IsDataDescriptor,
|
|
SameValue,
|
|
FromPropertyDescriptor,
|
|
O,
|
|
P,
|
|
{
|
|
'[[Configurable]]': current['[[Configurable]]'],
|
|
'[[Enumerable]]': current['[[Enumerable]]'],
|
|
'[[Get]]': undefined
|
|
}
|
|
);
|
|
}
|
|
} else if (typeof O !== 'undefined') {
|
|
DefineOwnProperty(
|
|
IsDataDescriptor,
|
|
SameValue,
|
|
FromPropertyDescriptor,
|
|
O,
|
|
P,
|
|
{
|
|
'[[Configurable]]': current['[[Configurable]]'],
|
|
'[[Enumerable]]': current['[[Enumerable]]'],
|
|
'[[Value]]': undefined
|
|
}
|
|
);
|
|
}
|
|
} else if (IsDataDescriptor(current) && IsDataDescriptor(Desc)) {
|
|
if (!current['[[Configurable]]'] && !current['[[Writable]]']) {
|
|
if ('[[Writable]]' in Desc && Desc['[[Writable]]']) {
|
|
return false;
|
|
}
|
|
if ('[[Value]]' in Desc && !SameValue(Desc['[[Value]]'], current['[[Value]]'])) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
} else if (IsAccessorDescriptor(current) && IsAccessorDescriptor(Desc)) {
|
|
if (!current['[[Configurable]]']) {
|
|
if ('[[Set]]' in Desc && !SameValue(Desc['[[Set]]'], current['[[Set]]'])) {
|
|
return false;
|
|
}
|
|
if ('[[Get]]' in Desc && !SameValue(Desc['[[Get]]'], current['[[Get]]'])) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
} else {
|
|
throw new $TypeError('Assertion failed: current and Desc are not both data, both accessors, or one accessor and one data.');
|
|
}
|
|
if (typeof O !== 'undefined') {
|
|
return DefineOwnProperty(
|
|
IsDataDescriptor,
|
|
SameValue,
|
|
FromPropertyDescriptor,
|
|
O,
|
|
P,
|
|
Desc
|
|
);
|
|
}
|
|
return true;
|
|
};
|