tegwick
17c62aadaa
Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
55 lines
2.1 KiB
JavaScript
55 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
var $gOPD = require('gopd');
|
|
var $SyntaxError = require('es-errors/syntax');
|
|
var $TypeError = require('es-errors/type');
|
|
var isObject = require('es-object-atoms/isObject');
|
|
|
|
var isPropertyDescriptor = require('../helpers/records/property-descriptor');
|
|
|
|
var IsAccessorDescriptor = require('./IsAccessorDescriptor');
|
|
var IsExtensible = require('./IsExtensible');
|
|
var isPropertyKey = require('../helpers/isPropertyKey');
|
|
var ToPropertyDescriptor = require('./ToPropertyDescriptor');
|
|
var SameValue = require('./SameValue');
|
|
var ValidateAndApplyPropertyDescriptor = require('./ValidateAndApplyPropertyDescriptor');
|
|
|
|
// https://262.ecma-international.org/6.0/#sec-ordinarydefineownproperty
|
|
|
|
module.exports = function OrdinaryDefineOwnProperty(O, P, Desc) {
|
|
if (!isObject(O)) {
|
|
throw new $TypeError('Assertion failed: O must be an Object');
|
|
}
|
|
if (!isPropertyKey(P)) {
|
|
throw new $TypeError('Assertion failed: P must be a Property Key');
|
|
}
|
|
if (!isPropertyDescriptor(Desc)) {
|
|
throw new $TypeError('Assertion failed: Desc must be a Property Descriptor');
|
|
}
|
|
if (!$gOPD) {
|
|
// ES3/IE 8 fallback
|
|
if (IsAccessorDescriptor(Desc)) {
|
|
throw new $SyntaxError('This environment does not support accessor property descriptors.');
|
|
}
|
|
var creatingNormalDataProperty = !(P in O)
|
|
&& Desc['[[Writable]]']
|
|
&& Desc['[[Enumerable]]']
|
|
&& Desc['[[Configurable]]']
|
|
&& '[[Value]]' in Desc;
|
|
var settingExistingDataProperty = (P in O)
|
|
&& (!('[[Configurable]]' in Desc) || Desc['[[Configurable]]'])
|
|
&& (!('[[Enumerable]]' in Desc) || Desc['[[Enumerable]]'])
|
|
&& (!('[[Writable]]' in Desc) || Desc['[[Writable]]'])
|
|
&& '[[Value]]' in Desc;
|
|
if (creatingNormalDataProperty || settingExistingDataProperty) {
|
|
O[P] = Desc['[[Value]]']; // eslint-disable-line no-param-reassign
|
|
return SameValue(O[P], Desc['[[Value]]']);
|
|
}
|
|
throw new $SyntaxError('This environment does not support defining non-writable, non-enumerable, or non-configurable properties');
|
|
}
|
|
var desc = $gOPD(O, P);
|
|
var current = desc && ToPropertyDescriptor(desc);
|
|
var extensible = IsExtensible(O);
|
|
return ValidateAndApplyPropertyDescriptor(O, P, extensible, Desc, current);
|
|
};
|