tegwick
17c62aadaa
Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
52 lines
2.0 KiB
JavaScript
52 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
var $TypeError = require('es-errors/type');
|
|
|
|
var GeneratorStart = require('./GeneratorStart');
|
|
var IsArray = require('./IsArray');
|
|
var IsCallable = require('./IsCallable');
|
|
var OrdinaryObjectCreate = require('./OrdinaryObjectCreate');
|
|
|
|
var every = require('../helpers/every');
|
|
|
|
var SLOT = require('internal-slot');
|
|
var safeConcat = require('safe-array-concat');
|
|
var isObject = require('es-object-atoms/isObject');
|
|
|
|
var isString = function isString(slot) {
|
|
return typeof slot === 'string';
|
|
};
|
|
|
|
// https://262.ecma-international.org/16.0/#sec-createiteratorfromclosure
|
|
|
|
module.exports = function CreateIteratorFromClosure(closure, generatorBrand, generatorPrototype) {
|
|
if (!IsCallable(closure)) {
|
|
throw new $TypeError('`closure` must be a function');
|
|
}
|
|
if (typeof generatorBrand !== 'string') {
|
|
throw new $TypeError('`generatorBrand` must be a string');
|
|
}
|
|
if (!isObject(generatorPrototype)) {
|
|
throw new $TypeError('`generatorPrototype` must be an object');
|
|
}
|
|
var extraSlots = arguments.length > 3 ? arguments[3] : []; // step 2
|
|
if (arguments.length > 3) {
|
|
if (!IsArray(extraSlots) || !every(extraSlots, isString)) {
|
|
throw new $TypeError('`extraSlots` must be a List of String internal slot names');
|
|
}
|
|
}
|
|
var internalSlotsList = safeConcat(extraSlots, ['[[GeneratorContext]]', '[[GeneratorBrand]]', '[[GeneratorState]]']); // step 3
|
|
var generator = OrdinaryObjectCreate(generatorPrototype, internalSlotsList); // steps 4, 6
|
|
SLOT.set(generator, '[[GeneratorBrand]]', generatorBrand); // step 5
|
|
SLOT.set(generator, '[[GeneratorState]]', 'SUSPENDED-START'); // step 6
|
|
|
|
SLOT.assert(closure, '[[Sentinel]]'); // our userland slot
|
|
SLOT.set(generator, '[[Sentinel]]', SLOT.get(closure, '[[Sentinel]]')); // our userland slot
|
|
SLOT.assert(closure, '[[CloseIfAbrupt]]'); // our second userland slot
|
|
SLOT.set(generator, '[[CloseIfAbrupt]]', SLOT.get(closure, '[[CloseIfAbrupt]]')); // our second userland slot
|
|
|
|
GeneratorStart(generator, closure); // step 14
|
|
|
|
return generator; // step 16
|
|
};
|