Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
72 lines
1.9 KiB
JavaScript
72 lines
1.9 KiB
JavaScript
/**
|
|
* Rule: no-callback-in-promise
|
|
* Avoid calling back inside of a promise
|
|
*/
|
|
|
|
'use strict'
|
|
|
|
const { getAncestors } = require('./lib/eslint-compat')
|
|
const getDocsUrl = require('./lib/get-docs-url')
|
|
const hasPromiseCallback = require('./lib/has-promise-callback')
|
|
const isInsidePromise = require('./lib/is-inside-promise')
|
|
const isCallback = require('./lib/is-callback')
|
|
|
|
const CB_BLACKLIST = ['callback', 'cb', 'next', 'done']
|
|
|
|
module.exports = {
|
|
meta: {
|
|
type: 'suggestion',
|
|
docs: {
|
|
description:
|
|
'Disallow calling `cb()` inside of a `then()` (use [nodeify][] instead).',
|
|
url: getDocsUrl('no-callback-in-promise'),
|
|
},
|
|
messages: {
|
|
callback: 'Avoid calling back inside of a promise.',
|
|
},
|
|
schema: [
|
|
{
|
|
type: 'object',
|
|
properties: {
|
|
exceptions: {
|
|
type: 'array',
|
|
items: {
|
|
type: 'string',
|
|
},
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
},
|
|
create(context) {
|
|
return {
|
|
CallExpression(node) {
|
|
const options = context.options[0] || {}
|
|
const exceptions = options.exceptions || []
|
|
if (!isCallback(node, exceptions)) {
|
|
// in general we send you packing if you're not a callback
|
|
// but we also need to watch out for whatever.then(cb)
|
|
if (hasPromiseCallback(node)) {
|
|
const name =
|
|
node.arguments && node.arguments[0] && node.arguments[0].name
|
|
if (!exceptions.includes(name) && CB_BLACKLIST.includes(name)) {
|
|
context.report({
|
|
node: node.arguments[0],
|
|
messageId: 'callback',
|
|
})
|
|
}
|
|
}
|
|
return
|
|
}
|
|
if (getAncestors(context, node).some(isInsidePromise)) {
|
|
context.report({
|
|
node,
|
|
messageId: 'callback',
|
|
})
|
|
}
|
|
},
|
|
}
|
|
},
|
|
}
|