Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
124 lines
3.2 KiB
JavaScript
124 lines
3.2 KiB
JavaScript
/**
|
|
* Rule: no-nesting
|
|
* Avoid nesting your promises.
|
|
*/
|
|
|
|
'use strict'
|
|
|
|
const { getScope } = require('./lib/eslint-compat')
|
|
const getDocsUrl = require('./lib/get-docs-url')
|
|
const hasPromiseCallback = require('./lib/has-promise-callback')
|
|
const isInsidePromise = require('./lib/is-inside-promise')
|
|
|
|
module.exports = {
|
|
meta: {
|
|
type: 'suggestion',
|
|
docs: {
|
|
description: 'Disallow nested `then()` or `catch()` statements.',
|
|
url: getDocsUrl('no-nesting'),
|
|
},
|
|
schema: [],
|
|
messages: {
|
|
avoidNesting: 'Avoid nesting promises.',
|
|
},
|
|
},
|
|
create(context) {
|
|
/**
|
|
* Array of callback function scopes.
|
|
* Scopes are in order closest to the current node.
|
|
* @type {import('eslint').Scope.Scope[]}
|
|
*/
|
|
const callbackScopes = []
|
|
|
|
/**
|
|
* @param {import('eslint').Scope.Scope} scope
|
|
* @returns {Iterable<import('eslint').Scope.Reference>}
|
|
*/
|
|
function* iterateDefinedReferences(scope) {
|
|
for (const variable of scope.variables) {
|
|
for (const reference of variable.references) {
|
|
yield reference
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
':function'(node) {
|
|
if (isInsidePromise(node)) {
|
|
callbackScopes.unshift(getScope(context, node))
|
|
}
|
|
},
|
|
':function:exit'(node) {
|
|
if (isInsidePromise(node)) {
|
|
callbackScopes.shift()
|
|
}
|
|
},
|
|
CallExpression(node) {
|
|
if (!hasPromiseCallback(node)) return
|
|
if (!callbackScopes.length) {
|
|
// The node is not in the callback function.
|
|
return
|
|
}
|
|
|
|
// Checks if the argument callback uses variables defined in the closest callback function scope.
|
|
//
|
|
// e.g.
|
|
// ```
|
|
// doThing()
|
|
// .then(a => getB(a)
|
|
// .then(b => getC(a, b))
|
|
// )
|
|
// ```
|
|
//
|
|
// In the above case, Since the variables it references are undef,
|
|
// we cannot refactor the nesting like following:
|
|
// ```
|
|
// doThing()
|
|
// .then(a => getB(a))
|
|
// .then(b => getC(a, b))
|
|
// ```
|
|
//
|
|
// However, `getD` can be refactored in the following:
|
|
// ```
|
|
// doThing()
|
|
// .then(a => getB(a)
|
|
// .then(b => getC(a, b)
|
|
// .then(c => getD(a, c))
|
|
// )
|
|
// )
|
|
// ```
|
|
// ↓
|
|
// ```
|
|
// doThing()
|
|
// .then(a => getB(a)
|
|
// .then(b => getC(a, b))
|
|
// .then(c => getD(a, c))
|
|
// )
|
|
// ```
|
|
// This is why we only check the closest callback function scope.
|
|
//
|
|
const closestCallbackScope = callbackScopes[0]
|
|
for (const reference of iterateDefinedReferences(
|
|
closestCallbackScope
|
|
)) {
|
|
if (
|
|
node.arguments.some(
|
|
(arg) =>
|
|
arg.range[0] <= reference.identifier.range[0] &&
|
|
reference.identifier.range[1] <= arg.range[1]
|
|
)
|
|
) {
|
|
// Argument callbacks refer to variables defined in the callback function.
|
|
return
|
|
}
|
|
}
|
|
|
|
context.report({
|
|
node: node.callee.property,
|
|
messageId: 'avoidNesting',
|
|
})
|
|
},
|
|
}
|
|
},
|
|
}
|