Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
98 lines
3.0 KiB
JavaScript
98 lines
3.0 KiB
JavaScript
'use strict'
|
|
|
|
const { getAncestors } = require('./lib/eslint-compat')
|
|
const getDocsUrl = require('./lib/get-docs-url')
|
|
|
|
module.exports = {
|
|
meta: {
|
|
type: 'suggestion',
|
|
docs: {
|
|
description: 'Prefer `async`/`await` to the callback pattern.',
|
|
url: getDocsUrl('prefer-await-to-callbacks'),
|
|
},
|
|
messages: {
|
|
error: 'Avoid callbacks. Prefer Async/Await.',
|
|
},
|
|
schema: [],
|
|
},
|
|
create(context) {
|
|
function checkLastParamsForCallback(node) {
|
|
const lastParam = node.params[node.params.length - 1] || {}
|
|
if (lastParam.name === 'callback' || lastParam.name === 'cb') {
|
|
context.report({ node: lastParam, messageId: 'error' })
|
|
}
|
|
}
|
|
function isInsideYieldOrAwait(node) {
|
|
return getAncestors(context, node).some((parent) => {
|
|
return (
|
|
parent.type === 'AwaitExpression' || parent.type === 'YieldExpression'
|
|
)
|
|
})
|
|
}
|
|
return {
|
|
CallExpression(node) {
|
|
// Callbacks aren't allowed.
|
|
if (node.callee.name === 'cb' || node.callee.name === 'callback') {
|
|
context.report({ node, messageId: 'error' })
|
|
return
|
|
}
|
|
|
|
// Then-ables aren't allowed either.
|
|
const args = node.arguments
|
|
const lastArgIndex = args.length - 1
|
|
const arg = lastArgIndex > -1 && node.arguments[lastArgIndex]
|
|
if (
|
|
(arg && arg.type === 'FunctionExpression') ||
|
|
arg.type === 'ArrowFunctionExpression'
|
|
) {
|
|
// Ignore event listener callbacks.
|
|
if (
|
|
node.callee.property &&
|
|
(node.callee.property.name === 'on' ||
|
|
node.callee.property.name === 'once')
|
|
) {
|
|
return
|
|
}
|
|
|
|
// carve out exemption for map/filter/etc
|
|
const arrayMethods = [
|
|
'map',
|
|
'every',
|
|
'forEach',
|
|
'some',
|
|
'find',
|
|
'filter',
|
|
]
|
|
const isLodash =
|
|
node.callee.object &&
|
|
['lodash', 'underscore', '_'].includes(node.callee.object.name)
|
|
const callsArrayMethod =
|
|
node.callee.property &&
|
|
arrayMethods.includes(node.callee.property.name) &&
|
|
(node.arguments.length === 1 ||
|
|
(node.arguments.length === 2 && isLodash))
|
|
const isArrayMethod =
|
|
node.callee.name &&
|
|
arrayMethods.includes(node.callee.name) &&
|
|
node.arguments.length === 2
|
|
if (callsArrayMethod || isArrayMethod) return
|
|
|
|
// actually check for callbacks (I know this is the worst)
|
|
if (
|
|
arg.params &&
|
|
arg.params[0] &&
|
|
(arg.params[0].name === 'err' || arg.params[0].name === 'error')
|
|
) {
|
|
if (!isInsideYieldOrAwait(node)) {
|
|
context.report({ node: arg, messageId: 'error' })
|
|
}
|
|
}
|
|
}
|
|
},
|
|
FunctionDeclaration: checkLastParamsForCallback,
|
|
FunctionExpression: checkLastParamsForCallback,
|
|
ArrowFunctionExpression: checkLastParamsForCallback,
|
|
}
|
|
},
|
|
}
|