generated from coulomb/repo-seed
tegwick
365c0d611a
Implements the full BRIDGE-WP-0003 workplan: 188 tests passing, 0 lint errors. ## What's added **Capability registry** (`src/bridge/capabilities.py`): - 10 capabilities with required_access_modes (cli/mcp/skill) - Single source of truth for what OpsBridge does and where **MCP server** (`src/bridge/mcp_server/server.py`): - 10 FastMCP tools: bridge_up/down/restart/status/logs + 5 catalog_* tools - 3 resources: bridge://status, catalog://domains, catalog://targets - `.mcp.json` for project-scope auto-registration - `scripts/register_mcp.py` for user-scope machine-global registration **Skill** (`~/.claude/plugins/ops-bridge/bridge-status.md`): - /bridge-status: health table with emoji indicators + remediation advice **Cross-mode test coverage enforcement**: - `tests/conftest.py`: capability/access_mode marks + collect_capability_coverage() - `tests/test_mcp.py`: 31 FastMCP in-process client tests (Client(mcp) pattern) - `tests/test_skill.py`: static skill lint against capability registry - `tests/test_coverage_completeness.py`: meta-test that fails if any required (capability × mode) pair lacks a test; also validates CLI commands and MCP tools are registered in the capability registry **ADR** (`architecture/adr-001-cross-mode-capability-registry.md`): - Documents the registry pattern and FastMCP 3.x testing approach Key implementation note: FastMCP 3.x in-process results are in result.content[0].text (JSON string), not result.data directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
89 lines
3.1 KiB
Python
89 lines
3.1 KiB
Python
"""Tests for catalog resolver."""
|
|
import pytest
|
|
from bridge.catalog.models import (
|
|
ActorClass,
|
|
Catalog,
|
|
CatalogBridge,
|
|
CatalogDomain,
|
|
CatalogTarget,
|
|
)
|
|
from bridge.catalog.resolver import BridgeNotFound, resolve
|
|
from bridge.models import TunnelConfig, ReconnectPolicy
|
|
|
|
|
|
@pytest.fixture
|
|
def catalog():
|
|
cat = Catalog()
|
|
cat.domains["d"] = CatalogDomain(id="d", name="D")
|
|
cat.targets["t"] = CatalogTarget(id="t", domain="d", kind="service")
|
|
cat.bridges["catalog-bridge"] = CatalogBridge(
|
|
id="catalog-bridge",
|
|
domain="d",
|
|
target="t",
|
|
host="catalog-host.local",
|
|
remote_port=19000,
|
|
local_port=9000,
|
|
ssh_user="ubuntu",
|
|
ssh_key="~/.ssh/catalog",
|
|
actor="operator.bernd",
|
|
)
|
|
cat.actors["operator.bernd"] = ActorClass(id="operator.bernd", actor_class="human")
|
|
return cat
|
|
|
|
|
|
@pytest.fixture
|
|
def inline_tunnels():
|
|
return {
|
|
"inline-bridge": TunnelConfig(
|
|
name="inline-bridge",
|
|
host="inline-host.local",
|
|
remote_port=18000,
|
|
local_port=8000,
|
|
ssh_user="ubuntu",
|
|
ssh_key="~/.ssh/inline",
|
|
actor="operator.bernd",
|
|
)
|
|
}
|
|
|
|
|
|
class TestResolve:
|
|
def test_inline_takes_precedence(self, catalog, inline_tunnels):
|
|
tc = resolve("inline-bridge", catalog=catalog, inline_tunnels=inline_tunnels)
|
|
assert tc.host == "inline-host.local"
|
|
|
|
def test_catalog_fallback(self, catalog, inline_tunnels):
|
|
tc = resolve("catalog-bridge", catalog=catalog, inline_tunnels=inline_tunnels)
|
|
assert tc.host == "catalog-host.local"
|
|
assert tc.remote_port == 19000
|
|
|
|
def test_catalog_fallback_no_inline(self, catalog):
|
|
tc = resolve("catalog-bridge", catalog=catalog, inline_tunnels={})
|
|
assert tc.name == "catalog-bridge"
|
|
|
|
def test_missing_name_raises(self, catalog, inline_tunnels):
|
|
with pytest.raises(BridgeNotFound, match="nonexistent"):
|
|
resolve("nonexistent", catalog=catalog, inline_tunnels=inline_tunnels)
|
|
|
|
def test_missing_name_no_catalog_raises(self, inline_tunnels):
|
|
with pytest.raises(BridgeNotFound):
|
|
resolve("nonexistent", catalog=None, inline_tunnels=inline_tunnels)
|
|
|
|
def test_inline_bridge_returns_tunnel_config(self, catalog, inline_tunnels):
|
|
tc = resolve("inline-bridge", catalog=catalog, inline_tunnels=inline_tunnels)
|
|
assert isinstance(tc, TunnelConfig)
|
|
|
|
def test_catalog_bridge_returns_tunnel_config(self, catalog):
|
|
tc = resolve("catalog-bridge", catalog=catalog, inline_tunnels={})
|
|
assert isinstance(tc, TunnelConfig)
|
|
|
|
def test_catalog_is_none_no_inline_raises(self):
|
|
with pytest.raises(BridgeNotFound):
|
|
resolve("any-name", catalog=None, inline_tunnels={})
|
|
|
|
def test_resolve_preserves_reconnect_policy(self, catalog):
|
|
catalog.bridges["catalog-bridge"].reconnect = ReconnectPolicy(
|
|
max_attempts=3, backoff_initial=2, backoff_max=30
|
|
)
|
|
tc = resolve("catalog-bridge", catalog=catalog, inline_tunnels={})
|
|
assert tc.reconnect.max_attempts == 3
|