generated from coulomb/repo-seed
Expose review decision audit metadata
This commit is contained in:
@@ -125,6 +125,13 @@ def test_agentic_reviewer_can_approve_candidate_graph_with_rationale(tmp_path):
|
||||
assert ability_map.abilities
|
||||
assert graph.abilities[0].status == "approved"
|
||||
assert decisions[1].action == "agentic_approve_candidate_graph"
|
||||
assert decisions[1].reviewer_type == "agent"
|
||||
assert decisions[1].reviewer_id == "approving-agent"
|
||||
assert decisions[1].policy_version == "agentic-review-policy/test"
|
||||
assert decisions[1].criteria_version == "repo-scoping-quality-criteria/v1"
|
||||
assert decisions[1].criterion_ids == ["RREG-QC-004"]
|
||||
assert decisions[1].evidence_refs == ["README.md", "app.py"]
|
||||
assert decisions[1].decision_kind == "accepted_as_is"
|
||||
assert "rationale=API source and README support" in decisions[1].notes
|
||||
assert "criteria=RREG-QC-004" in decisions[1].notes
|
||||
assert "evidence=README.md, app.py" in decisions[1].notes
|
||||
|
||||
@@ -129,3 +129,5 @@ def test_export_assessment_review_decisions_include_quality_criteria_version(tmp
|
||||
assert artifact["review_decisions"][0]["quality_criteria_version"] == (
|
||||
"repo-scoping-quality-criteria/v1"
|
||||
)
|
||||
assert artifact["review_decisions"][0]["reviewer_type"] == "human"
|
||||
assert artifact["review_decisions"][0]["decision_kind"] == "accepted_as_is"
|
||||
|
||||
@@ -1038,6 +1038,8 @@ def test_api_analysis_run_loop(tmp_path):
|
||||
decisions_response = client.get(f"/repos/{repository_id}/review-decisions")
|
||||
assert decisions_response.status_code == 200
|
||||
assert decisions_response.json()[0]["action"] == "reject_candidate_ability"
|
||||
assert decisions_response.json()[0]["reviewer_type"] == "human"
|
||||
assert decisions_response.json()[0]["decision_kind"] == "rejected"
|
||||
run_decisions_response = client.get(
|
||||
f"/repos/{repository_id}/analysis-runs/"
|
||||
f"{run['analysis_run']['id']}/review-decisions"
|
||||
|
||||
Reference in New Issue
Block a user