candidates can now be edited before approval

This commit is contained in:
2026-04-25 23:32:18 +02:00
parent 5503b9761e
commit d5869bcaeb
6 changed files with 357 additions and 5 deletions

View File

@@ -243,6 +243,56 @@ def test_reject_candidate_ability_excludes_it_from_approval(tmp_path):
assert ability_map.abilities == []
def test_edit_candidate_graph_values_before_approval(tmp_path):
source = tmp_path / "repo"
source.mkdir()
(source / "README.md").write_text("# Editable\n", encoding="utf-8")
(source / "app.py").write_text(
"from fastapi import FastAPI\n"
"app = FastAPI()\n"
'@app.get("/health")\n'
"def health():\n"
" return {}\n",
encoding="utf-8",
)
service = make_service(tmp_path)
repository = service.register_repository(name="Editable", url=str(source))
summary = service.analyze_repository(repository.id)
graph = service.candidate_graph(repository.id, summary.analysis_run.id)
candidate_ability = graph.abilities[0]
candidate_capability = candidate_ability.capabilities[0]
service.edit_candidate_ability(
repository.id,
summary.analysis_run.id,
candidate_ability.id,
name="Service Health Monitoring",
description="Expose health state for operational monitoring.",
confidence=0.91,
notes="Curator renamed the generic ability.",
)
service.edit_candidate_capability(
repository.id,
summary.analysis_run.id,
candidate_capability.id,
name="Report HTTP Health",
description="Return a lightweight health response over HTTP.",
confidence=0.87,
)
ability_map = service.approve_candidate_graph(repository.id, summary.analysis_run.id)
assert service.get_repository(repository.id).status == "indexed"
assert ability_map.abilities[0].name == "Service Health Monitoring"
assert ability_map.abilities[0].description == (
"Expose health state for operational monitoring."
)
assert ability_map.abilities[0].confidence == 0.91
assert ability_map.abilities[0].capabilities[0].name == "Report HTTP Health"
assert ability_map.abilities[0].capabilities[0].confidence == 0.87
def test_analyze_repository_failure_is_recorded(tmp_path):
service = make_service(tmp_path)
repository = service.register_repository(

View File

@@ -139,6 +139,7 @@ def test_api_analysis_run_loop(tmp_path):
"Review Frontend Repository Usefulness"
)
candidate_ability_id = candidate_graph["abilities"][0]["id"]
candidate_capability_id = candidate_graph["abilities"][0]["capabilities"][0]["id"]
reject_response = client.post(
f"/repos/{repository_id}/analysis-runs/"
@@ -152,6 +153,41 @@ def test_api_analysis_run_loop(tmp_path):
run_response = client.post(f"/repos/{repository_id}/analysis-runs", json={})
assert run_response.status_code == 201
run = run_response.json()
candidate_response = client.get(
f"/repos/{repository_id}/analysis-runs/"
f"{run['analysis_run']['id']}/candidate-graph"
)
candidate_graph = candidate_response.json()
candidate_ability_id = candidate_graph["abilities"][0]["id"]
candidate_capability_id = candidate_graph["abilities"][0]["capabilities"][0]["id"]
ability_edit_response = client.patch(
f"/repos/{repository_id}/analysis-runs/"
f"{run['analysis_run']['id']}/candidate-abilities/"
f"{candidate_ability_id}",
json={
"name": "Frontend Delivery",
"description": "Serve a browser frontend.",
"confidence": 0.9,
"notes": "API edit test",
},
)
assert ability_edit_response.status_code == 200
assert ability_edit_response.json()["abilities"][0]["name"] == (
"Frontend Delivery"
)
capability_edit_response = client.patch(
f"/repos/{repository_id}/analysis-runs/"
f"{run['analysis_run']['id']}/candidate-capabilities/"
f"{candidate_capability_id}",
json={
"name": "Describe Frontend Stack",
"description": "Capture React and Vite usage.",
"confidence": 0.8,
},
)
assert capability_edit_response.status_code == 200
approve_response = client.post(
f"/repos/{repository_id}/analysis-runs/"
@@ -161,11 +197,12 @@ def test_api_analysis_run_loop(tmp_path):
assert approve_response.status_code == 200
ability_map = approve_response.json()
assert ability_map["repository"]["status"] == "indexed"
assert ability_map["abilities"][0]["name"] == (
"Review Frontend Repository Usefulness"
assert ability_map["abilities"][0]["name"] == "Frontend Delivery"
assert ability_map["abilities"][0]["capabilities"][0]["name"] == (
"Describe Frontend Stack"
)
search_response = client.get("/search", params={"q": "structure"})
search_response = client.get("/search", params={"q": "frontend"})
assert search_response.status_code == 200
assert search_response.json()