Complete workplan state model cleanup

tests/test_routers_core.py

@@ -109,9 +109,18 @@ class TestWorkstreams:
         topic = await _create_topic(client)
         ws = await _create_workstream(client, topic["id"])
 
+        r = await client.patch(f"/workstreams/{ws['id']}", json={"status": "finished"})
+        assert r.status_code == 200
+        assert r.json()["status"] == "finished"
+
+    async def test_legacy_completed_status_is_normalized(self, client):
+        await _create_domain(client)
+        topic = await _create_topic(client)
+        ws = await _create_workstream(client, topic["id"])
+
         r = await client.patch(f"/workstreams/{ws['id']}", json={"status": "completed"})
         assert r.status_code == 200
-        assert r.json()["status"] == "completed"
+        assert r.json()["status"] == "finished"
 
     async def test_filter_by_owner(self, client):
         await _create_domain(client)
@@ -321,11 +330,11 @@ class TestFlowEndpoints:
 
         r = await client.get(f"/flows/workstream/{ws['id']}")
         assert r.status_code == 200
-        assert "completed" in r.json()["reachable"]
+        assert "finished" in r.json()["reachable"]
 
-        r = await client.post(f"/flows/workstream/{ws['id']}/advance/completed")
+        r = await client.post(f"/flows/workstream/{ws['id']}/advance/finished")
         assert r.status_code == 200
-        assert r.json()["current_workstation"] == "completed"
+        assert r.json()["current_workstation"] == "finished"
 
         r = await client.get(f"/workstreams/{ws['id']}")
-        assert r.json()["status"] == "completed"
+        assert r.json()["status"] == "finished"