Files

tegwick 2dfbb19a8f feat(workplans): CUST-WP-0018/0019/0020 — API hardening, dashboard UX polish, test suite

Consolidates all open technical debt into three workplans:
- CUST-WP-0018: API hardening & code quality (TD-006–019 medium/high items)
- CUST-WP-0019: Dashboard UX polish (Repos nav restructure, config.js cleanup,
  todo filter fix for new suggestion workflow statuses)
- CUST-WP-0020: pytest test suite with real DB (TD-014)

Also fixes todo.md Suggestions filter: was checking status===open but new
suggestions enter with status=submitted; now excludes terminal statuses only.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-03-18 01:55:37 +01:00

3.0 KiB

Raw Blame History

id, type, title, domain, status, owner, topic_slug, created, updated

id	type	title	domain	status	owner	topic_slug	created	updated
CUST-WP-0020	workplan	State Hub — pytest Test Suite	custodian	active	custodian	custodian	2026-03-18	2026-03-18

State Hub — pytest Test Suite

Summary

The API, MCP server, seed script, and migration scripts currently have zero automated test coverage (TD-CUST-014). Regressions are caught at runtime. This workplan introduces a pytest-asyncio test suite using HTTPX's async test client against a real test database (no mocking — see ADR below).

ADR

Do NOT mock the database in these tests. The state-hub has had past incidents where mocked tests passed but the real DB diverged (see memory: feedback on not mocking the database). Use a real PostgreSQL test database via TEST_DATABASE_URL env var (docker-compose already provides postgres).

Tasks

T01 — Test infrastructure: pytest-asyncio + async HTTP client + fixtures

id: CUST-WP-0020-T01
status: todo
priority: high

Add pytest, pytest-asyncio, httpx to state-hub/pyproject.toml dev deps
Create state-hub/tests/conftest.py:
- engine fixture: creates a fresh async engine against TEST_DATABASE_URL
- db fixture: runs alembic upgrade head then alembic downgrade base around each test session (or truncates tables between tests)
- client fixture: httpx.AsyncClient pointed at the test app instance
Create state-hub/tests/__init__.py
Add make test target in state-hub/Makefile

T02 — Core router tests: topics, workstreams, tasks, decisions

id: CUST-WP-0020-T02
status: todo
priority: high

Coverage targets (happy path + key error cases):

POST /topics/ → 201, duplicate slug → 409
POST /workstreams/ + GET /workstreams/?topic_id= + status transitions
POST /tasks/ + GET /tasks/?workstream_id= + needs_human flag
POST /decisions/ + PATCH /{id}/resolve/
GET /state/summary → returns expected shape with counts

T03 — TD, EP, contributions router tests

id: CUST-WP-0020-T03
status: todo
priority: medium

TD CRUD + workflow status transitions + notes endpoints
EP CRUD + status transitions
Contribution lifecycle guard (invalid transitions → 422)
SBOM ingest + /sbom/snapshots/ aggregation

T04 — MCP server smoke tests

id: CUST-WP-0020-T04
status: todo
priority: medium

For each MCP tool, call the underlying HTTP helper against the test client and assert the result shape. No need to test the MCP stdio protocol itself — just the HTTP-level correctness. Focus on: get_state_summary, create_task, update_task_status, add_progress_event, flag_for_human.

T05 — CI: add pytest to pre-commit or Makefile gate

id: CUST-WP-0020-T05
status: todo
priority: low

Add make test as a step in any existing CI pipeline, or document the manual pre-push gate in CLAUDE.md. Ensure TEST_DATABASE_URL is set to the docker-compose postgres instance in the local dev workflow.

3.0 KiB Raw Blame History