coulomb/markitect-main
2
0
Fork 0
Code Issues 60 Pull Requests Actions 1 Projects 12 Releases 1 Wiki Activity

fix: improve CLI test robustness for virtual environment scenarios

Browse Source 
Enhanced test_cli_consolidation.py to handle cases where virtual environment
is not activated:

- test_all_cli_commands_installed: Check venv bin directory as fallback when
  CLI commands not found in PATH
- test_cli_help_commands_work: Use python -m module execution as fallback
  when direct command execution fails

These improvements make the test suite more resilient to PATH configuration
issues while maintaining proper validation of CLI installation.

Addresses real-world scenario where tests run without activated venv.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Bernd Worsch
2025-10-12 19:55:57 +02:00
parent c51bd276d6
commit 88787d903d
1 changed files with 46 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/test_cli_consolidation.py
View File

@@ -32,6 +32,20 @@ class TestCLIConsolidation:
tddai_path = shutil.which("tddai")
issue_path = shutil.which("issue")
# If not found in PATH, check if we're in a virtual environment
if markitect_path is None or tddai_path is None or issue_path is None:
# Check if we're in a virtual environment
venv_path = sys.prefix
if hasattr(sys, 'real_prefix') or (hasattr(sys, 'base_prefix') and sys.base_prefix != sys.prefix):
# We're in a virtual environment, check the bin directory
venv_bin = Path(venv_path) / "bin"
if not markitect_path:
markitect_path = venv_bin / "markitect" if (venv_bin / "markitect").exists() else None
if not tddai_path:
tddai_path = venv_bin / "tddai" if (venv_bin / "tddai").exists() else None
if not issue_path:
issue_path = venv_bin / "issue" if (venv_bin / "issue").exists() else None
assert markitect_path is not None, "markitect CLI command not found - check pyproject.toml scripts"
assert tddai_path is not None, "tddai CLI command not found - check pyproject.toml scripts"
assert issue_path is not None, "issue CLI command not found - check pyproject.toml scripts"
@@ -42,6 +56,7 @@ class TestCLIConsolidation:
for cmd in cli_commands:
try:
# Try direct command first
result = subprocess.run(
[cmd, "--help"],
capture_output=True,
@@ -51,10 +66,39 @@ class TestCLIConsolidation:
assert result.returncode == 0, f"{cmd} --help failed with exit code {result.returncode}"
assert len(result.stdout) > 100, f"{cmd} --help produced minimal output: {result.stdout[:200]}"
except FileNotFoundError:
# Fallback: try running via python -m if command not found in PATH
try:
if cmd == "markitect":
result = subprocess.run(
[sys.executable, "-m", "markitect.cli", "--help"],
capture_output=True,
text=True,
timeout=30
)
elif cmd == "tddai":
result = subprocess.run(
[sys.executable, "-m", "tddai_cli", "--help"],
capture_output=True,
text=True,
timeout=30
)
elif cmd == "issue":
result = subprocess.run(
[sys.executable, "-m", "cli.issue_cli", "--help"],
capture_output=True,
text=True,
timeout=30
)
assert result.returncode == 0, f"{cmd} --help failed with exit code {result.returncode}"
assert len(result.stdout) > 100, f"{cmd} --help produced minimal output: {result.stdout[:200]}"
except subprocess.TimeoutExpired:
pytest.fail(f"{cmd} --help timed out")
except FileNotFoundError:
pytest.fail(f"{cmd} command not found and module execution failed")
except subprocess.TimeoutExpired:
pytest.fail(f"{cmd} --help timed out")
except FileNotFoundError:
pytest.fail(f"{cmd} command not found")
def test_markitect_focuses_on_documents(self):
"""Verify markitect CLI focuses on document processing, not issues."""