Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
101 lines
3.0 KiB
JavaScript
101 lines
3.0 KiB
JavaScript
'use strict';
|
|
|
|
var test = require('tape');
|
|
var mockProperty = require('mock-property');
|
|
var hasSymbols = require('has-symbols/shams')();
|
|
var isConcatSpreadable = hasSymbols && Symbol.isConcatSpreadable;
|
|
var species = hasSymbols && Symbol.species;
|
|
|
|
var boundFnsHaveConfigurableLengths = require('set-function-length/env').boundFnsHaveConfigurableLengths;
|
|
|
|
var safeConcat = require('../');
|
|
|
|
test('safe-array-concat', function (t) {
|
|
t.equal(typeof safeConcat, 'function', 'is a function');
|
|
t.equal(
|
|
safeConcat.length,
|
|
boundFnsHaveConfigurableLengths ? 1 : 0,
|
|
'has a length of ' + (boundFnsHaveConfigurableLengths ? 1 : '0 (function lengths are not configurable)')
|
|
);
|
|
|
|
t.deepEqual(
|
|
// eslint-disable-next-line no-extra-parens
|
|
safeConcat(/** @type {(string | number | number[])[]} */ ([1, 2]), [3, 4], 'foo', 5, 6, [[7]]),
|
|
[1, 2, 3, 4, 'foo', 5, 6, [7]],
|
|
'works with flat and nested arrays'
|
|
);
|
|
|
|
t.deepEqual(
|
|
safeConcat(undefined, 1, 2),
|
|
[undefined, 1, 2],
|
|
'first item as undefined is not the concat receiver, which would throw via ToObject'
|
|
);
|
|
t.deepEqual(
|
|
safeConcat(null, 1, 2),
|
|
[null, 1, 2],
|
|
'first item as null is not the concat receiver, which would throw via ToObject'
|
|
);
|
|
|
|
var arr = [1, 2];
|
|
arr.constructor = function C() {
|
|
return { args: arguments };
|
|
};
|
|
t.deepEqual(
|
|
safeConcat(arr, 3, 4),
|
|
[1, 2, 3, 4],
|
|
'first item as an array with a nonArray .constructor; ignores constructor'
|
|
);
|
|
|
|
t.test('has Symbol.species', { skip: !species }, function (st) {
|
|
var speciesArr = [1, 2];
|
|
// @ts-expect-error ts(2740) TS's `constructor` type requires a function
|
|
speciesArr.constructor = {};
|
|
// @ts-expect-error ts(2538) TS can't type narrow from tape's `skip`
|
|
speciesArr.constructor[species] = function Species() {
|
|
return { args: arguments };
|
|
};
|
|
|
|
st.deepEqual(
|
|
safeConcat(speciesArr, 3, 4),
|
|
[1, 2, 3, 4],
|
|
'first item as an array with a .constructor object with a Symbol.species; ignores constructor and species'
|
|
);
|
|
|
|
st.end();
|
|
});
|
|
|
|
t.test('has isConcatSpreadable', { skip: !isConcatSpreadable }, function (st) {
|
|
// TS can't type narrow from tape's `skip`
|
|
if (isConcatSpreadable) {
|
|
st.teardown(mockProperty(
|
|
// eslint-disable-next-line no-extra-parens
|
|
/** @type {Record<PropertyKey, unknown>} */ (/** @type {unknown} */ (String.prototype)),
|
|
isConcatSpreadable,
|
|
{ value: true }
|
|
));
|
|
|
|
var nonSpreadable = [1, 2];
|
|
// @ts-expect-error ts(7015) TS can't handle expandos on an array
|
|
nonSpreadable[isConcatSpreadable] = false;
|
|
|
|
st.deepEqual(
|
|
safeConcat(nonSpreadable, 3, 4, 'foo', Object('bar')),
|
|
[1, 2, 3, 4, 'foo', Object('bar')],
|
|
'a non-concat-spreadable array is spreaded, and a concat-spreadable String is not spreaded'
|
|
);
|
|
|
|
st.teardown(mockProperty(Array.prototype, isConcatSpreadable, { value: false }));
|
|
|
|
st.deepEqual(
|
|
safeConcat([1, 2], 3, 4, 'foo', Object('bar')),
|
|
[1, 2, 3, 4, 'foo', Object('bar')],
|
|
'all arrays marked non-concat-spreadable are still spreaded, and a concat-spreadable String is not spreaded'
|
|
);
|
|
}
|
|
|
|
st.end();
|
|
});
|
|
|
|
t.end();
|
|
});
|