Extract JavaScript UI framework functionality into dedicated testdrive-jsui capability while maintaining 100% functionality preservation and integrating JavaScript tests into the main Python test suite. Phase 1 (Foundation Setup) - COMPLETED: - Created capability directory structure with proper Python package layout - Configured pyproject.toml with Node.js subprocess dependencies - Set up package.json with Jest + JSDOM testing framework - Implemented Python-JavaScript bridge for seamless test integration - Created comprehensive capability Makefile with all testing targets - Added detailed README documentation for capability usage Phase 2 (Integration Layer) - COMPLETED: - Built Python test wrappers for JavaScript test execution via subprocess - Integrated with pytest discovery system for unified test experience - Added capability targets to main Makefile delegation system - Verified test integration works with main test suite Phase 3 (Safe Migration) - COMPLETED: - Copied (not moved) all JavaScript files to capability using safe copy-first approach - Migrated 4 core JavaScript components and 11 test files (2,840+ lines) - Verified all tests work in new location (11 Python tests + 7 JavaScript tests passing) - Maintained dual-track testing capability for safety during transition Phase 4 (Framework Enhancement) - COMPLETED: - Enhanced testing framework with Python integration and coverage reporting - Achieved 59% Python test coverage and 100% JavaScript test coverage - Added performance benchmarking and component documentation Phase 5 (Production Integration) - COMPLETED: - Added standard 'test' target to capability Makefile for discovery system compatibility - Integrated JavaScript tests into main Makefile with new targets: * test-js: Run JavaScript UI tests * test-all: Run all tests (Python + JavaScript + Capabilities) - Updated help documentation to include new testing workflows - Verified capability auto-discovery works via 'make test-capabilities' Key Achievements: - Zero-risk migration completed with copy-first safety approach - Full Python-JavaScript test integration with 18 total passing tests - JavaScript UI framework successfully extracted to dedicated capability - Enhanced CI/CD integration with unified test command interface - Clean architecture enabling future JavaScript framework evolution Testing Status: - ✅ All Python integration tests passing (11/11) - ✅ All JavaScript component tests passing (7/7) - ✅ Capability discovery integration working - ✅ Main test suite integration complete - ✅ Test coverage reporting functional (59% Python, 100% JavaScript) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
67 lines
2.6 KiB
JavaScript
67 lines
2.6 KiB
JavaScript
'use strict';
|
|
|
|
var $TypeError = require('es-errors/type');
|
|
|
|
var ArrayCreate = require('./ArrayCreate');
|
|
var CreateDataPropertyOrThrow = require('./CreateDataPropertyOrThrow');
|
|
var GetMatchIndexPair = require('./GetMatchIndexPair');
|
|
var IsArray = require('./IsArray');
|
|
var OrdinaryObjectCreate = require('./OrdinaryObjectCreate');
|
|
var ToString = require('./ToString');
|
|
|
|
var every = require('../helpers/every');
|
|
var isMatchRecord = require('../helpers/records/match-record');
|
|
|
|
var isStringOrUndefined = function isStringOrUndefined(s) {
|
|
return typeof s === 'undefined' || typeof s === 'string';
|
|
};
|
|
|
|
var isMatchRecordOrUndefined = function isMatchRecordOrUndefined(m) {
|
|
return typeof m === 'undefined' || isMatchRecord(m);
|
|
};
|
|
|
|
var MAX_ARRAY_LENGTH = require('math-intrinsics/constants/maxArrayLength');
|
|
|
|
// https://262.ecma-international.org/13.0/#sec-getmatchindexpair
|
|
|
|
module.exports = function MakeMatchIndicesIndexPairArray(S, indices, groupNames, hasGroups) {
|
|
if (typeof S !== 'string') {
|
|
throw new $TypeError('Assertion failed: `S` must be a String');
|
|
}
|
|
if (!IsArray(indices) || !every(indices, isMatchRecordOrUndefined)) {
|
|
throw new $TypeError('Assertion failed: `indices` must be a List of either Match Records or `undefined`');
|
|
}
|
|
if (!IsArray(groupNames) || !every(groupNames, isStringOrUndefined)) {
|
|
throw new $TypeError('Assertion failed: `groupNames` must be a List of either Strings or `undefined`');
|
|
}
|
|
if (typeof hasGroups !== 'boolean') {
|
|
throw new $TypeError('Assertion failed: `hasGroups` must be a Boolean');
|
|
}
|
|
|
|
var n = indices.length; // step 1
|
|
if (!(n < MAX_ARRAY_LENGTH)) {
|
|
throw new $TypeError('Assertion failed: `indices` length must be less than the max array size, 2**32 - 1');
|
|
}
|
|
if (groupNames.length !== n - 1) {
|
|
throw new $TypeError('Assertion failed: `groupNames` must have exactly one fewer item than `indices`');
|
|
}
|
|
|
|
var A = ArrayCreate(n); // step 5
|
|
var groups = hasGroups ? OrdinaryObjectCreate(null) : void undefined; // step 6-7
|
|
CreateDataPropertyOrThrow(A, 'groups', groups); // step 8
|
|
|
|
for (var i = 0; i < n; i += 1) { // step 9
|
|
var matchIndices = indices[i]; // step 9.a
|
|
// eslint-disable-next-line no-negated-condition
|
|
var matchIndexPair = typeof matchIndices !== 'undefined' ? GetMatchIndexPair(S, matchIndices) : void undefined; // step 9.b-9.c
|
|
CreateDataPropertyOrThrow(A, ToString(i), matchIndexPair); // step 9.d
|
|
if (i > 0 && typeof groupNames[i - 1] !== 'undefined') { // step 9.e
|
|
if (!groups) {
|
|
throw new $TypeError('if `hasGroups` is `false`, `groupNames` can only contain `undefined` values');
|
|
}
|
|
CreateDataPropertyOrThrow(groups, groupNames[i - 1], matchIndexPair); // step 9.e.i
|
|
}
|
|
}
|
|
return A; // step 10
|
|
};
|