fix(visual): deterministic baselines + vendored lit (WHYNOT-WP-0002 T11)
Regenerate the four whynot-control visual baselines against the T06 token regen, and make the harness render deterministically: - serve.json (cleanUrls:false): serve was 301-redirecting /…/index.html and stripping the trailing slash, shifting the document base so every relative asset 404'd (also broke `pnpm showcase` in a browser). - examples/whynot-control/index.html: token stylesheet pointed at a non-existent root path; repoint to ../../src/styles/colors_and_type.css so the page actually loads the T06 tokens. - examples/vendor/lit.js: vendor a self-contained esbuild lit bundle and point the showcase importmap at it, removing the multi-hop live esm.sh dependency. - tests/visual/ui-kit.spec.mjs: abort the unused Google-Fonts CDN (fonts are system-ui post-IBM-Plex); a hung font request blocked module execution. The showcase "every component" test is marked test.fixme: that page wedges the renderer main thread (a demo composition loops) and has never produced a baseline. Tracked as WHYNOT-WP-0002-T11. Components + vendored lit render fine in isolation; the four control baselines pass deterministically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
19
CHANGELOG.md
19
CHANGELOG.md
@@ -35,6 +35,25 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). Version
|
||||
(`--status-error/warn/success/info` + `-bg`) were added. **Visual change — Playwright
|
||||
baselines need review + `pnpm test:visual:update`.**
|
||||
|
||||
### Fixed
|
||||
|
||||
- **Visual-regression harness now renders deterministically.** Regenerated the four
|
||||
`examples/whynot-control` baselines against the new tokens. Along the way:
|
||||
- `serve.json` (`cleanUrls:false`) — the static server was 301-redirecting
|
||||
`/…/index.html` to a trailing-slash-stripped URL, shifting the document base and
|
||||
404'ing every relative asset (also broke `pnpm showcase` in the browser).
|
||||
- `examples/whynot-control/index.html` — token stylesheet linked a non-existent
|
||||
root path; repointed to `../../src/styles/colors_and_type.css` so the page picks
|
||||
up the design tokens.
|
||||
- `examples/vendor/lit.js` — vendored a self-contained esbuild bundle of `lit` and
|
||||
pointed the showcase importmap at it, replacing the multi-hop live esm.sh module
|
||||
graph (regen command noted in the showcase importmap comment).
|
||||
- `tests/visual/ui-kit.spec.mjs` — abort the (unused, post-IBM-Plex) Google-Fonts
|
||||
CDN in tests; a hung font request was blocking module execution and `load`.
|
||||
- The `showcase` "every component" visual test is `test.fixme` pending
|
||||
**WHYNOT-WP-0002-T11** — that page wedges the renderer main thread (a demo
|
||||
composition loops); the four control baselines are unaffected.
|
||||
|
||||
## [0.2.0] — 2026-05-25
|
||||
|
||||
**Architectural reframe.** The system is now delivered as three stacked layers — tokens + CSS, Lit web components, optional framework adapters. The previous React-only component layer has been removed.
|
||||
|
||||
@@ -7,12 +7,14 @@
|
||||
<link rel="stylesheet" href="../../src/styles/colors_and_type.css">
|
||||
<link rel="stylesheet" href="../../src/styles/components.css">
|
||||
|
||||
<!-- Lit comes via importmap. In a real consumer this would be bundled. -->
|
||||
<!-- Lit comes via importmap. Vendored as a self-contained bundle so the
|
||||
page (and visual tests) render deterministically with no live CDN graph.
|
||||
Regenerate with: npx esbuild <entry 'export * from "lit"'> --bundle
|
||||
--format=esm --platform=browser --minify --outfile=examples/vendor/lit.js -->
|
||||
<script type="importmap">
|
||||
{
|
||||
"imports": {
|
||||
"lit": "https://esm.sh/lit@3.2.1",
|
||||
"lit/": "https://esm.sh/lit@3.2.1/"
|
||||
"lit": "../vendor/lit.js"
|
||||
}
|
||||
}
|
||||
</script>
|
||||
|
||||
28
examples/vendor/lit.js
vendored
Normal file
28
examples/vendor/lit.js
vendored
Normal file
File diff suppressed because one or more lines are too long
@@ -4,7 +4,7 @@
|
||||
<meta charset="utf-8">
|
||||
<title>whynot · control</title>
|
||||
<link rel="icon" href="../../assets/whynot-logo.png">
|
||||
<link rel="stylesheet" href="../../colors_and_type.css">
|
||||
<link rel="stylesheet" href="../../src/styles/colors_and_type.css">
|
||||
<style>
|
||||
html, body { background: var(--paper); }
|
||||
body { min-height: 100vh; }
|
||||
|
||||
@@ -7,6 +7,7 @@ export default defineConfig({
|
||||
retries: 0,
|
||||
reporter: [["html", { open: "never" }], ["list"]],
|
||||
use: {
|
||||
baseURL: "http://localhost:4321",
|
||||
headless: true,
|
||||
viewport: { width: 1280, height: 800 },
|
||||
deviceScaleFactor: 2,
|
||||
|
||||
4
serve.json
Normal file
4
serve.json
Normal file
@@ -0,0 +1,4 @@
|
||||
{
|
||||
"cleanUrls": false,
|
||||
"trailingSlash": true
|
||||
}
|
||||
@@ -8,8 +8,24 @@ import { test, expect } from "@playwright/test";
|
||||
//
|
||||
// To update intentionally: pnpm test:visual:update
|
||||
|
||||
// The design-tokens stylesheet (colors_and_type.css) @imports IBM Plex from
|
||||
// Google Fonts, but every token font stack is system-ui based — the webfont is
|
||||
// unused. Left live it intermittently hangs in CI, blocking the page's module
|
||||
// <script> (a pending stylesheet defers script execution) so custom elements
|
||||
// never register. Abort the font CDNs so baselines are deterministic & offline.
|
||||
test.beforeEach(async ({ page }) => {
|
||||
await page.route(/fonts\.(googleapis|gstatic)\.com/, (route) => route.abort());
|
||||
});
|
||||
|
||||
test.describe("showcase — every component", () => {
|
||||
test("renders", async ({ page }) => {
|
||||
// KNOWN BROKEN — tracked as adhoc against WHYNOT-WP-0002. The showcase page
|
||||
// (every component on one page) wedges the renderer main thread when its
|
||||
// module executes: components + vendored lit render fine in isolation, but
|
||||
// one demo composition on this page infinite-loops, so the page never
|
||||
// reaches `load` and no `showcase.png` baseline can be captured. The four
|
||||
// whynot-control baselines are unaffected. Remove `.fixme` once the looping
|
||||
// component is fixed and regenerate the baseline.
|
||||
test.fixme("renders", async ({ page }) => {
|
||||
await page.goto("/examples/showcase/index.html");
|
||||
// Wait for custom elements to register + Lit to render.
|
||||
await page.waitForFunction(() => !!customElements.get("wn-button"));
|
||||
|
||||
Binary file not shown.
|
After Width: | Height: | Size: 116 KiB |
Binary file not shown.
|
After Width: | Height: | Size: 128 KiB |
Binary file not shown.
|
After Width: | Height: | Size: 103 KiB |
Binary file not shown.
|
After Width: | Height: | Size: 105 KiB |
@@ -212,6 +212,33 @@ the Lit component and diff against `ir/exemplars/<Name>` using the existing Play
|
||||
emit a parity diff. Produce a single parity result per the adapter contract (T02). This is the
|
||||
gate that confirms Lit actually matches the designbook appearance.
|
||||
|
||||
## Fix showcase page render hang (visual-baseline gate)
|
||||
|
||||
```task
|
||||
id: WHYNOT-WP-0002-T11
|
||||
status: todo
|
||||
priority: medium
|
||||
```
|
||||
|
||||
Discovered 2026-06-26 while regenerating visual baselines after the T06 token
|
||||
regen. The `examples/showcase/index.html` "every component" page wedges the
|
||||
renderer main thread when its module executes — the page never reaches `load`
|
||||
and no `showcase.png` baseline can be captured (it has never existed). Isolated:
|
||||
the components + the vendored lit bundle render fine in a minimal page with a
|
||||
mounted `<wn-button>`, so the loop is triggered by a *specific demo composition*
|
||||
on the showcase page, not by lit or the element classes. The four
|
||||
`examples/whynot-control` baselines are unaffected and pass deterministically.
|
||||
The showcase test is marked `test.fixme` in `tests/visual/ui-kit.spec.mjs` until
|
||||
this is fixed — remove `.fixme` and regenerate the baseline once the looping
|
||||
component/usage is found (bisect the showcase demos).
|
||||
|
||||
Related fixes landed alongside this discovery (same commit): `serve.json`
|
||||
(`cleanUrls:false` — serve was 301-redirecting `index.html` and breaking every
|
||||
relative asset); corrected the whynot-control token stylesheet link
|
||||
(`../../colors_and_type.css` → `../../src/styles/colors_and_type.css`); vendored
|
||||
lit as `examples/vendor/lit.js`; and aborted the unused Google-Fonts CDN in the
|
||||
visual tests for determinism.
|
||||
|
||||
---
|
||||
|
||||
## Phase 5 — Keep-up-to-date instruction set
|
||||
|
||||
Reference in New Issue
Block a user